Shlomi Noach
7c9c2b3f43
Merge pull request #795 from mohitm15/master
...
Update command-line-flags.md
2019-11-05 10:57:50 +02:00
Mohit Maroliya
859800079b
Update doc/command-line-flags.md
...
Thank you for the suggestion @shlomi-noach
Co-Authored-By: Shlomi Noach <shlomi-noach@github.com>
2019-10-31 20:13:54 +05:30
Mohit Maroliya
991cdc51f0
Update command-line-flags.md
2019-10-31 19:28:54 +05:30
Shlomi Noach
af43fbd52f
Merge pull request #788 from github/context-status
...
context, status and hooks: progressPct and CurrentLag
2019-10-30 08:03:24 +02:00
Shlomi Noach
d0ce7c014e
truncate lag digits
2019-10-23 10:18:56 +03:00
Shlomi Noach
21e7ec6b7c
lag: %+vs notation, e.g. 1s
2019-10-07 07:06:11 +03:00
Shlomi Noach
271c7274a3
refactor progressPct into migrationContext
2019-10-07 06:59:56 +03:00
Shlomi Noach
8893b2207b
documenting new hook env variables
2019-10-06 17:12:20 +03:00
Shlomi Noach
7869889988
context, status and hooks: progressPct and CurrentLag
2019-10-06 17:08:35 +03:00
Shlomi Noach
dcc3e90f29
Merge pull request #778 from github/ci-build-pipelines
...
CI: adapting to internal builds system
2019-08-15 11:25:11 +03:00
Shlomi Noach
36b0adb1b8
executable scripts
2019-08-15 11:14:10 +03:00
Shlomi Noach
6cc1a1a34e
CI: adapting to internal builds system
2019-08-15 11:10:48 +03:00
Shlomi Noach
cc3caffe67
Merge pull request #777 from github/ggunson-panic-message
...
Changing the panic message
2019-08-13 08:41:03 +03:00
Shlomi Noach
3175c2fe74
Merge branch 'master' into ggunson-panic-message
2019-08-13 08:39:43 +03:00
Shlomi Noach
26afeed694
Merge pull request #776 from github/initial-github-ci-cd
...
Initial GitHub CI/CD
2019-08-13 08:21:15 +03:00
Gillian Gunson
3362c5d322
Changing panic message
2019-08-12 12:40:31 -07:00
Shlomi Noach
143abf05b0
fail when go is < 1.12
2019-08-12 08:03:17 +03:00
Shlomi Noach
e1c8df7447
travis: declaring mysql service
2019-08-11 15:29:28 +03:00
Shlomi Noach
17e4fe8017
TravisCI updated to go1.12 ; but we are likely to remove TravisCI anyhow
2019-08-11 15:26:29 +03:00
Shlomi Noach
90ab2368dd
graceful sleep; remove extra debug info
2019-08-11 15:21:04 +03:00
Shlomi Noach
1305ff6e01
debug info
2019-08-11 15:17:48 +03:00
Shlomi Noach
106ca5df3c
debug info
2019-08-11 15:12:14 +03:00
Shlomi Noach
b881bff1e8
fixed linter issue
2019-08-11 15:06:03 +03:00
Shlomi Noach
e618682ff9
go1.12
2019-08-11 15:04:04 +03:00
Shlomi Noach
18612b661a
name of test
2019-08-11 14:59:22 +03:00
Shlomi Noach
6cfa76d139
adding replica-tests
2019-08-11 14:58:37 +03:00
Shlomi Noach
43ea21c3bb
Initial GitHub CI/CD
...
GitHub CI/CD is [a thing](https://github.com/features/actions )! We will attempt:
- CI: build + unit test
- replica tests: running `gh-ost` tests on multiple MySQL versions
2019-08-11 14:54:00 +03:00
Shlomi Noach
b38814f90e
Merge pull request #754 from zmoazeni/zmoazeni/bump-localtests-default-retries
...
Bump default-retries to 3
2019-06-10 16:50:21 +03:00
Zach Moazeni
84fe34b22c
Bump default-retries to 3
...
There are some legitimate retries that can occur during testing. Namely
`logic.ExpectProcess()` (in `applier.go`). We'll look for a process that
does exist, but timing-wise doesn't have the `state` or `info` columns
populated.
Without this, the test will fail abruptly.
2019-06-10 09:24:03 -04:00
Shlomi Noach
8113d38d57
Merge pull request #723 from github/no-auto-value-on-zero
...
Always use NO_AUTO_VALUE_ON_ZERO
2019-06-10 16:05:30 +03:00
Shlomi Noach
681458e8f9
Merge branch 'master' into no-auto-value-on-zero
2019-06-10 15:17:39 +03:00
Shlomi Noach
bd47692beb
Merge pull request #736 from github/update-go-sql-driver
...
Update go-sql-driver/mysql 2019-05-16
2019-06-10 15:17:22 +03:00
Shlomi Noach
b8cdd5d133
Update go-sql-driver/mysql 2019-05-16
2019-05-16 13:29:40 +03:00
Shlomi Noach
226cf03a6d
Merge branch 'master' into no-auto-value-on-zero
2019-05-16 13:23:34 +03:00
Shlomi Noach
ffc6c40150
Merge pull request #726 from jchambers/patch-1
...
Fix a trivial it's/its typo.
2019-04-14 08:18:29 +03:00
Jon Chambers
256025853c
Fix a trivial it's/its typo.
2019-04-12 12:07:00 -04:00
Shlomi Noach
64db9b6b18
Merge branch 'master' into no-auto-value-on-zero
2019-04-02 13:18:30 +03:00
Shlomi Noach
7cc1817b81
Merge pull request #724 from simonw/patch-1
...
Clarify it's foreign key /constraints/ that don't work
2019-03-31 06:53:48 +03:00
Simon Willison
773cddc88a
Clarify it's foreign key /constraints/ that don't work
2019-03-29 05:05:40 -07:00
Shlomi Noach
f0ed7aeb0b
Always use NO_AUTO_VALUE_ON_ZERO
2019-03-24 11:32:42 +02:00
Shlomi Noach
4d7370529b
Always use NO_AUTO_VALUE_ON_ZERO
2019-03-24 11:32:37 +02:00
Shlomi Noach
d6c650837f
Merge pull request #712 from babinomec/skip-strict-mode
...
add --skip-strict-mode option
2019-03-24 11:13:59 +02:00
Shlomi Noach
7ae32f7184
Merge branch 'master' into skip-strict-mode
2019-03-17 23:49:13 -07:00
Shlomi Noach
2c0aa36251
Merge pull request #695 from github/named-panic
...
Adding --force-named-panic option
2019-03-11 17:54:02 +02:00
Shlomi Noach
766040d83f
Merge branch 'master' into named-panic
2019-03-06 12:47:06 +02:00
Shlomi Noach
0e3685773a
Merge pull request #716 from RafeKettler/rafe/ssl-crt-key
...
Improve SSL support
2019-03-06 08:38:11 +02:00
Shlomi Noach
7ead4c4a56
named throttle, no-throttle
2019-02-25 14:02:57 +02:00
Shlomi Noach
ff17d2f844
Merge branch 'master' into named-panic
2019-02-25 14:00:12 +02:00
Rafe Kettler
b4da7cfbfb
Improve SSL support
...
Related issue: https://github.com/github/gh-ost/issues/521
- Add --ssl-cert and --ssl-key options to specify SSL public/private
key files
- Allow combining --ssl-allow-insecure with other --ssl* flags.
`mysql.RegisterTLSConfig` allows combining the corresponding
parameters in the `tls.Config` it receives, so gh-ost should
allow this. I found being able to pass --ssl-allow-insecure along
with --ssl-ca, --ssl-cert, and --ssl-key useful in testing.
- Use the same TLS config everywhere. Since the CLI only supports
a single set of --ssl* configuration parameters, this should be
fine -- `mysql.RegisterTLSConfig` documentation indicates the
TLS config given will not be modified, so it can safely be used
in many goroutines provided we also do not modify it. The previous
implementation did not work when the TLS config was duplicated,
which happens when gh-ost walks up the replication chain trying
to find the master. This is because, when the config is duplicated,
we must call `RegisterTLSConfig` again with the new config. This
config is exactly the same, so it's easiest to side-step the issue
by registering the TLS config once and using it everywhere.
2019-02-22 10:33:19 -08:00
babinomec
7d5749b84a
add --skip-strict-mode option
2019-02-14 15:58:49 +01:00