Tim Vaillancourt
84dca03311
Add script and docs for linter ( #1151 )
2022-07-18 18:21:32 +02:00
Tim Vaillancourt
f527d63c86
Move .Kill() func from inspector to go/mysql ( #1148 )
2022-07-11 11:02:04 +02:00
dm-2
ae02941f67
Merge pull request #1147 from timvaillancourt/rm-go-os-process-go
...
Remove unused `go/os/process.go`
2022-07-08 11:22:09 +01:00
dm-2
ed8c05c210
Merge branch 'master' into rm-go-os-process-go
2022-07-08 10:50:05 +01:00
dm-2
4648da15ec
Merge pull request #1134 from github/changelog-migrated-state
...
Add `Migrated` changelog event state
2022-07-08 10:48:40 +01:00
Tim Vaillancourt
582d4cb115
Merge branch 'master' into rm-go-os-process-go
2022-07-08 00:21:25 +02:00
Tim Vaillancourt
30c868816c
Remove unused go/os/process.go
2022-07-08 00:19:54 +02:00
dm-2
607ea8d3a9
Merge branch 'master' into changelog-migrated-state
2022-07-07 17:01:16 +01:00
dm-2
3da9a9c015
Merge pull request #1146 from github/switch-to-term-package
...
Switch to golang.org/x/term; go mod vendor
2022-07-07 17:00:22 +01:00
Tim Vaillancourt
54db4174b3
Consolidate no-op states
2022-07-07 17:40:01 +02:00
Tim Vaillancourt
246800e053
Fix lint
2022-07-07 17:38:41 +02:00
dm-2
9c611bda50
switch to golang.org/x/term from deprecated golang.org/x/crypto/ssh/terminal module; go mod vendor
2022-07-07 16:38:22 +01:00
Tim Vaillancourt
d6d1d3b436
Merge branch 'master' into changelog-migrated-state
2022-07-07 17:35:59 +02:00
dm-2
eee8ffe7dc
Merge pull request #1145 from timvaillancourt/golang-ci-staticcheck-linter
...
`golang-ci`: enable/fix `staticcheck` lint warnings
2022-07-07 16:22:49 +01:00
dm-2
f9fa4231d7
Merge branch 'master' into golang-ci-staticcheck-linter
2022-07-07 15:47:59 +01:00
dm-2
78da0d09c4
Merge pull request #1138 from github/changlog-table-comment
...
Changlog table comment
2022-07-07 15:47:21 +01:00
dm-2
6d5d49616f
Merge branch 'master' into golang-ci-staticcheck-linter
2022-07-07 15:46:18 +01:00
dm-2
8eb9708755
Merge branch 'master' into changlog-table-comment
2022-07-07 15:34:30 +01:00
dm-2
02258ac15d
Merge pull request #1137 from github/go-mysql-binlog-dead-code
...
Remove unused code in `go/mysql/binlog.go`
2022-07-07 15:07:24 +01:00
Tim Vaillancourt
e45357097f
cleanup v5
2022-07-07 05:10:22 +02:00
Tim Vaillancourt
eead61cb6d
cleanup v4
2022-07-07 05:05:37 +02:00
Tim Vaillancourt
c3593c94ff
cleanup v3
2022-07-07 03:27:36 +02:00
Tim Vaillancourt
0303031fc2
cleanup v2
2022-07-07 03:22:53 +02:00
Tim Vaillancourt
0ec555badf
Cleanup
2022-07-07 03:19:53 +02:00
Tim Vaillancourt
500fbefdb9
golang-ci: fix staticcheck linter warnings
2022-07-07 03:12:44 +02:00
Tim Vaillancourt
09bb5caf88
Merge branch 'master' into go-mysql-binlog-dead-code
2022-07-07 00:39:24 +02:00
Andrew Mason
b751499091
Cancel any row count queries before attempting to cut over ( #846 )
...
* Cancel any row count queries before attempting to cut over
Closes #830 . Switches from using `QueryRow` to `QueryRowContext`, and
stores a context.CancelFunc in the migration context, which is called to
halt any running row count query before beginning the cut over.
* Make it threadsafe
* Kill the count query on the database side as well
* Explicitly grab a connection to run the count, store its connection id
* When the query context is canceled, run a `KILL QUERY ?` on that connection id
* Rewrite these to use the threadsafe functions, stop exporting the cancel func
* Update logger
* Update logger
Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-07 00:23:23 +02:00
Tim Vaillancourt
308ba7f915
Default to go1.17.11 ( #1136 )
...
* Default to go1.17.11
* `go mod vendor`
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-07 00:05:23 +02:00
Tim Vaillancourt
0918bab29b
Add context/timeout to HTTP throttle check ( #1131 )
...
* Add context/timeout to HTTP throttle check
* Dont run `.GetThrottleHTTPInterval()` on every loop
* Update help message
* Var rename
* 2022
* Add timeout flag
* Add unix/tcp server commands, use ParseInt() for string->int64
* Var rename
* Re-check http timeout on every loop iteration
* Remove stale comment
* Make throttle interval idempotent
* var rename
* Usage grammar
* Make http timeout idempotent too
* Parse time.Duration once
* Move timeout to NewThrottler
* Help update
* Set User-Agent header
* Re-add newline
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-06 23:56:07 +02:00
Tim Vaillancourt
0b066c16a5
Use switch statements for readability, simplify .NewGoMySQLReader() ( #1135 )
...
* Use `switch` statements for readability
* Simplify initBinlogReader()
2022-07-06 23:45:26 +02:00
Tim Vaillancourt
6bf32f2015
Ensure mysql rows responses are closed ( #1132 )
...
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-06 23:32:15 +02:00
Shlomi Noach
cc38a17e50
compound pk tests ( #387 )
...
* compound pk tests
* more details in failure diff
* more elaborate test; the pk-ts one consistently fails
* Fix merge conflict
Co-authored-by: Shlomi Noach <shlomi-noach@github.com>
Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
2022-07-06 23:22:21 +02:00
dm-2
3901a86422
Merge pull request #1140 from timvaillancourt/fix-issue-1117
...
Fix `integer divide by zero` panic in migrator
2022-07-06 17:11:16 +01:00
dm-2
b7f7e2c0b0
Merge branch 'master' into fix-issue-1117
2022-07-06 16:58:51 +01:00
dm-2
8d9761d616
Merge pull request #1141 from shaohk/fix-two-phase-commit-lost-data_v2
...
fix(lost data in mysql two-phase commit): lost data in mysql two-phas…
2022-07-06 16:58:25 +01:00
dm-2
f35bfd3997
Merge branch 'master' into fix-issue-1117
2022-07-06 16:32:02 +01:00
dm-2
b80b6e78fd
Merge branch 'master' into fix-two-phase-commit-lost-data_v2
2022-07-06 16:25:54 +01:00
dm-2
f0209e8c71
Merge pull request #1143 from github/codeql-run-on-prs
...
Run CodeQL analysis on PRs
2022-07-06 16:25:31 +01:00
dm-2
d07c4f097d
Run CodeQL analysis on PRs
2022-07-06 16:23:15 +01:00
Tim Vaillancourt
38e86e5791
Merge branch 'master' into fix-two-phase-commit-lost-data_v2
2022-06-25 00:37:12 +02:00
shaohk
87970f6312
fix(lost data in mysql two-phase commit): lost data in mysql two-phase commit
2022-06-24 11:38:05 +08:00
Tim Vaillancourt
de339dd042
Fix integer divide by zero panic in migrator
2022-06-23 03:37:18 +02:00
Tim Vaillancourt
387b32594e
Var rename
2022-06-07 01:49:18 +02:00
Tim Vaillancourt
bf0c13b46d
Add table comment to changelog
2022-06-07 01:47:51 +02:00
Tim Vaillancourt
eb801441c2
Remove unused Type field
2022-06-06 02:31:47 +02:00
Tim Vaillancourt
261e1f7820
Remove unused code in go/mysql/binlog.go
2022-06-06 02:29:01 +02:00
Tim Vaillancourt
ec199f1185
revert out of scope change
2022-06-05 00:06:41 +02:00
Tim Vaillancourt
af99b247f9
Add Migrated changelog event
2022-06-04 23:59:00 +02:00
Tim Vaillancourt
ed46138c06
Add golangci-lint CI action, fix gosimple, govet + unused lint errors ( #1127 )
...
* Add `golangci-lint`, fix `gosimple`, `govet` and `unused` linter complaints
* Go 1.16
* Update copyright dates
2022-05-31 21:23:39 +02:00
dm-2
8f361f6445
Merge pull request #1108 from jecepeda/add-binaries-for-arm64-architectures
...
Add binaries for arm64 architectures
2022-03-11 16:37:18 +00:00
