octoleo/nativefier
2
2
Fork 0
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-11 15:51:06 +00:00
Code Issues Releases Activity

Icon conversion: don't crash if source/destination paths have spaces (PR #736)

Browse Source
This commit is contained in:
Dword 2019-01-09 16:08:17 +01:00 committed by Ronan Jouchet
parent c722f8a5ac
commit 3588f8a85f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/helpers/convertToIcns.js
View File

@ -27,7 +27,7 @@ function convertToIcns(pngSrc, icnsDest, callback) {
} }
shell.exec( shell.exec(
`${PNG_TO_ICNS_BIN_PATH} ${pngSrc} ${icnsDest}`, `"${PNG_TO_ICNS_BIN_PATH}" "${pngSrc}" "${icnsDest}"`,
{ silent: true }, { silent: true },
(exitCode, stdOut, stdError) => { (exitCode, stdOut, stdError) => {
if (stdOut.includes('icon.iconset:error') || exitCode) { if (stdOut.includes('icon.iconset:error') || exitCode) {

2
src/helpers/iconShellHelpers.js
View File

@ -28,7 +28,7 @@ function iconShellHelper(shellScriptPath, icoSrc, dest) {
} }
shell.exec( shell.exec(
`${shellScriptPath} ${icoSrc} ${dest}`, `"${shellScriptPath}" "${icoSrc}" "${dest}"`,
{ silent: true }, { silent: true },
(exitCode, stdOut, stdError) => { (exitCode, stdOut, stdError) => {
if (exitCode) { if (exitCode) {