octoleo
/
nativefier
mirror of https://github.com/Llewellynvdm/nativefier.git
2
2
Fork 0
Code Issues Releases Activity

document contextIsolation stuff

This commit is contained in:
Ronan Jouchet 2021-12-06 16:05:41 -05:00
parent ec77741494
commit 58e504de32
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/helpers/windowHelpers.ts
View File

@ -148,6 +148,15 @@ export function getDefaultWindowOptions(
plugins: true,
webSecurity: !options.insecure,
zoomFactor: options.zoom,
// `contextIsolation` was switched to true in Electron 12, which:
// 1. Breaks access to global variables in `--inject`-ed scripts:
// https://github.com/nativefier/nativefier/issues/1269
// 2. Might break notifications under Windows, although this was refuted:
// https://github.com/nativefier/nativefier/issues/1292
// So, it was flipped to false in https://github.com/nativefier/nativefier/pull/1308
//
// If attempting to set it back to `true` (for security),
// do test exhaustively these two areas, and more.
contextIsolation: false,
...webPreferences,
},