2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-12-22 10:08:55 +00:00

Bump max tested version of Node for CI/Publish from 17 to 18

Released yesterday: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V18.md#18.0.0
This commit is contained in:
Ronan Jouchet 2022-04-20 22:06:46 -04:00
parent e664bc6af8
commit 60035a8e74
2 changed files with 3 additions and 3 deletions

View File

@ -14,7 +14,7 @@ jobs:
matrix:
node-version:
# Align the top Node version here with: 1. linter conditions later below, 2. publish.yml.
- '17'
- '18'
# Bumping the minimum required Node version? You must bump:
# 1. package.json -> engines.node
# 2. package.json -> devDependencies.@types/node
@ -43,7 +43,7 @@ jobs:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
run: npm ci --no-fund
# Only run linter once, for faster CI. Align the versions of Node here with above and publish.yml.
- if: matrix.platform == 'ubuntu-latest' && matrix.node-version == '17'
- if: matrix.platform == 'ubuntu-latest' && matrix.node-version == '18'
run: npm run lint
- run: npm run test -- --testPathIgnorePatterns ".*playwright.*"
- if: matrix.platform != 'ubuntu-latest' # Doesn't work on non-GUI ubuntu

View File

@ -12,7 +12,7 @@ jobs:
- uses: actions/setup-node@v1
with:
# Align the version of Node here with ci.yml.
node-version: '17.x'
node-version: '18.x'
registry-url: 'https://registry.npmjs.org'
# Will also (through `prepare` hook): 1. install ./app, and 2. build
- run: npm ci --no-fund