octoleo/nativefier
2
2
Fork 0
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-09-26 19:49:02 +00:00
Code Issues Releases Activity

Fix #146 Specifying --electron-version does not work

Browse Source
This commit is contained in:
Jia Hao 2016-02-22 02:46:42 +08:00
parent cf24858ba6
commit 88bb589de8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/options/optionsMain.js
View File

@ -35,7 +35,7 @@ function optionsFactory(inpOptions, callback) {
targetUrl: normalizeUrl(inpOptions.targetUrl), targetUrl: normalizeUrl(inpOptions.targetUrl),
platform: inpOptions.platform || inferPlatform(), platform: inpOptions.platform || inferPlatform(),
arch: inpOptions.arch || inferArch(), arch: inpOptions.arch || inferArch(),
version: ELECTRON_VERSION, version: inpOptions.electronVersion || ELECTRON_VERSION,
nativefierVersion: packageJson.version, nativefierVersion: packageJson.version,
out: inpOptions.out || process.cwd(), out: inpOptions.out || process.cwd(),
overwrite: inpOptions.overwrite || false, overwrite: inpOptions.overwrite || false,
@ -69,6 +69,7 @@ function optionsFactory(inpOptions, callback) {
}); });
}, },
callback => { callback => {
// length also checks if its the commanderJS function or a string
if (options.name && options.name.length > 0) { if (options.name && options.name.length > 0) {
callback(); callback();
return; return;