HACKING.md: clarification

This commit is contained in:
Ronan Jouchet 2021-06-16 19:15:05 -04:00
parent 564c616d12
commit b2af6f5435
1 changed files with 2 additions and 1 deletions

View File

@ -114,7 +114,8 @@ but is painful to do manually. Do yourself a favor and install a
When a new major [Electron release](https://github.com/electron/electron/releases) occurs,
1. Wait a few weeks to let it stabilize. Never upgrade Nativefier to a `.0.0`.
2. Thoroughly digest the new version's [breaking changes](https://www.electronjs.org/docs/breaking-changes)
2. Thoroughly digest the new version's [breaking changes](https://www.electronjs.org/docs/breaking-changes),
grepping our codebase for every changed API.
- If called for by the breaking changes, perform the necessary API changes
3. Bump `src/constants.ts` / `DEFAULT_ELECTRON_VERSION` & `DEFAULT_CHROME_VERSION`
4. On Windows, macOS, Linux, test for regression and crashes: