Force all external links to be opened externally (#624)

This commit is contained in:
David Kramer 2018-05-27 11:04:08 -07:00 committed by Ronan Jouchet
parent 1afc480923
commit bde4ea68fd
1 changed files with 9 additions and 0 deletions

View File

@ -195,6 +195,13 @@ function createMainWindow(inpOptions, onAppQuit, setDockBadge) {
});
};
const onWillNavigate = (event, urlToGo) => {
if (!linkIsInternal(options.targetUrl, urlToGo, options.internalUrls)) {
event.preventDefault();
shell.openExternal(urlToGo);
}
};
let createNewWindow;
const createNewTab = (url, foreground) => {
@ -245,6 +252,7 @@ function createMainWindow(inpOptions, onAppQuit, setDockBadge) {
maybeInjectCss(window);
sendParamsOnDidFinishLoad(window);
window.webContents.on('new-window', onNewWindow);
window.webContents.on('will-navigate', onWillNavigate);
window.loadURL(url);
return window;
};
@ -301,6 +309,7 @@ function createMainWindow(inpOptions, onAppQuit, setDockBadge) {
}
mainWindow.webContents.on('new-window', onNewWindow);
mainWindow.webContents.on('will-navigate', onWillNavigate);
mainWindow.loadURL(options.targetUrl);