octoleo/nativefier
2
2
Fork 0
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2025-01-23 15:18:30 +00:00
Code Issues Releases Activity

Fix #65: Rename Helper application on Mac OS X

Browse Source 
This fixes the helper process showing up in Activity Monitor as
"Electron Helper"; it will now show up as "<appname> Helper".
This commit is contained in:
Kenneth G. Franqueiro 2015-06-17 23:50:52 -04:00
parent 554f3b7354
commit dd2a5d4b68
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
mac.js
View File

@ -35,7 +35,8 @@ function buildMacApp (opts, cb, newApp) {
var paths = {
info1: path.join(newApp, 'Contents', 'Info.plist'),
info2: path.join(newApp, 'Contents', 'Frameworks', 'Electron Helper.app', 'Contents', 'Info.plist'),
app: path.join(newApp, 'Contents', 'Resources', 'app')
app: path.join(newApp, 'Contents', 'Resources', 'app'),
helper: path.join(newApp, 'Contents', 'Frameworks', 'Electron Helper.app')
}
// update plist files
@ -72,6 +73,21 @@ function buildMacApp (opts, cb, newApp) {
ncp(opts.dir, paths.app, {filter: common.userIgnoreFilter(opts), dereference: true}, function copied (err) {
if (err) return cb(err)
function moveHelper () {
// Move helper binary before moving the parent helper app directory itself
var helperDestination = path.join(path.dirname(paths.helper), opts.name + ' Helper.app')
var helperBinary = path.join(paths.helper, 'Contents', 'MacOS', 'Electron Helper')
var helperBinaryDestination = path.join(path.dirname(helperBinary), opts.name + ' Helper')
fs.rename(helperBinary, helperBinaryDestination, function (err) {
if (err) return cb(err)
fs.rename(paths.helper, helperDestination, function (err) {
if (err) return cb(err)
moveApp()
})
})
}
function moveApp () {
// finally, move app into cwd
var outdir = opts.out || process.cwd()
@ -122,6 +138,6 @@ function buildMacApp (opts, cb, newApp) {
})
}
common.prune(opts, paths.app, cb, moveApp)
common.prune(opts, paths.app, cb, moveHelper)
})
}