octoleo/nativefier
2
2
Fork 0
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-09-22 01:29:02 +00:00
Code Issues Releases Activity

Fix bug where icns conversion fails silently

Browse Source
This commit is contained in:
Jia Hao 2016-03-08 20:55:42 +08:00
parent c8d6cef815
commit e2d762b721
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/helpers/pngToIcns.js
View File

@ -26,6 +26,7 @@ function pngToIcns(pngSrc, icnsDest, callback) {
}
shell.exec(`${PNG_TO_ICNS_BIN_PATH} ${pngSrc} ${icnsDest}`, {silent: true}, (exitCode, stdOut, stdError) => {
if (stdOut.includes('icon.iconset:error') || exitCode) {
if (exitCode) {
callback({
stdOut: stdOut,
@ -34,6 +35,10 @@ function pngToIcns(pngSrc, icnsDest, callback) {
return;
}
callback(stdOut, pngSrc);
return;
}
callback(null, icnsDest);
});
}