2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-12-22 01:58:54 +00:00
Commit Graph

15 Commits

Author SHA1 Message Date
Adam Weeden
c39932731d
npm i in the Dockerfile to esnure we have what we need to build + test (#1557) 2023-08-03 17:44:36 -04:00
Ronan Jouchet
0de2463f2b Docker: actually let's use *lts*-alpine, for more futureproof-ness 2022-07-24 12:26:22 -04:00
Ronan Jouchet
c725243152 Docker: upgrade base node-alpine img from 12 to 18
Node 12 makes PlayWright complain,
https://github.com/nativefier/nativefier/runs/7489079540?check_suite_focus=true
2022-07-24 12:25:09 -04:00
Ronan Jouchet
334cbe28a5 Publish: fix Docker build failing because of Playwright, and make a convenience npm task for it 2022-05-02 00:27:58 -04:00
Ronan Jouchet
1521a28f45 Docker: fix build 2021-03-10 20:06:39 -05:00
Ronan Jouchet
ffa421eb8e Docker: attempt to fix build
See https://hub.docker.com/api/audit/v1/action/05620acd-9984-4e10-9053-3a7edc0c8558/ :

```
The command '/bin/sh -c npm link && npm test && rm -rf /tmp/nativefier* ~/.npm/_cacache ~/.cache/electron && chmod +x $NPM_PACKAGES/bin/nativefier' returned a non-zero code: 243
```

Culprit could be `rm -rf /tmp/nativefier*` : at this point /tmp/nativefier
doesn't exist, so `sh` cannot evaluate glob `/tmp/nativefier*`, and exits 1
2021-03-10 19:44:44 -05:00
Adam Weeden
e9ccb35825
Docker: slim down image size, by removing temp/cache files (PR #1128)
Per the [note](https://github.com/nativefier/nativefier/pull/1122#discussion_r588922780) by @SuperSandro2000 in #1122 Docker will still cache files in intermediate layers if you delete them, so they'll still be part of the image.

Only solution seems to be to delete them as you create them so they don't cache:
Per https://stackoverflow.com/questions/53998310/docker-remove-file-from-intermediate-layer

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
2021-03-10 18:54:33 -05:00
Adam Weeden
8f9135312b
Docker: fix Windows builds (fix #997), line endings, switch to Alpine (PR #1122)
- Docker builds for Windows are fixed (fixes #997)
- Switched over to use Alpine (as was indicated as desired in https://github.com/nativefier/nativefier/issues/375#issuecomment-304247033) - which may mean #375 is fixed as well.
- Fixed bug where Docker has the wrong line endings when copying from a Windows host
- Fixed the invalid `arm` arch to `armv7l`
- Add `npm t` to the docker build to ensure tests pass before we start trying to do builds
- Add a message to help the user when trying to build Mac apps on Windows as a non-Admin (currently an unhelpful exception)

Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
2021-03-02 00:16:30 -05:00
Jia Hao
6316d23762 Move to nativefier organization 2021-01-30 04:49:52 +00:00
Ronan Jouchet
fd88d5199f Restore & pimp docker docs in README, now that Docker build has been fixed by Jia (thanks Jia) (fix #848) 2020-08-10 21:33:32 -04:00
Ronan Jouchet
cc8d65063a Simplify README, move unmaintained docker doc to Dockerfile 2020-07-18 10:19:58 -04:00
Pranav Shikarpur
e592c6bca6
Bumped up NODE docker image version from 8 to 12.18.1 (#996)
Updated Node version in the Dockerfile from 8-stretch to 12.18.1-stretch. 12.18.1 is currently the most recent LTS version of NodeJS.
2020-06-28 16:15:30 -04:00
Ronan Jouchet
2b377a7916
Fix #461 & address #375 in Docker: move Dockerfile to Debian and use wine32 (#488)
- Should address #375 (building a win app from linux) under Docker,
  thanks @dipenpatel235 for the suggestion to use `wine32` at
  https://github.com/jiahaog/nativefier/issues/375#issuecomment-304247033
- Regarding #461, Docker build seems fine but it was already
  fine for some time, not sure what happened.

Also clean up a bit the Dockerfile using suggestions from
[hadolint](https://github.com/lukasmartinelli/hadolint/).
2017-11-24 10:28:59 -05:00
Ronan Jouchet
6ac4f33661 Update Dockerfile to node8-alpine, fix typos 2017-11-16 14:08:30 -05:00
Tobias Schneck
95cc30983b Run Nativefier with Docker (#311)
TODO: windows are currently not possible, because of non 64-bit version of `node-rcedit`, see https://github.com/electron/node-rcedit/issues/22. Also there is currently no 32-bit alpine package for wine, what possible solve this image.
2017-05-19 21:21:16 +08:00