2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-16 10:05:09 +00:00
Commit Graph

28 Commits

Author SHA1 Message Date
Ronan Jouchet
35eb72edfd Fix travis build
We no longer have a postinstall so we need to explicitly
'npm run dev-up' for cli+app deps, like we did before.
2020-03-16 21:20:38 -04:00
Ronan Jouchet
b16e893237 Travis: only attempt to deploy with linux/node12 build, take 2 2020-03-15 17:40:43 -04:00
Ronan Jouchet
fd37a6a4c8 Align full tests (linter+tests) with deployment platform 2020-03-15 17:23:48 -04:00
Ronan Jouchet
20de73c559 Travis: only attempt to deploy with linux/node12 build 2020-03-15 17:09:56 -04:00
Ronan Jouchet
c9ee6667d4
Revamp and move to TypeScript (#898)
## Breaking changes

- Require **Node >= 8.10.0 and npm 5.6.0**
- Move to **Electron 8.1.1**.
- That's it. Lots of care went into breaking CLI & programmatic behavior
  as little as possible. **Please report regressions**.
- Known issue: build may fail behind a proxy. Get in touch if you use one:
  https://github.com/jiahaog/nativefier/issues/907#issuecomment-596144768

## Changes summary

Nativefier didn't get much love recently, to the point that it's
becoming hard to run on recent Node, due to old dependencies.
Also, some past practices now seem weird, as better expressible
by modern JS/TS, discouraging contributions including mine.

Addressing this, and one thing leading to another, came a
bigger-than-expected revamp, aiming at making Nativefier more
**lean, stable, future-proof, user-friendly and dev-friendly**,
while **not changing the CLI/programmatic interfaces**. Highlights:

- **Require Node>=8**, as imposed by many of our dependencies. Node 8
  is twice LTS, and easily available even in conservative Linux distros.
  No reason not to demand it.
- **Default to Electron 8**.
- **Bump** all dependencies to latest version, including electron-packager.
- **Move to TS**. TS is great. As of today, I see no reason not to use it,
  and fight interface bugs at runtime rather than at compile time.
  With that, get rid of everything Babel/Webpack.
- **Move away from Gulp**. Gulp's selling point is perf via streaming,
  but for small builds like Nativefier, npm tasks are plenty good
  and less dependency bloat. Gulp was the driver for this PR: broken
  on Node 12, and I didn't feel like just upgrading and keeping it.
- Add tons of **verbose logs** everywhere it makes sense, to have a
  fine & clear trace of the program flow. This will be helpful to
  debug user-reported issues, and already helped me fix a few bugs.
    - With better simple logging, get rid of the quirky and buggy
      progress bar based on package `progress`. Nice logging (minimal
      by default, the verbose logging mentioned above is only used
      when passing `--verbose`) is better and one less dependency.
- **Dump `async` package**, a relic from old callback-hell early Node.
  Also dump a few other micro-packages unnecessary now.
- A first pass of code **cleanup** thanks to modern JS/TS features:
  fixes, simplifications, jsdoc type annotations to types, etc.
- **Remove GitHub integrations Hound & CodeClimate**, which are more
  exotic than good'ol'linters, and whose signal-to-noise ratio is too low.
- Quality: **Add tests** and add **Windows + macOS CI builds**.
  Also, add a **manual test script**, helping to quickly verify the
  hard-to-programatically-test stuff before releases, and limit regressions.
- **Fix a very small number of existing bugs**. The goal of this PR was
  *not* to fix bugs, but to get Nativefier in better shape to do so.
  Bugfixes will come later. Still, these got addressed:
  - Add common `Alt`+`Left`/`Right` for previous/next navigation.
  - Improve #379: fix zoom with `Ctrl` + numpad `+`/`-`
  - Fix pinch-to-zoom (see https://github.com/jiahaog/nativefier/issues/379#issuecomment-598612128 )
2020-03-15 16:50:01 -04:00
Ronan Jouchet
038812cd46
Travis: add Node.js 11 run 2018-11-30 21:09:17 -05:00
Goh Jia Hao
93a9833c47 Update npm token
Tokens were invalidated in https://status.npmjs.org/incidents/dn7c1fgrr7ng
2018-07-22 09:55:51 -07:00
Goh Jia Hao
4350ccf15d Don't run tests on node 4 and 5 2018-05-24 00:38:07 -07:00
Ronan Jouchet
ef755b53c7
Travis: try node 10 2018-05-02 21:51:27 -04:00
Ronan Jouchet
eeef1facf3
Stay on npm@5.8.x for a little while
npm6 breaks our node4+5 builds:

https://travis-ci.org/jiahaog/nativefier/jobs/369940904
https://travis-ci.org/jiahaog/nativefier/jobs/370872623
2018-04-25 20:33:58 -04:00
Goh Jia Hao
4f5b36f731 Fix CD with Travis #482 2018-03-29 22:22:38 -07:00
Goh Jia Hao
fef8ad2040 Remove node v9 from travis builds
We have to keep this until `npm install -g npm` supports node v9, see nodejs/node#16649
2017-11-12 17:47:32 +08:00
Goh Jia Hao
33fe71a855 Add package-lock for npm
This fixes dependency issues that were experienced in notably #425 and
other master commits I've tried to restart on 12/08/17
2017-08-12 11:34:48 +08:00
Jia Hao Goh
68b0c0ac27 Only release to NPM on one job 2017-04-30 03:10:01 +08:00
Jia Hao Goh
20fc09799b Remove Windows tests
We don't want to install wine on travis, as it slows down the whole CI
process.

We also shouldn't be testing if we can build the electron app,
and instead our unit tests should test that we pass the correct
parameters to electron packager.

TODO ^
2017-04-30 00:41:15 +08:00
Jia Hao Goh
28e1e9ee40 Cleanup travis config 2017-04-30 00:39:59 +08:00
Jia Hao Goh
eeaa531083 Add autodeploy to NPM on tag
Removing the development branch, we want to use GitHub releases to
autodeploy our changes to NPM.
2017-04-20 10:10:40 +08:00
Goh Jia Hao
c362108c73 Fix travis tests which require wine
Somehow now wine is not included on travis
2016-10-09 13:19:06 +08:00
Goh Jia Hao
6616fbbf53 Remove support for node v0.12 and iojs 2016-05-26 17:48:02 +08:00
Jia Hao
7ba016bf50 Support only node 0.12 onwards 2016-03-12 02:00:00 +08:00
Jia Hao
136c599f92 Use polyfill to support node >0.10 2016-03-12 01:36:18 +08:00
Jia Hao
13e477c238 Hide token 2016-02-03 12:00:33 +08:00
Jia Hao
362b48c411 Add codeclimate coverage 2016-02-01 15:23:29 +08:00
Jia Hao
ba0010840e Remove ci for 0.10 which causes problems with electron-prebuilt 2016-01-25 01:47:53 +08:00
Jia Hao
c1c50bab9f Configure travis to run ci test 2016-01-25 01:33:55 +08:00
Jia Hao
7c25e82c44 Add travis configuration 2016-01-24 02:05:03 +08:00
Jia Hao
5379740dda Initial commit for working module only with api change 2016-01-18 21:45:18 +08:00
Max Ogden
330e376372 dont download atom-shell -- use local version instead 2015-04-04 09:47:01 -07:00