2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-12-23 10:38:55 +00:00
Commit Graph

13 Commits

Author SHA1 Message Date
Kenneth G. Franqueiro
a157f716a5 Implement multi-target options and refactor code
This adds support for --all, --platform=all, and --arch=all.

In order to accommodate outputting multiple directories for multiple
platforms and architectures, this also implements a new directory
structure under the output folder (distinguished by both platform and
arch).  This structure is applied even to OS X distributions, which
formerly were output directly to an .app folder.  This could be considered
a backwards-incompatible change.

One other backwards-incompatible change is the value that the packager
function passes to the callback, which is now always an array of paths,
rather than just a single path.

The behavior of the icon option has also been modified to use its
basename and apply .ico or .icns depending on platform, to make it
usable with --all and --platform=all.  This attempts to maximize
backwards compatibility, by allowing a full filename to be specified,
but replacing the filename's extension with what is appropriate for
each target platform.  Alternatively, the extension can now be omitted.

In the process of implementing this, it became evident that some things
were being done in 3 different places, and weren't always being done
consistently, so I've deduplicated everything I could.

This also includes a few other changes to improve stability for
multi-target runs, and other fixes:

* Avoid targeting darwin if the environment doesn't support symlinks,
  to avoid the process bailing out on Windows
* Implement --overwrite centrally in index.js such that it explicitly
  skips if an output directory already exists, for consistency with
  all target platforms and to avoid any possible errors that would halt
  operation during one target of a multi-target run
* Use ncp instead of mv to move to finalPath, which avoids flakiness
  I noticed when testing on Windows 8 especially with multi-target runs
* Simplify temp directory logic by using a nested structure, so there
  is only one top-level directory to clean up
* Reinstate fix from #55 which seems to have been clobbered by a later
  merge
* linux.createApp now resolves to the final output directory;
  it was formerly resolving to the executable path
* mac.createApp now replaces space with underscore in bundle IDs
* Only the platform modules that are needed are loaded
* The win32 module only loads rcedit if needed

This also fixes a couple of missing updates to docs (readme/usage).

This commit addresses the following issues:

* Resolves #40
* Resolves #38
* Resolves #70
* Works around #71
* Resolves #84 by reinstating #55
2015-06-28 16:57:56 -04:00
=^._.^=
5cc8a4b688 Merge pull request #82 from kfranqueiro/win32-ignore
Fix path separator replacement for ignore on Windows
2015-06-27 19:27:07 -05:00
Kenneth G. Franqueiro
63db115257 Fix path separator replacement for ignore on Windows
This needs to be done when Windows is the host OS regardless of
the target platform, not vice versa.

Fixes #79.
2015-06-22 21:32:15 -04:00
rameshv
947c2084aa skipping the rcedit when both icon & version-string hash is not
available
2015-06-17 16:51:31 +05:30
rameshv
d2a2f05476 version-string hash added to update the windows executable resource
using rcedit
2015-06-12 21:02:47 +05:30
Mark Lee
bdc8c46362 Move prune to common module 2015-06-09 19:50:52 -07:00
Mark Lee
16b2feb39f Move user ignore filter to common module 2015-06-09 19:26:55 -07:00
Mark Lee
f3d17bceb2 Fix comment 2015-06-09 19:17:57 -07:00
Mark Lee
83dd1dcb34 Move asar code to a common location 2015-06-09 19:17:21 -07:00
=^._.^=
37e319281c Merge pull request #46 from zaggino/zaggino/fix-win
convert slashes on windows so unix-format ignores work
2015-05-21 21:06:19 -07:00
Martin Zagora
13897ff303 convert slashes on windows so unix-format ignores work 2015-05-22 11:25:41 +10:00
jden
aa5c6187e3 always dereference symlinks - per #42 2015-05-20 19:05:47 -07:00
Max Ogden
260a16509b breaking change. allow building apps for other platforms 2015-05-10 13:57:42 -07:00