mirror of
https://github.com/Llewellynvdm/nativefier.git
synced 2024-06-01 20:30:48 +00:00
8e8cd24e0d
Fixes #978 Adds a `--block-external-urls` option (default: `false`) that prevents opening external links (as classified by the `--internal-urls` option). Documentation and tests updated. Example: ``` nativefier --internal-urls "classroom\.google\.com" --block-external-urls ``` ![image](https://user-images.githubusercontent.com/12286274/88739501-f12d5180-d0f7-11ea-9821-86f3e9bfa070.png) ![image](https://user-images.githubusercontent.com/12286274/88739512-fab6b980-d0f7-11ea-877c-7bd565352a93.png)
239 lines
6.7 KiB
TypeScript
239 lines
6.7 KiB
TypeScript
import { onNewWindowHelper } from './mainWindowHelpers';
|
|
|
|
const originalUrl = 'https://medium.com/';
|
|
const internalUrl = 'https://medium.com/topics/technology';
|
|
const externalUrl = 'https://www.wikipedia.org/wiki/Electron';
|
|
const foregroundDisposition = 'foreground-tab';
|
|
const backgroundDisposition = 'background-tab';
|
|
const blockExternal = false;
|
|
|
|
const nativeTabsSupported = () => true;
|
|
const nativeTabsNotSupported = () => false;
|
|
|
|
test('internal urls should not be handled', () => {
|
|
const preventDefault = jest.fn();
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
internalUrl,
|
|
undefined,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsNotSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(0);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(0);
|
|
expect(preventDefault.mock.calls.length).toBe(0);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|
|
|
|
test('external urls should be opened externally', () => {
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const preventDefault = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
externalUrl,
|
|
undefined,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsNotSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(1);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(0);
|
|
expect(preventDefault.mock.calls.length).toBe(1);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|
|
|
|
test('external urls should be ignored if blockExternal is true', () => {
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const preventDefault = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
const blockExternal = true;
|
|
|
|
onNewWindowHelper(
|
|
externalUrl,
|
|
undefined,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsNotSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(0);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(0);
|
|
expect(preventDefault.mock.calls.length).toBe(1);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(1);
|
|
});
|
|
|
|
test('tab disposition should be ignored if tabs are not enabled', () => {
|
|
const preventDefault = jest.fn();
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
internalUrl,
|
|
foregroundDisposition,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsNotSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(0);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(0);
|
|
expect(preventDefault.mock.calls.length).toBe(0);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|
|
|
|
test('tab disposition should be ignored if url is external', () => {
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const preventDefault = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
externalUrl,
|
|
foregroundDisposition,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(1);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(0);
|
|
expect(preventDefault.mock.calls.length).toBe(1);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|
|
|
|
test('foreground tabs with internal urls should be opened in the foreground', () => {
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const preventDefault = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
internalUrl,
|
|
foregroundDisposition,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(0);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(1);
|
|
expect(createNewTab.mock.calls[0][1]).toBe(true);
|
|
expect(preventDefault.mock.calls.length).toBe(1);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|
|
|
|
test('background tabs with internal urls should be opened in background tabs', () => {
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const preventDefault = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
internalUrl,
|
|
backgroundDisposition,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(0);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(0);
|
|
expect(createNewTab.mock.calls.length).toBe(1);
|
|
expect(createNewTab.mock.calls[0][1]).toBe(false);
|
|
expect(preventDefault.mock.calls.length).toBe(1);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|
|
|
|
test('about:blank urls should be handled', () => {
|
|
const preventDefault = jest.fn();
|
|
const openExternal = jest.fn();
|
|
const createAboutBlankWindow = jest.fn();
|
|
const createNewTab = jest.fn();
|
|
const onBlockedExternalUrl = jest.fn();
|
|
|
|
onNewWindowHelper(
|
|
'about:blank',
|
|
undefined,
|
|
originalUrl,
|
|
undefined,
|
|
preventDefault,
|
|
openExternal,
|
|
createAboutBlankWindow,
|
|
nativeTabsNotSupported,
|
|
createNewTab,
|
|
blockExternal,
|
|
onBlockedExternalUrl,
|
|
);
|
|
|
|
expect(openExternal.mock.calls.length).toBe(0);
|
|
expect(createAboutBlankWindow.mock.calls.length).toBe(1);
|
|
expect(createNewTab.mock.calls.length).toBe(0);
|
|
expect(preventDefault.mock.calls.length).toBe(1);
|
|
expect(onBlockedExternalUrl.mock.calls.length).toBe(0);
|
|
});
|