2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-06-26 15:14:07 +00:00
nativefier/app/src
Sam Potts 5e526fb000
Fix badge/counter icon not being removed correctly (fixes #1251) (PR #1252)
The current check for `count` means the value to reset/remove the badge (`''`) is treated as `false` and therefore the badge does not get removed. This PR changes the check for `undefined` instead which resolves the issue. 

Related issue: 
https://github.com/nativefier/nativefier/issues/1251

Testing performed:
- I ran `npm t` as per the docs. All tests passed. 
- I created a new app build for Twitter (`https://twitter.com`) and Messenger (`https://messenger.com`) to verify the correct behaviour. Both were showed the issue as resolved. 

Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
2021-07-05 18:35:50 -04:00
..
components Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
helpers Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
mocks Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
static Revamp and move to TypeScript (#898) 2020-03-15 16:50:01 -04:00
main.ts Fix badge/counter icon not being removed correctly (fixes #1251) (PR #1252) 2021-07-05 18:35:50 -04:00
preload.ts Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00