2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-05 04:47:54 +00:00
nativefier/app
Ronan Jouchet 74a7d3375d App: revert addition of extra flag --internal-login-pages
See discussion at https://github.com/nativefier/nativefier/pull/1124#issuecomment-794751514 :

> @TheCleric I was about to merge this, then reconsidered one little thing (yes I wrote "little", I'm not reconsidering this whole thing 😅).
>
> I'm re-considering having the extra flag. I'm not so sure this will harm a lot of use cases. I'd like to 1. merge this PR, 2. immediately follow up with a small commit removing the flag & adjusting api.md, 3. release with the change well-documented / asking for feedback if this is problematic to anyone. (I'm not asking you any extra work, and like leaving an in-tree commit trace of considering the flag). If people complain with a valid reason, we'll restore the flag with a quick revert, else we're happy with one less flag and a reasonably-handled breaking change.
>
> Thoughts / objections?

Answered by:

> That seems reasonable to me.
>
> [discussion on an extra structured way to pass flags]
2021-03-10 19:36:20 -05:00
..
inject Fix bug where css is always injected 2016-02-25 15:25:14 +08:00
src App: revert addition of extra flag --internal-login-pages 2021-03-10 19:36:20 -05:00
.eslintrc.js Bump eslint to 7.x, fix new lint errors 2020-07-18 11:19:58 -04:00
.npmrc Upgrade dependencies and default to latest Electron 1.7.9 (PR #483) 2017-11-14 08:05:01 -05:00
nativefier.json Fix placeholder for electron app to google 2016-05-26 16:50:42 +08:00
package.json Bump deps 2021-03-04 12:37:11 -05:00
tsconfig.json TSConfig: bump to target/lib es2018, since we require node10 2021-02-26 22:50:59 -05:00
webpack.config.js Fix failing to global-sudo-install due to postinstall script (fix #923) 2020-03-16 21:06:03 -04:00