mirror of
https://github.com/Llewellynvdm/nativefier.git
synced 2025-02-08 22:18:25 +00:00
c0a6604676
In 6b266b78150, as I got rid of deprecated dep `wurl`, I wrote: > This one may be problematic, as it used to do TLD stuff: > https://github.com/websanova/node-url/blob/7982a613bc/wurl.js#L4 > > So, the new WHATWG-URL-based implementation will consider > `asana.com` to be "external" to `app.asana.com`, contrarily to before. > Given the nature of Nativefier, I think it's actually what to expect, > that in this case you're "out of the app", and in e.g. asana's landing > page, which you'd expect to see in your browser. Turns out it's even more problematic: @TheCleric notices in https://github.com/nativefier/nativefier/pull/1124#issuecomment-790279403 that this breaks app `https://evernote.com` doing its login in `www.evernote.com` The present change fixes this, by behaving mostly similarly to before, but without re-introducing `wurl` or another dep needing a TLD/SLD list.
