2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-10 15:21:03 +00:00
nativefier/.github
Adam Weeden 113d8448c1
Fix CSS injection (#1227)
This fixes https://github.com/nativefier/nativefier/pull/1222#issuecomment-860913698 , where:

1. When it works (e.g. initial page load), CSS is slower to inject (you can see pages without injected CSS)
2. CSS isn't injected when navigating to a page

On both Windows & Linux, a `git revert 9a6c6f870d && npm run build` fixes the issue.

--

I'm still not 100% sure what went wrong, but I suspect that the new version of Electron may not be firing onHeadersReceived for the actual navigation events, and only its child requests. To counteract it, I'm now injecting at the navigation event as well. I was able to reproduce the issue and this does seem to fix it. Please let me know if it does for you as well..

Also I noticed some funkiness in your logs where we're trying to inject on font files. So I realized the method is probably not nearly as important as the content-type, so I've switched blacklist methods to blacklist content-types.
2021-06-15 09:02:57 -04:00
..
ISSUE_TEMPLATE Get rid of "docs" folder (#1194) 2021-05-21 18:16:59 -04:00
workflows Bump minimum required version: node>=12.9, npm>=6.9 (#1192) 2021-05-15 13:32:54 -04:00
CONTRIBUTING.md Move to nativefier organization 2021-01-30 04:49:52 +00:00
dock-screenshot.png Get rid of "docs" folder (#1194) 2021-05-21 18:16:59 -04:00
generate-changelog Get rid of "docs" folder (#1194) 2021-05-21 18:16:59 -04:00
manual-test Fix CSS injection (#1227) 2021-06-15 09:02:57 -04:00
nativefier-walkthrough.gif README: whoopsie, bad rename of animation 2021-05-21 18:17:59 -04:00