2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-06-01 12:20:48 +00:00
nativefier/src/options/fields/name.ts
Adam Weeden 7a08a2d676
Enable TypeScript strict:true, and more typescript-eslint rules (#1223)
* Catch promise errors better

* Move subFunctions to bottom of createNewWindow

* Use parents when creating child BrowserWindow instances

* Some about:blank pages have an anchor (for some reason)

* Inject browserWindowOptions better

* Interim refactor to MainWindow object

* Split up the window functions/helpers/events some

* Further separate out window functions + tests

* Add a mock for unit testing functions that access electron

* Add unit tests for onWillPreventUnload

* Improve windowEvents tests

* Add the first test for windowHelpers

* Move WebRequest event handling to node

* insertCSS completely under test

* clearAppData completely under test

* Fix contextMenu require bug

* More tests + fixes

* Fix + add to createNewTab tests

* Convert createMainWindow back to func + work out gremlins

* Move setupWindow away from main since its shared

* Make sure contextMenu is handling promises

* Fix issues with fullscreen not working + menu refactor

* Run jest against app/dist so that we can hit app unit tests as well

* Requested PR changes

* Add strict typing; tests currently failing

* Fix failing unit tests

* Add some more eslint warnings and fixes

* More eslint fixes

* Strict typing on (still issues with the lib dir)

* Fix the package.json import/require

* Fix some funky test errors

* Warn -> Error for eslint rules

* @ts-ignore -> @ts-expect-error

* Add back the ext code I removed
2021-06-15 22:20:49 -04:00

37 lines
983 B
TypeScript

import * as log from 'loglevel';
import { sanitizeFilename } from '../../utils/sanitizeFilename';
import { inferTitle } from '../../infer/inferTitle';
import { DEFAULT_APP_NAME } from '../../constants';
type NameParams = {
packager: {
name?: string;
platform?: string;
targetUrl: string;
};
};
async function tryToInferName(targetUrl: string): Promise<string> {
try {
log.debug('Inferring name for', targetUrl);
const pageTitle = await inferTitle(targetUrl);
return pageTitle || DEFAULT_APP_NAME;
} catch (err: unknown) {
log.warn(
`Unable to automatically determine app name, falling back to '${DEFAULT_APP_NAME}'.`,
err,
);
return DEFAULT_APP_NAME;
}
}
export async function name(options: NameParams): Promise<string> {
let name: string | undefined = options.packager.name;
if (!name) {
name = await tryToInferName(options.packager.targetUrl);
}
return sanitizeFilename(options.packager.platform, name);
}