2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-13 16:46:26 +00:00
nativefier/app
Alexander Weps ca7d25f432
Fix notifications broken since Nativefier 43 / Electron 12 defaulting to contextIsolation:true (PR #1308)
Copy-pastaing details from [Electron 12 breaking changes](https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-120):

> ### Default Changed: `contextIsolation` defaults to `true`[​](https://www.electronjs.org/docs/latest/breaking-changes#default-changed-contextisolation-defaults-to-true "Direct link to heading")
> 
> In Electron 12, `contextIsolation` will be enabled by default. To restore the previous behavior, `contextIsolation: false` must be specified in WebPreferences.
> 
> We [recommend having contextIsolation enabled](https://www.electronjs.org/docs/latest/tutorial/security#3-enable-context-isolation-for-remote-content) for the security of your application.
> 
> Another implication is that `require()` cannot be used in the renderer process unless `nodeIntegration` is `true` and `contextIsolation` is `false`.
> 
> For more details see: [https://github.com/electron/electron/issues/23506](https://github.com/electron/electron/issues/23506)

I find the security drop acceptable, as reverting the new Electron 12 isolation brings us to the previous level of security, and I don't have the time/will to keep the isolation and migrate to the newer better safer thing that Electron >= 12 wants.

Co-authored-by: Radomír Polách <rp@t4d.cz>
2021-11-22 16:00:13 -05:00
..
inject Fix bug where css is always injected 2016-02-25 15:25:14 +08:00
src Fix notifications broken since Nativefier 43 / Electron 12 defaulting to contextIsolation:true (PR #1308) 2021-11-22 16:00:13 -05:00
.eslintrc.js Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
nativefier.json Fix placeholder for electron app to google 2016-05-26 16:50:42 +08:00
npm-shrinkwrap.json Bump default Electron to 13.6.1, with security fixes 2021-11-01 15:37:33 -04:00
package.json Bump default Electron to 13.6.1, with security fixes 2021-11-01 15:37:33 -04:00
tsconfig.json Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
webpack.config.js More test:watch fixes & usability 2021-06-01 23:37:04 -04:00