octoleo
/
qpdf
mirror of https://github.com/qpdf/qpdf.git
2
1
Fork 0
Code Issues Releases Wiki Activity

Fix loop in QPDFOutlineDocumentHelper (fuzz issue 30507)

This commit is contained in:
Jay Berkenbilt 2021-02-10 16:26:32 -05:00
parent 4d1f2fdcac
commit 9fcf61b2f6
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -1,5 +1,8 @@
2021-02-10 Jay Berkenbilt <ejb@ql.org>
* Detect loops when adding when reading outlines dictionary upon
initialization of QPDFOutlineDocumentHelper (fuzz issue 30507).
* Add "attachments" as an additional json key, and add some
information about attachments to the json output.

BIN
fuzz/qpdf_extra/30507.fuzz Normal file
View File

Binary file not shown.

7
libqpdf/QPDFOutlineDocumentHelper.cc
View File

@ -24,8 +24,15 @@ QPDFOutlineDocumentHelper::QPDFOutlineDocumentHelper(QPDF& qpdf) :
return;
}
QPDFObjectHandle cur = outlines.getKey("/First");
std::set<QPDFObjGen> seen;
while (! cur.isNull())
{
auto og = cur.getObjGen();
if (seen.count(og))
{
break;
}
seen.insert(og);
this->m->outlines.push_back(
QPDFOutlineObjectHelper::Accessor::create(cur, *this, 1));
cur = cur.getKey("/Next");