octoleo/qpdf
2
1
Fork 0
mirror of https://github.com/qpdf/qpdf.git synced 2024-12-31 22:11:53 +00:00
Code Issues Releases Wiki Activity

Revert "Check for warnings in files used by --pages"

Browse Source 
m-holger's fix is better

This reverts commit fa3cdaf1b4.
This commit is contained in:
Jay Berkenbilt 2023-09-03 08:12:31 -04:00
parent fa3cdaf1b4
commit c6a3d83fb5
4 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,9 +1,3 @@
2023-09-03 Jay Berkenbilt <ejb@ql.org>
* Bug fix: with --pages, if one of the external files had warnings
but the main file did not, the warning was previously not taken
into consideration when determining the exit status.
2023-09-02 Jay Berkenbilt <ejb@ql.org> 2023-09-02 Jay Berkenbilt <ejb@ql.org>
* Bug fix from M. Holger: allow fix-qdf to read from pipe. Fixes #1010. * Bug fix from M. Holger: allow fix-qdf to read from pipe. Fixes #1010.

5
libqpdf/QPDFJob.cc
View File

@ -2561,11 +2561,6 @@ QPDFJob::handlePageSpecs(QPDF& pdf, std::vector<std::unique_ptr<QPDF>>& page_hea
} }
} }
} }
for (auto const& p: page_spec_qpdfs) {
if (!p.second->getWarnings().empty()) {
m->warnings = true;
}
}
} }
void void

2
qpdf/qtest/page-errors.test
View File

@ -22,7 +22,7 @@ $td->runtest("handle page no with contents",
$td->NORMALIZE_NEWLINES); $td->NORMALIZE_NEWLINES);
$td->runtest("handle page with missing MediaBox", $td->runtest("handle page with missing MediaBox",
{$td->COMMAND => "qpdf --static-id --empty --pages page-no-content.pdf -- out.pdf"}, {$td->COMMAND => "qpdf --static-id --empty --pages page-no-content.pdf -- out.pdf"},
{$td->FILE => "page-missing-mediabox.out", $td->EXIT_STATUS => 3}, {$td->FILE => "page-missing-mediabox.out", $td->EXIT_STATUS => 0},
$td->NORMALIZE_NEWLINES); $td->NORMALIZE_NEWLINES);
$td->runtest("check output", $td->runtest("check output",
{$td->FILE => "out.pdf"}, {$td->FILE => "out.pdf"},

1
qpdf/qtest/qpdf/page-missing-mediabox.out
View File

@ -1,2 +1 @@
WARNING: page-no-content.pdf, object 4 0 at offset 288: kid 1 (from 0) MediaBox is undefined; setting to letter / ANSI A WARNING: page-no-content.pdf, object 4 0 at offset 288: kid 1 (from 0) MediaBox is undefined; setting to letter / ANSI A
qpdf: operation succeeded with warnings; resulting file may have some problems