2019-10-13 05:59:52 +00:00
< ? php
2021-05-09 20:15:43 +00:00
declare ( strict_types = 1 );
2020-08-18 15:57:30 +00:00
namespace Rector\CodeQuality\Rector\Identical ;
2019-07-04 21:18:06 +00:00
use PhpParser\Node ;
2021-09-27 15:43:15 +00:00
use PhpParser\Node\Arg ;
2019-07-05 15:06:28 +00:00
use PhpParser\Node\Expr ;
2019-07-04 21:18:06 +00:00
use PhpParser\Node\Expr\BinaryOp\Identical ;
use PhpParser\Node\Expr\FuncCall ;
2019-07-05 15:06:28 +00:00
use PhpParser\Node\Scalar\String_ ;
2021-10-11 23:20:15 +00:00
use PHPStan\Type\StringType ;
2021-10-12 08:14:21 +00:00
use Rector\Core\NodeAnalyzer\ArgsAnalyzer ;
2020-02-06 21:48:18 +00:00
use Rector\Core\Rector\AbstractRector ;
2020-11-16 17:50:38 +00:00
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample ;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition ;
2019-09-03 09:11:45 +00:00
/**
2021-03-12 22:20:25 +00:00
* @ see \Rector\Tests\CodeQuality\Rector\Identical\StrlenZeroToIdenticalEmptyStringRector\StrlenZeroToIdenticalEmptyStringRectorTest
2019-09-03 09:11:45 +00:00
*/
2021-05-10 22:23:08 +00:00
final class StrlenZeroToIdenticalEmptyStringRector extends \Rector\Core\Rector\AbstractRector
2019-07-04 21:18:06 +00:00
{
2021-09-27 15:43:15 +00:00
/**
2021-12-04 12:47:17 +00:00
* @ readonly
2021-09-27 15:43:15 +00:00
* @ var \Rector\Core\NodeAnalyzer\ArgsAnalyzer
*/
private $argsAnalyzer ;
public function __construct ( \Rector\Core\NodeAnalyzer\ArgsAnalyzer $argsAnalyzer )
{
$this -> argsAnalyzer = $argsAnalyzer ;
}
2021-05-10 22:23:08 +00:00
public function getRuleDefinition () : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
2019-07-04 21:18:06 +00:00
{
2021-05-10 22:23:08 +00:00
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition ( 'Changes strlen comparison to 0 to direct empty string compare' , [ new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample ( <<< 'CODE_SAMPLE'
2019-07-04 21:18:06 +00:00
class SomeClass
{
2021-10-11 23:20:15 +00:00
public function run ( string $value )
2019-07-04 21:18:06 +00:00
{
$empty = strlen ( $value ) === 0 ;
}
}
2020-09-15 08:23:13 +00:00
CODE_SAMPLE
2021-05-09 20:15:43 +00:00
, <<< 'CODE_SAMPLE'
2019-07-04 21:18:06 +00:00
class SomeClass
{
2021-10-11 23:20:15 +00:00
public function run ( string $value )
2019-07-04 21:18:06 +00:00
{
$empty = $value === '' ;
}
}
2020-09-15 08:23:13 +00:00
CODE_SAMPLE
2021-05-09 20:15:43 +00:00
)]);
2019-07-04 21:18:06 +00:00
}
/**
2021-02-27 00:06:15 +00:00
* @ return array < class - string < Node >>
2019-07-04 21:18:06 +00:00
*/
2021-05-09 20:15:43 +00:00
public function getNodeTypes () : array
2019-07-04 21:18:06 +00:00
{
2021-05-10 22:23:08 +00:00
return [ \PhpParser\Node\Expr\BinaryOp\Identical :: class ];
2019-07-04 21:18:06 +00:00
}
/**
2021-12-10 09:57:54 +00:00
* @ param \PhpParser\Node $node
2019-07-04 21:18:06 +00:00
*/
2021-12-10 09:57:54 +00:00
public function refactor ( $node ) : ? \PhpParser\Node
2019-07-04 21:18:06 +00:00
{
2021-05-10 22:23:08 +00:00
if ( $node -> left instanceof \PhpParser\Node\Expr\FuncCall ) {
2021-10-11 23:20:15 +00:00
return $this -> processIdentical ( $node -> right , $node -> left );
2021-09-27 15:43:15 +00:00
}
if ( $node -> right instanceof \PhpParser\Node\Expr\FuncCall ) {
2021-10-11 23:20:15 +00:00
return $this -> processIdentical ( $node -> left , $node -> right );
2021-09-27 15:43:15 +00:00
}
return null ;
}
2021-10-12 08:14:21 +00:00
private function processIdentical ( \PhpParser\Node\Expr $expr , \PhpParser\Node\Expr\FuncCall $funcCall ) : ? \PhpParser\Node\Expr\BinaryOp\Identical
2021-09-27 15:43:15 +00:00
{
if ( ! $this -> isName ( $funcCall , 'strlen' )) {
return null ;
}
2021-10-12 08:14:21 +00:00
if ( ! $this -> valueResolver -> isValue ( $expr , 0 )) {
2021-09-27 15:43:15 +00:00
return null ;
}
if ( ! $this -> argsAnalyzer -> isArgInstanceInArgsPosition ( $funcCall -> args , 0 )) {
return null ;
}
/** @var Arg $firstArg */
$firstArg = $funcCall -> args [ 0 ];
/** @var Expr $variable */
$variable = $firstArg -> value ;
2021-10-11 23:20:15 +00:00
// Needs string cast if variable type is not string
// see https://github.com/rectorphp/rector/issues/6700
$isStringType = $this -> nodeTypeResolver -> getNativeType ( $variable ) instanceof \PHPStan\Type\StringType ;
if ( ! $isStringType ) {
return new \PhpParser\Node\Expr\BinaryOp\Identical ( new \PhpParser\Node\Expr\Cast\String_ ( $variable ), new \PhpParser\Node\Scalar\String_ ( '' ));
2021-09-27 15:43:15 +00:00
}
2021-05-10 22:23:08 +00:00
return new \PhpParser\Node\Expr\BinaryOp\Identical ( $variable , new \PhpParser\Node\Scalar\String_ ( '' ));
2019-07-04 21:18:06 +00:00
}
}