2019-10-13 05:59:52 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
declare(strict_types=1);
|
2019-07-04 21:18:06 +00:00
|
|
|
|
2020-08-18 15:57:30 +00:00
|
|
|
namespace Rector\CodeQuality\Rector\Identical;
|
2019-07-04 21:18:06 +00:00
|
|
|
|
|
|
|
use PhpParser\Node;
|
2019-07-05 15:06:28 +00:00
|
|
|
use PhpParser\Node\Expr;
|
2019-07-04 21:18:06 +00:00
|
|
|
use PhpParser\Node\Expr\BinaryOp\Identical;
|
|
|
|
use PhpParser\Node\Expr\FuncCall;
|
2019-07-05 15:06:28 +00:00
|
|
|
use PhpParser\Node\Scalar\String_;
|
2020-02-06 21:48:18 +00:00
|
|
|
use Rector\Core\Rector\AbstractRector;
|
2020-11-16 17:50:38 +00:00
|
|
|
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
|
|
|
|
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
|
2019-07-04 21:18:06 +00:00
|
|
|
|
2019-09-03 09:11:45 +00:00
|
|
|
/**
|
2020-08-18 15:57:30 +00:00
|
|
|
* @see \Rector\CodeQuality\Tests\Rector\Identical\StrlenZeroToIdenticalEmptyStringRector\StrlenZeroToIdenticalEmptyStringRectorTest
|
2019-09-03 09:11:45 +00:00
|
|
|
*/
|
2019-07-04 21:18:06 +00:00
|
|
|
final class StrlenZeroToIdenticalEmptyStringRector extends AbstractRector
|
|
|
|
{
|
2020-11-16 17:50:38 +00:00
|
|
|
public function getRuleDefinition(): RuleDefinition
|
2019-07-04 21:18:06 +00:00
|
|
|
{
|
2020-11-16 17:50:38 +00:00
|
|
|
return new RuleDefinition(
|
|
|
|
'Changes strlen comparison to 0 to direct empty string compare',
|
|
|
|
[
|
|
|
|
new CodeSample(
|
|
|
|
<<<'CODE_SAMPLE'
|
2019-07-04 21:18:06 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function run($value)
|
|
|
|
{
|
|
|
|
$empty = strlen($value) === 0;
|
|
|
|
}
|
|
|
|
}
|
2020-09-15 08:23:13 +00:00
|
|
|
CODE_SAMPLE
|
2020-11-16 17:50:38 +00:00
|
|
|
,
|
|
|
|
<<<'CODE_SAMPLE'
|
2019-07-04 21:18:06 +00:00
|
|
|
class SomeClass
|
|
|
|
{
|
|
|
|
public function run($value)
|
|
|
|
{
|
|
|
|
$empty = $value === '';
|
|
|
|
}
|
|
|
|
}
|
2020-09-15 08:23:13 +00:00
|
|
|
CODE_SAMPLE
|
2021-03-03 08:49:57 +00:00
|
|
|
),
|
2020-11-16 17:50:38 +00:00
|
|
|
]);
|
2019-07-04 21:18:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2021-02-27 00:06:15 +00:00
|
|
|
* @return array<class-string<Node>>
|
2019-07-04 21:18:06 +00:00
|
|
|
*/
|
|
|
|
public function getNodeTypes(): array
|
|
|
|
{
|
|
|
|
return [Identical::class];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @param Identical $node
|
|
|
|
*/
|
|
|
|
public function refactor(Node $node): ?Node
|
|
|
|
{
|
|
|
|
$variable = null;
|
|
|
|
if ($node->left instanceof FuncCall) {
|
|
|
|
if (! $this->isName($node->left, 'strlen')) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
2021-01-30 23:20:05 +00:00
|
|
|
if (! $this->valueResolver->isValue($node->right, 0)) {
|
2019-07-04 21:18:06 +00:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
$variable = $node->left->args[0]->value;
|
2019-07-09 15:06:58 +00:00
|
|
|
} elseif ($node->right instanceof FuncCall) {
|
2019-07-04 21:18:06 +00:00
|
|
|
if (! $this->isName($node->right, 'strlen')) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
2021-01-30 23:20:05 +00:00
|
|
|
if (! $this->valueResolver->isValue($node->left, 0)) {
|
2019-07-04 21:18:06 +00:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
$variable = $node->right->args[0]->value;
|
2019-07-09 15:06:58 +00:00
|
|
|
} else {
|
|
|
|
return null;
|
2019-07-04 21:18:06 +00:00
|
|
|
}
|
|
|
|
|
2019-07-05 15:06:28 +00:00
|
|
|
/** @var Expr $variable */
|
|
|
|
return new Identical($variable, new String_(''));
|
2019-07-04 21:18:06 +00:00
|
|
|
}
|
|
|
|
}
|