rector/rules/code-quality/src/Rector/FuncCall/SingleInArrayToCompareRector.php

97 lines
2.3 KiB
PHP
Raw Normal View History

2019-10-13 05:59:52 +00:00
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ArrayItem;
use PhpParser\Node\Expr\BinaryOp\Equal;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\FuncCall;
use Rector\Core\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
2019-09-03 09:11:45 +00:00
/**
* @see \Rector\CodeQuality\Tests\Rector\FuncCall\SingleInArrayToCompareRector\SingleInArrayToCompareRectorTest
*/
final class SingleInArrayToCompareRector extends AbstractRector
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Changes in_array() with single element to ===',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
if (in_array(strtolower($type), ['$this'], true)) {
return strtolower($type);
}
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
if (strtolower($type) === '$this') {
return strtolower($type);
}
}
}
CODE_SAMPLE
),
]);
}
/**
* @return string[]
*/
public function getNodeTypes(): array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->isName($node, 'in_array')) {
return null;
}
if (! $node->args[1]->value instanceof Array_) {
return null;
}
/** @var Array_ $arrayNode */
$arrayNode = $node->args[1]->value;
if (count($arrayNode->items) !== 1) {
return null;
}
$firstArrayItem = $arrayNode->items[0];
if (! $firstArrayItem instanceof ArrayItem) {
return null;
}
$firstArrayItemValue = $firstArrayItem->value;
// strict
if (isset($node->args[2])) {
return new Identical($node->args[0]->value, $firstArrayItemValue);
}
return new Equal($node->args[0]->value, $firstArrayItemValue);
}
}