rector/rules/Php80/Rector/ClassMethod/OptionalParametersAfterRequiredRector.php

166 lines
6.6 KiB
PHP
Raw Normal View History

<?php
declare (strict_types=1);
namespace Rector\Php80\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Reflection\MethodReflection;
use Rector\Core\PHPStan\Reflection\CallReflectionResolver;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\Reflection\ReflectionResolver;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Php80\NodeResolver\ArgumentSorter;
use Rector\Php80\NodeResolver\RequireOptionalParamResolver;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
2021-04-10 18:47:17 +00:00
* @changelog https://php.watch/versions/8.0#deprecate-required-param-after-optional
*
* @see \Rector\Tests\Php80\Rector\ClassMethod\OptionalParametersAfterRequiredRector\OptionalParametersAfterRequiredRectorTest
*/
final class OptionalParametersAfterRequiredRector extends \Rector\Core\Rector\AbstractRector
{
/**
* @var \Rector\Php80\NodeResolver\RequireOptionalParamResolver
*/
private $requireOptionalParamResolver;
/**
* @var \Rector\Php80\NodeResolver\ArgumentSorter
*/
private $argumentSorter;
/**
* @var \Rector\Core\PHPStan\Reflection\CallReflectionResolver
*/
private $callReflectionResolver;
/**
* @var \Rector\Core\Reflection\ReflectionResolver
*/
private $reflectionResolver;
public function __construct(\Rector\Php80\NodeResolver\RequireOptionalParamResolver $requireOptionalParamResolver, \Rector\Php80\NodeResolver\ArgumentSorter $argumentSorter, \Rector\Core\PHPStan\Reflection\CallReflectionResolver $callReflectionResolver, \Rector\Core\Reflection\ReflectionResolver $reflectionResolver)
{
$this->requireOptionalParamResolver = $requireOptionalParamResolver;
$this->argumentSorter = $argumentSorter;
$this->callReflectionResolver = $callReflectionResolver;
$this->reflectionResolver = $reflectionResolver;
}
public function getRuleDefinition() : \Symplify\RuleDocGenerator\ValueObject\RuleDefinition
{
return new \Symplify\RuleDocGenerator\ValueObject\RuleDefinition('Move required parameters after optional ones', [new \Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample(<<<'CODE_SAMPLE'
class SomeObject
{
public function run($optional = 1, $required)
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeObject
{
public function run($required, $optional = 1)
{
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [\PhpParser\Node\Stmt\ClassMethod::class, \PhpParser\Node\Expr\New_::class, \PhpParser\Node\Expr\MethodCall::class];
}
/**
* @param ClassMethod|New_|MethodCall $node
*/
public function refactor(\PhpParser\Node $node) : ?\PhpParser\Node
{
if ($node instanceof \PhpParser\Node\Stmt\ClassMethod) {
return $this->refactorClassMethod($node);
}
if ($node instanceof \PhpParser\Node\Expr\New_) {
return $this->refactorNew($node);
}
return $this->refactorMethodCall($node);
}
private function refactorClassMethod(\PhpParser\Node\Stmt\ClassMethod $classMethod) : ?\PhpParser\Node\Stmt\ClassMethod
{
if ($classMethod->params === []) {
return null;
}
$classMethod->getAttribute(\Rector\NodeTypeResolver\Node\AttributeKey::CLASS_NAME);
$classMethodReflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($classMethod);
if (!$classMethodReflection instanceof \PHPStan\Reflection\MethodReflection) {
return null;
}
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($classMethodReflection, $classMethod->params);
if ($expectedArgOrParamOrder === null) {
return null;
}
$newParams = $this->argumentSorter->sortArgsByExpectedParamOrder($classMethod->params, $expectedArgOrParamOrder);
$classMethod->params = $newParams;
return $classMethod;
}
private function refactorNew(\PhpParser\Node\Expr\New_ $new) : ?\PhpParser\Node\Expr\New_
{
if ($new->args === []) {
return null;
}
$methodReflection = $this->reflectionResolver->resolveMethodReflectionFromNew($new);
if (!$methodReflection instanceof \PHPStan\Reflection\MethodReflection) {
return null;
}
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection, $new->args);
if ($expectedArgOrParamOrder === null) {
return null;
}
$new->args = $this->argumentSorter->sortArgsByExpectedParamOrder($new->args, $expectedArgOrParamOrder);
return $new;
}
private function refactorMethodCall(\PhpParser\Node\Expr\MethodCall $methodCall) : ?\PhpParser\Node\Expr\MethodCall
{
$methodReflection = $this->callReflectionResolver->resolveCall($methodCall);
if (!$methodReflection instanceof \PHPStan\Reflection\MethodReflection) {
return null;
}
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection, $methodCall->args);
if ($expectedArgOrParamOrder === null) {
return null;
}
$newArgs = $this->argumentSorter->sortArgsByExpectedParamOrder($methodCall->args, $expectedArgOrParamOrder);
if ($methodCall->args === $newArgs) {
return null;
}
$methodCall->args = $newArgs;
return $methodCall;
}
/**
* @param array<Node\Arg|Node\Param> $argsOrParams
* @return int[]|null
*/
private function resolveExpectedArgParamOrderIfDifferent(\PHPStan\Reflection\MethodReflection $methodReflection, array $argsOrParams) : ?array
{
$classReflection = $methodReflection->getDeclaringClass();
$fileName = $classReflection->getFileName();
// probably internal class
if ($fileName === \false) {
return null;
}
if (\strpos($fileName, '/vendor/') !== \false) {
return null;
}
$parametersAcceptor = $methodReflection->getVariants()[0];
$expectedParameterReflections = $this->requireOptionalParamResolver->resolveFromReflection($methodReflection);
if (\count($argsOrParams) !== \count($parametersAcceptor->getParameters())) {
return null;
}
if ($expectedParameterReflections === $parametersAcceptor->getParameters()) {
return null;
}
return \array_keys($expectedParameterReflections);
}
}