rector/rules/CodeQuality/Rector/Ternary/UnnecessaryTernaryExpressionRector.php

122 lines
4.2 KiB
PHP
Raw Normal View History

2019-10-13 05:59:52 +00:00
<?php
declare (strict_types=1);
namespace Rector\CodeQuality\Rector\Ternary;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\Cast\Bool_;
use PhpParser\Node\Expr\Ternary;
use Rector\PhpParser\Node\AssignAndBinaryMap;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
2019-09-03 09:11:45 +00:00
/**
* @see \Rector\Tests\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector\UnnecessaryTernaryExpressionRectorTest
2019-09-03 09:11:45 +00:00
*/
final class UnnecessaryTernaryExpressionRector extends AbstractRector
{
2018-05-17 17:05:00 +00:00
/**
* @readonly
* @var \Rector\PhpParser\Node\AssignAndBinaryMap
2018-05-17 17:05:00 +00:00
*/
2018-11-07 17:22:27 +00:00
private $assignAndBinaryMap;
/**
* @readonly
* @var \Rector\PhpParser\Node\Value\ValueResolver
*/
private $valueResolver;
public function __construct(AssignAndBinaryMap $assignAndBinaryMap, ValueResolver $valueResolver)
2018-11-07 17:22:27 +00:00
{
$this->assignAndBinaryMap = $assignAndBinaryMap;
$this->valueResolver = $valueResolver;
2018-11-07 17:22:27 +00:00
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove unnecessary ternary expressions', [new CodeSample('$foo === $bar ? true : false;', '$foo === $bar;')]);
}
2018-08-14 22:12:41 +00:00
/**
* @return array<class-string<Node>>
2018-08-14 22:12:41 +00:00
*/
public function getNodeTypes() : array
{
return [Ternary::class];
}
/**
* @param Ternary $node
*/
public function refactor(Node $node) : ?Node
{
if (!$node->if instanceof Expr) {
return null;
}
$ifExpression = $node->if;
if (!$this->valueResolver->isTrueOrFalse($ifExpression)) {
2019-01-14 18:21:23 +00:00
return null;
}
$elseExpression = $node->else;
if (!$this->valueResolver->isTrueOrFalse($elseExpression)) {
return null;
}
$condition = $node->cond;
if (!$condition instanceof BinaryOp) {
return $this->processNonBinaryCondition($ifExpression, $elseExpression, $condition);
}
2021-01-30 23:20:05 +00:00
if ($this->valueResolver->isNull($ifExpression)) {
return null;
}
2021-01-30 23:20:05 +00:00
if ($this->valueResolver->isNull($elseExpression)) {
return null;
}
2018-05-17 17:04:22 +00:00
/** @var BinaryOp $binaryOperation */
$binaryOperation = $node->cond;
2021-01-30 23:20:05 +00:00
if ($this->valueResolver->isTrue($ifExpression) && $this->valueResolver->isFalse($elseExpression)) {
2018-05-17 17:04:22 +00:00
return $binaryOperation;
2018-05-13 18:19:51 +00:00
}
2018-11-07 17:22:27 +00:00
$inversedBinaryClass = $this->assignAndBinaryMap->getInversed($binaryOperation);
if ($inversedBinaryClass === null) {
return null;
2018-05-17 17:06:58 +00:00
}
2018-11-07 17:22:27 +00:00
return new $inversedBinaryClass($binaryOperation->left, $binaryOperation->right);
2018-05-17 17:06:58 +00:00
}
private function processNonBinaryCondition(Expr $ifExpression, Expr $elseExpression, Expr $condition) : ?Node
{
2021-01-30 23:20:05 +00:00
if ($this->valueResolver->isTrue($ifExpression) && $this->valueResolver->isFalse($elseExpression)) {
return $this->processTrueIfExpressionWithFalseElseExpression($condition);
}
if (!$this->valueResolver->isFalse($ifExpression)) {
return null;
}
if (!$this->valueResolver->isTrue($elseExpression)) {
return null;
}
return $this->processFalseIfExpressionWithTrueElseExpression($condition);
}
private function processTrueIfExpressionWithFalseElseExpression(Expr $expr) : Expr
{
$exprType = $this->getType($expr);
if ($exprType->isBoolean()->yes()) {
return $expr;
}
return new Bool_($expr);
}
private function processFalseIfExpressionWithTrueElseExpression(Expr $expr) : Expr
{
if ($expr instanceof BooleanNot) {
$negatedExprType = $this->getType($expr->expr);
if ($negatedExprType->isBoolean()->yes()) {
return $expr->expr;
}
return new Bool_($expr->expr);
}
$exprType = $this->getType($expr);
if ($exprType->isBoolean()->yes()) {
return new BooleanNot($expr);
}
return new BooleanNot(new Bool_($expr));
}
}