Commit Graph

5241 Commits

Author SHA1 Message Date
Aerendir e88d18ca98 Clean `tests` folder. 2020-03-05 14:25:49 +01:00
Aerendir cc0fcb8446 Small refactorings. 2020-03-05 14:25:49 +01:00
Aerendir 1cbb1f1fe8 Support `$this->method()`. 2020-03-05 14:25:49 +01:00
Aerendir fe1a46e2b8 Apply fixes. 2020-03-05 10:05:35 +01:00
Aerendir 02673e6a77 Add doc comment to `refactor()` method. 2020-03-05 09:58:41 +01:00
Aerendir 60e00df74c Add link to `regex101.com`. 2020-03-05 09:58:41 +01:00
Aerendir 547b4d40b5 Support `ClassMethod`. 2020-03-05 09:58:41 +01:00
Aerendir c3d23f2491 Support `Assign`. 2020-03-05 09:58:36 +01:00
TomasVotruba 1b937ec0e0 fix method annotation 2020-03-04 23:22:29 +01:00
Aerendir ec691ff260 Support throwing methods. 2020-03-04 17:13:51 +01:00
Stefan Blanke 19d18c5a6a Add two failings tests 2020-03-04 14:54:21 +01:00
Aerendir d7cd5c3cba Complete refactoring. 2020-03-04 14:41:59 +01:00
Aerendir d449075643 Support analysis of called functions. 2020-03-04 09:13:42 +01:00
Dorian Villet b550b6bf3b Fix various static calls errors in PHPUnit Rectors. 2020-03-03 13:35:18 +01:00
Tomas Votruba 3d0bf1163d
Merge pull request #2990 from gnutix/AssertTrueFalseToSpecificMethodRector/add-broken-test-static-call
AssertTrueFalseToSpecificMethodRector: add broken test ('Pick more specific node than PhpParser\Node\Expr\StaticCall')
2020-03-03 11:52:39 +01:00
Dorian Villet 8425410119 Fix the implementation. 2020-03-03 10:23:43 +01:00
TomasVotruba 9c92126265 fix spacing of data provider 2020-03-03 10:18:54 +01:00
Dorian Villet 454e78ce8a AssertTrueFalseToSpecificMethodRector: add broken test ('Pick more specific node than PhpParser\Node\Expr\StaticCall'). 2020-03-03 09:59:49 +01:00
TomasVotruba b8ccd71b3a improve param array type for change type 2020-03-02 23:44:10 +01:00
TomasVotruba f7f2977748 fix count() code qauality 2020-03-02 17:38:00 +01:00
TomasVotruba a8fa941193 Fix PhpDocInfoPrinter slash removal 2020-03-02 17:25:15 +01:00
TomasVotruba 376e2e43ac skip open-source protected methods 2020-03-02 00:08:24 +01:00
TomasVotruba 54560e1143 add test case for open-source protected agr 2020-03-02 00:04:26 +01:00
TomasVotruba 40ab236fee skip empty method on open-source 2020-03-01 23:42:35 +01:00
TomasVotruba 0f8cdacd26 decouple FuncCallManipulator 2020-03-01 10:28:52 +01:00
TomasVotruba b611c4aeda decouple MagicMethodDetector 2020-03-01 10:06:59 +01:00
TomasVotruba 8b5c4f5726 [DeadCode] Fix shifted value 2020-03-01 09:53:08 +01:00
TomasVotruba 5aab2cec96 improve NodeTypeResolver complexity 2020-03-01 01:22:10 +01:00
TomasVotruba 94610569e7 improve ReturnTypeDeclarationRector complexity 2020-03-01 00:46:14 +01:00
TomasVotruba 37eaf518db improve RemoveUnusedAliasRector complexity 2020-03-01 00:38:46 +01:00
TomasVotruba fe86fc4365 make use of isFuncCallName() method 2020-03-01 00:06:45 +01:00
TomasVotruba 83eca131e9 improve ForToForeachRector 2020-03-01 00:03:32 +01:00
TomasVotruba 9ff0b6a07a decopule isNodePartOfAssign() method 2020-02-29 23:55:00 +01:00
TomasVotruba 903483bf96 decouple ClassInsertManipulator 2020-02-29 22:10:06 +01:00
TomasVotruba 7eb2ac0e36 decopule class dependency manipulator methods 2020-02-29 21:22:00 +01:00
TomasVotruba d5b5e94508 add format preserving to union type node 2020-02-29 21:02:31 +01:00
TomasVotruba 7bc1703859 improve class cognitive complexity 2020-02-29 19:14:40 +01:00
TomasVotruba 67104fdca3 remove unused methods from ClassManipulator 2020-02-29 17:00:19 +01:00
TomasVotruba 53ac8fcc41 make RemoveUnusedClassConstant skip open-source public constants 2020-02-29 15:28:08 +01:00
TomasVotruba 6420f9322e fixup! Merge pull request #2966 from rectorphp/public-abstract 2020-02-29 15:23:37 +01:00
TomasVotruba d1b63e2e55 fix typoe open-source parameter 2020-02-29 15:06:05 +01:00
TomasVotruba e6489efac1 fix complexity 2020-02-29 12:37:22 +01:00
TomasVotruba 935b08e4ad fix get class on trait 2020-02-29 02:10:30 +01:00
Tomas Votruba d3bf2c0364
Merge pull request #2950 from gnutix/GetClassOnNullRector/add_broken_test_in_trait
[GetClassOnNullRector] Add failing test in trait.
2020-02-29 02:06:11 +01:00
TomasVotruba cabe6d5e62 fix scoping of OxidEsales 2020-02-29 01:37:15 +01:00
TomasVotruba 128910963a various fixes 2020-02-29 01:29:42 +01:00
Tomas Votruba 8f3e90ba7f
Merge pull request #2956 from gnutix/AssertTrueFalseInternalTypeToSpecificMethodRector/add-broken-test-method-call
AssertTrueFalseInternalTypeToSpecificMethodRector: add broken test method call
2020-02-29 01:23:55 +01:00
Tomas Votruba 1452472fc5
Merge pull request #2951 from gnutix/AddSeeTestAnnotationRectorTest/add-broken-test-simple-comment
AddSeeTestAnnotationRectorTest: add broken test for simple comment.
2020-02-29 01:21:48 +01:00
Tomas Votruba 3a71aaf910
Merge pull request #2954 from gnutix/RemoveDefaultArgumentValueRector/add-broken-test-static-method-call
RemoveDefaultArgumentValueRector: add broken test on static method call.
2020-02-29 01:21:39 +01:00
TomasVotruba e0baf3330b fix naming of non-func call 2020-02-29 01:20:34 +01:00
Tomas Votruba 6d2c6a0395
Merge pull request #2959 from rectorphp/fix-dim-array
fix return dim array fetch
2020-02-29 01:13:05 +01:00
Tomas Votruba 51b379b024
Merge pull request #2953 from gnutix/AssertRegExpRectorTest/add-broken-test-static-method-call
AssertRegExpRectorTest: add broken test on static method call
2020-02-29 01:12:58 +01:00
TomasVotruba 4c35675cca fix return dim array fetch 2020-02-29 01:12:08 +01:00
Dorian Villet cbdc4a1c2f AssertTrueFalseInternalTypeToSpecificMethodRector: add broken test on method call. 2020-02-28 17:20:54 +01:00
Dorian Villet 72be4f4450 RemoveDefaultArgumentValueRector: add broken test on static method call. 2020-02-28 17:10:11 +01:00
Dorian Villet 1a26e05ecc AssertRegExpRectorTest: add broken test when calling static method. 2020-02-28 16:54:12 +01:00
Dorian Villet 5781f8bb27 ReturnTypeDeclarationRector: add broken test. 2020-02-28 16:39:50 +01:00
Dorian Villet 05792e6a82 AddSeeTestAnnotationRectorTest: add broken test for simple comment. 2020-02-28 16:24:03 +01:00
Dorian Villet 567f8dda6d Add failing test in trait. 2020-02-28 15:49:50 +01:00
TomasVotruba cf358bb55b decouple ClassMethodPropertyFetchManipulator 2020-02-28 00:22:34 +01:00
TomasVotruba 15d07f4537 decouple PropertyFetchAssignManipulator 2020-02-28 00:15:32 +01:00
TomasVotruba e29f8fafab [DeadCode] Add RemoveDuplicatedIfReturnRector 2020-02-28 00:08:53 +01:00
TomasVotruba 7fd5234a10 check for dead-code info 2020-02-26 18:29:25 +01:00
TomasVotruba 1a4bb38126 skip open source class in rmeove unused param in open-source 2020-02-26 00:54:29 +01:00
TomasVotruba 53a3b18264 skip true/false case in TernaryToBooleanOrFalseToBooleanAndRector 2020-02-25 22:06:23 +01:00
TomasVotruba 3e7e3bf7dc add project_type 2020-02-25 21:43:29 +01:00
TomasVotruba 147b51b4c9 Fix prophecy mocking arg 2020-02-25 20:59:38 +01:00
TomasVotruba 788abf5131 add has lifecycle callbacks 2020-02-25 20:46:55 +01:00
TomasVotruba 0427133ec7 [DeadCode] Skip abstract methods in RemoveUnusedParameterRector as possible 3rd party contract 2020-02-25 10:52:37 +01:00
TomasVotruba 5c3aaf2ddc skip used property 2020-02-23 23:35:24 +01:00
TomasVotruba d074d5169a Fix FinalizeClassesWithoutChildrenRector for embedable 2020-02-23 23:25:58 +01:00
TomasVotruba 25aca8b774 [MysqlToMysqli] Add MysqlQueryMysqlErrorWithLinkRector 2020-02-23 23:13:49 +01:00
TomasVotruba f7aefc68b8 [DeadCode] Add RemoveUnusedVariableAssignRector 2020-02-23 22:36:23 +01:00
TomasVotruba c2b89700a3 [DeadCode] Add RemoveUnusedClassConstantRector 2020-02-23 22:07:19 +01:00
TomasVotruba c011720d4f add param name to docs 2020-02-23 21:58:25 +01:00
TomasVotruba 671fa8a547 [Phalcon] Add DecoupleSaveMethodCallWithArgumentToAssignRector 2020-02-23 20:16:45 +01:00
TomasVotruba 09d8c406a7 improve complexity 2020-02-23 20:02:02 +01:00
TomasVotruba 77d94c41a9 improve EregToPcreTransformer complexity 2020-02-23 18:57:05 +01:00
TomasVotruba 8347a4c784 [JMS] Add RemoveJmsInjectParamsAnnotationRector and RemoveJmsServiceAnnotationRector 2020-02-23 18:44:19 +01:00
TomasVotruba 6ba1d212e0 require at least 2 iffs for nested foreach 2020-02-23 17:05:59 +01:00
TomasVotruba cef900323f add add ShortNameAwareTagInterface 2020-02-23 16:14:23 +01:00
TomasVotruba eeb43d2b01 rector ci: enable solid + fix class const privatization for using parent 2020-02-23 16:03:39 +01:00
TomasVotruba 735be73800 [SOLID] Add ChangeNestedForeachIfsToEarlyContinueRector 2020-02-22 16:04:15 +01:00
TomasVotruba 93633a4c04 [CodeQuality] Add InlineIfToExplicitIfRector 2020-02-22 13:07:36 +01:00
TomasVotruba 4d9a689431 fix name equal 2020-02-22 11:49:51 +01:00
Aerendir aa655dbee3 Support throw from the method of an instantiated class. 2020-02-21 23:54:23 +01:00
TomasVotruba bc24bb12ff prevent getName() on StaticCall or MethodCall 2020-02-21 16:41:33 +01:00
TomasVotruba d0afc945e0 add links to each rule and test fixture in docs 2020-02-21 15:24:17 +01:00
TomasVotruba 5318f7c8d1 Fix incorrect regexes to preserve doc tags spacing 2020-02-21 14:49:50 +01:00
TomasVotruba 1e83e78a5e fix duplicate switch without break 2020-02-21 13:37:27 +01:00
TomasVotruba 0e61d7e96f [CodingStyle] Add CamelCaseFunctionNamingToUnderscoreRector 2020-02-21 02:50:54 +01:00
TomasVotruba 99eeeabee2 fix nested array dim fetch resolving type 2020-02-21 01:52:45 +01:00
TomasVotruba 40cd751756 keep array function static 2020-02-21 00:40:35 +01:00
Tomas Votruba ec50ab5672
Merge pull request #2890 from Aerendir/AnnotateThrowables-support-static-methods
#2861: Support throw of static methods
2020-02-20 19:49:39 +01:00
Aerendir 3e3445a255 Closes #2889. Support static methods calls. 2020-02-20 17:16:30 +01:00
TomasVotruba 01bd2e3d86 skip test fixtures 2020-02-19 14:53:21 +01:00
TomasVotruba 9da97ed1f6 update alias 2020-02-19 14:36:10 +01:00
TomasVotruba 7f63457a18 Fix already constant 2020-02-19 14:35:30 +01:00
TomasVotruba c25db0b56d apply 2020-02-19 00:14:44 +01:00
TomasVotruba 1ad8f08ccd [SOLID] Add ChangeReadOnlyVariableWithDefaultValueToConstantRector 2020-02-18 23:59:07 +01:00
Tomas Votruba 36ffd47763
Merge pull request #2876 from Aerendir/AnnotateThrowables-improve-tests-organization
`AnnotateThrowablesRector`: Improve organization of tests.
2020-02-18 18:59:06 +01:00
Tomas Votruba b65a200400
Merge pull request #2883 from alfredbez/oxid-replace-deprecated-classes
[OXID] replace backwards-compatability classes in oxNew
2020-02-18 18:06:15 +01:00
alfredbez 2cd3761661 added rector to replace oxid backwards-compatability classes 2020-02-18 12:10:03 +01:00
Felix Sokoliuk bd5e0adeac skip node when nested ternary is not a BinaryOp 2020-02-18 06:48:28 +01:00
Felix Sokoliuk cd263606c9 add test case for non binary op nested ternary 2020-02-18 06:45:43 +01:00
Aerendir 082a3061bf Fix mispelled `Docblock`. 2020-02-17 17:00:37 +01:00
Aerendir 15f97ae2f3 `AnnotateThrowablesRector`: Improve organization of tests. 2020-02-17 16:52:59 +01:00
TomasVotruba 5a28cd22d5 Skip unpackaged args in ArraySpreadInsteadOfArrayMergeRector 2020-02-17 15:17:39 +01:00
TomasVotruba e9897408b6 make test pass 2020-02-17 01:54:02 +01:00
TomasVotruba 868a56ad5a fix test location 2020-02-17 01:52:05 +01:00
TomasVotruba 5ebf2414c4 fix remove alwasy else for anonymous function jump 2020-02-17 01:24:19 +01:00
Tomas Votruba 655478265c
Merge pull request #2862 from escopecz/remove-always-elase-anonymous-function
Adding failing test for RemoveAlwaysElseRector
2020-02-17 00:55:40 +01:00
TomasVotruba dfd75bea94 improve ci 2020-02-17 00:45:00 +01:00
TomasVotruba 1498108d95 fix single line comment 2020-02-17 00:03:28 +01:00
John Linhart 54302369f1 Moving test into a separate file 2020-02-16 19:47:26 +01:00
TomasVotruba 4986d0ab7d respect parent definition in AddArrayReturnDocTypeRector 2020-02-16 19:13:41 +01:00
TomasVotruba 6d0e77fe1a skip traits in CountOnNullRector 2020-02-16 19:07:37 +01:00
TomasVotruba 895f09b150 fix paths 2020-02-16 18:42:57 +01:00
Tomas Votruba 58df5c5f31
Merge pull request #2859 from rectorphp/const-property
Apply properties to constants rule from SOLID
2020-02-16 17:51:17 +01:00
TomasVotruba d1b4779889 apply properties to constants rule from SOLID 2020-02-16 17:47:00 +01:00
John Linhart facca2a50b Adding failing test for RemoveAlwaysElseRector
With a foreach within an anonymous function
2020-02-15 15:26:41 +01:00
Aerendir f734a93272 Make `AnnotateThrowablesRector` continue on unhandled node types. 2020-02-15 00:56:09 +01:00
TomasVotruba 77c9d2924e remove duplicated tests 2020-02-14 23:53:37 +01:00
TomasVotruba 69c18b87ca fix fixtures 2020-02-14 23:50:42 +01:00
TomasVotruba 1c273c902c fix namespace 2020-02-14 23:48:53 +01:00
TomasVotruba 401d0aeaf6 fix namespaces, fixtures, add getThrowsTypes() 2020-02-14 23:35:40 +01:00
TomasVotruba 3bb87fcc1c correct location 2020-02-14 21:20:46 +01:00
TomasVotruba 00a3fb3a17 [SOLID] Add ChangeReadOnlyPropertyWithDefaultValueToConstantRector 2020-02-14 17:08:51 +01:00
TomasVotruba 1881f534de fixup! [DeadCode] Add RemoveDeadTryCatchRector 2020-02-14 15:48:45 +01:00
TomasVotruba af90cba019 [DeadCode] Add RemoveDeadTryCatchRector 2020-02-14 15:48:45 +01:00
TomasVotruba bf722ad9b5 move nette to rules 2020-02-14 10:51:33 +01:00
TomasVotruba 4e37157a88 fix non-Rector locations 2020-02-13 23:44:04 +01:00
TomasVotruba 86bcb6eb7b fix cs 2020-02-13 22:48:16 +01:00
TomasVotruba e564834329 docs link to the top to find quickly 2020-02-13 17:16:13 +01:00
TomasVotruba 42c5141d70 [Renaming] Add RenameFuncCallToStaticCallRector 2020-02-13 17:12:38 +01:00
TomasVotruba 09cf6f8a4a move core architecture to own set 2020-02-13 14:44:36 +01:00
TomasVotruba 13aff11638 fix statis int/float in ereg transformer 2020-02-13 11:10:09 +01:00
TomasVotruba 11f401daf9 fix ChangeQuerySetParametersMethodParameterFromArrayToArrayCollection location 2020-02-13 11:09:07 +01:00
TomasVotruba bc5eefdb76 improve AddSeeTestAnnotationRector 2020-02-11 14:40:59 +01:00
TomasVotruba 4aac338d20 improve ParamTypeDeclarationRector complexity 2020-02-11 14:11:47 +01:00
TomasVotruba 3e5dd77bb6 move Rector-rule based packages from /packages to /rules 2020-02-11 13:41:37 +01:00