Return non-zero exit code on Valgrind errors (#2527)

Previously this ignored use-after-frees and other errors.
This commit is contained in:
Andrew Gaul 2024-09-28 11:37:25 +09:00 committed by GitHub
parent 5691071ac6
commit 37cf324c52
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -279,7 +279,7 @@ jobs:
echo "CXXFLAGS=${COMMON_CXXFLAGS} -O1 -fsanitize=undefined,implicit-conversion,local-bounds,unsigned-integer-overflow" echo "CXXFLAGS=${COMMON_CXXFLAGS} -O1 -fsanitize=undefined,implicit-conversion,local-bounds,unsigned-integer-overflow"
elif [ "${{ matrix.checktype }}" = "valgrind" ]; then elif [ "${{ matrix.checktype }}" = "valgrind" ]; then
echo "CXXFLAGS=${COMMON_CXXFLAGS} -O1" echo "CXXFLAGS=${COMMON_CXXFLAGS} -O1"
echo 'VALGRIND=--leak-check=full' echo 'VALGRIND="--leak-check=full --error-exitcode=1"'
echo 'RETRIES=100' echo 'RETRIES=100'
echo 'S3_URL=http://127.0.0.1:8081' echo 'S3_URL=http://127.0.0.1:8081'
fi fi