Robb Kistler
718db57ade
Code review changes
...
Missed some cleanup from the code review
2015-09-13 00:31:56 -07:00
Robb Kistler
6b21d9d424
Code review changes
2015-09-11 16:09:00 -07:00
Robb Kistler
dac9844765
Fix remove_nonempty_directory test bug
...
Wrap the attempt to rmdir in an if statement, otherwise the entire
test process exists (errexit is set). This test expects the rmdir
to fail.
2015-09-11 15:24:17 -07:00
Robb Kistler
849e66f6a1
Change test_append_file to avoid object read-after-after-overwrite
...
Open the test file once outside of the tests for loop. This helps avoid
object consistency problems when running against S3 providers without
strong consistency (like Amazon). See Issue #263 .
2015-09-11 15:24:17 -07:00
Takeshi Nakatani
9ea8da839c
Merge pull request #258 from juandiegogonzales/patch-1
...
Update README.md to better explain mount upon boot
2015-09-09 00:15:55 +09:00
Takeshi Nakatani
39cec488d2
Merge pull request #257 from jesselsteele/patch-1
...
Update README.md: Bugfix password file permissions errors
2015-09-09 00:15:21 +09:00
Takeshi Nakatani
96436df18d
Merge pull request #256 from andrewgaul/readme
...
Add no atomic rename to limitations
2015-09-09 00:14:47 +09:00
Juan Diego Gonzales
3aabb5616c
Update README.md to better explain mount upon boot
...
As a novice Linux user, I didn't know I had to add a line into /etc/fstab for automatic mount upon boot. It took me some minutes to research and notice the right process (at first, I even entered s3fs#mybucket into the command line).
This change will (hopefully) save time to unseasoned users.
2015-09-07 10:05:02 -05:00
Jesse Steele
8e55f45818
Update README.md
...
received "should not have others permissions" when mounting
did chmod 640 and received "should not have group permissions"
used chmod 600 after creating the password file and had no problems
2015-09-05 15:08:07 +08:00
Andrew Gaul
ec4135c9ed
Add no atomic rename to limitations
2015-09-01 13:10:21 -07:00
Takeshi Nakatani
cfdfecb4d1
Merge pull request #253 from s3fs-fuse/fixmkdirp
...
Added chacking cache dir perms at starting.
2015-08-23 13:18:50 +09:00
Takeshi Nakatani
97b8b34aab
Added chacking cache dir perms at starting(2).
2015-08-23 04:14:57 +00:00
Takeshi Nakatani
ce66430fac
Added chacking cache dir perms at starting.
2015-08-23 03:57:34 +00:00
Takeshi Nakatani
1fc56e6665
Merge pull request #252 from Ziggeo/fix-create-cache-directories
...
This fixes an issue with caching when the creation of a subdirectory …
2015-08-23 10:48:08 +09:00
Oliver Friedmann
d7d96907cf
This fixes an issue with caching when the creation of a subdirectory within the cache is aborted because a common cached parent directory already exists.
2015-08-21 19:30:04 -04:00
Takeshi Nakatani
eb97054f49
Merge pull request #251 from flandr/skip-xattr-tests
...
Skip xattr tests if utilities are missing
2015-08-22 02:11:02 +09:00
Nate Rosenblum
7280ca6a69
Skip xattr tests if utilities are missing
2015-08-21 10:05:14 -07:00
Takeshi Nakatani
30b2a833a8
Merge pull request #250 from s3fs-fuse/issue#228
...
s3fs can print version with short commit hash - #228
2015-08-22 01:35:07 +09:00
Takeshi Nakatani
8f8e52b91a
s3fs can print version with short commit hash(2) - #228
2015-08-21 16:30:24 +00:00
Takeshi Nakatani
751c868769
s3fs can print version with short commit hash - #228
2015-08-21 16:19:31 +00:00
Takeshi Nakatani
c3a47c26ec
Merge pull request #249 from andrewgaul/wget-quiet
...
Silence wget
2015-08-22 00:51:30 +09:00
Takeshi Nakatani
632578f328
Merge pull request #247 from andrewgaul/base64
...
Base64 cleanup
2015-08-22 00:45:26 +09:00
Takeshi Nakatani
5a4240b18d
Merge pull request #246 from andrewgaul/coverity
...
Unlock during early return in TruncateCache
2015-08-22 00:43:34 +09:00
Andrew Gaul
236aeb9dfd
Silence wget
2015-08-20 11:38:27 -07:00
Andrew Gaul
bcfadbe1a8
Unlock during early return in TruncateCache
...
Found via Coverity. Regression from
dfa63345ed
2015-08-19 13:54:14 -07:00
Andrew Gaul
b5c027f15d
Add unit tests for base64 encoding and decoding
2015-08-19 13:49:10 -07:00
Andrew Gaul
15db80b459
NUL terminate decoded base64 string
...
For consistency with encoded strings.
2015-08-19 13:48:07 -07:00
Andrew Gaul
76c0ef86e4
Move base64 and hex functions to string_util
2015-08-19 13:47:26 -07:00
Takeshi Nakatani
a3e820e733
Merge pull request #245 from andrewgaul/map-duplicate-lookups
...
Elide duplicate lookups of std::map via iterators
2015-08-20 01:22:06 +09:00
Takeshi Nakatani
a3568a1419
Merge pull request #243 from andrewgaul/cppcheck-travis
...
Run cppcheck during Travis builds
2015-08-20 01:20:15 +09:00
Takeshi Nakatani
4ad57bdea5
Merge pull request #240 from andrewgaul/md5
...
Enable Content-MD5 during multipart upload part
2015-08-20 01:19:01 +09:00
Takeshi Nakatani
085733d7c9
Merge pull request #239 from andrewgaul/google-code
...
Update stale Google Code reference in --help
2015-08-20 01:08:00 +09:00
Takeshi Nakatani
fcb58aec3c
Merge pull request #238 from andrewgaul/cppcheck
...
Enable all cppcheck rules
2015-08-20 01:06:50 +09:00
Takeshi Nakatani
402c609316
Merge pull request #237 from andrewgaul/test-refactor
...
Refactor tests into individual functions
2015-08-20 01:03:03 +09:00
Takeshi Nakatani
026a9f2bdc
Merge pull request #235 from andrewgaul/complete-mpu-leak
...
Plug leak during complete multipart upload
2015-08-20 00:40:00 +09:00
Takeshi Nakatani
1918d6fa2d
Merge pull request #234 from andrewgaul/readme
...
Update README
2015-08-20 00:37:49 +09:00
Takeshi Nakatani
fd04b9a437
Merge pull request #233 from andrewgaul/remove-inttostr
...
Remove IntToStr
2015-08-20 00:34:21 +09:00
Takeshi Nakatani
ea99603b58
Merge pull request #232 from andrewgaul/stat-cache-locking
...
Always hold stat_cache_lock when using stat_cache
2015-08-20 00:28:57 +09:00
Takeshi Nakatani
036612dbb0
Merge pull request #231 from andrewgaul/autolock
...
Rewrite AutoLock
2015-08-20 00:24:05 +09:00
Andrew Gaul
67d1576dfb
Elide duplicate lookups of std::map via iterators
...
Also remove use of C++11 std::map::at.
2015-08-18 14:00:42 -07:00
Andrew Gaul
2850fe731b
Run cppcheck during Travis builds
2015-08-18 03:01:14 -07:00
Andrew Gaul
a157ac59ca
Enable Content-MD5 during multipart upload part
...
This allows retries of multi-part uploads instead of discovering a
fatal error during complete multipart upload. Also enable Content-MD5
for integration tests and refactor hexadecimal code.
2015-08-18 02:54:00 -07:00
Andrew Gaul
20f425fe15
Update README
...
This better explains many of the features and limitations and removes
stale information.
2015-08-17 07:48:11 -07:00
Andrew Gaul
32520fd1fb
Update stale Google Code reference in --help
2015-08-16 23:30:41 -07:00
Andrew Gaul
c0b21d8808
Enable all cppcheck rules
2015-08-16 17:13:24 -07:00
Andrew Gaul
17d223b542
Refactor tests into individual functions
2015-08-16 15:50:17 -07:00
Andrew Gaul
9c5bf0bb66
Plug leak during complete multipart upload
2015-08-15 22:38:24 -07:00
Andrew Gaul
dfa63345ed
Always hold stat_cache_lock when using stat_cache
...
We could further improve this code by holding stat_cache_lock before
calls to DelStat instead of unlocking then relocking it.
2015-08-14 20:14:12 -07:00
Andrew Gaul
3f59b8da01
Rewrite AutoLock
...
Previously AutoLock::Lock allowed subsequent callers to proceed
without the lock. Further is_locked was not always protected by
auto_mutex. Finally AutoLock eagerly released auto_mutex when
recursively unlocking. s3fs does not need recursive locks so we
rewrite and simplify AutoLock. Partially surfaced by Coverity.
2015-08-14 20:00:56 -07:00
Andrew Gaul
0ea88a73c7
Remove IntToStr
...
str duplicates this functionality. Also add unit test.
2015-08-12 08:25:09 -07:00
