build: Syso stuff needs to happen on build (ref #4909)

This commit is contained in:
Jakob Borg 2018-05-02 08:30:23 +02:00
parent 58bc722a1f
commit 0f1d0380dc

View File

@ -429,8 +429,9 @@ func install(target target, tags []string) {
os.Setenv("GOOS", goos) os.Setenv("GOOS", goos)
os.Setenv("GOARCH", goarch) os.Setenv("GOARCH", goarch)
// On Windows generate a special file which the Go compiler will automatically use when generating Windows binaries // On Windows generate a special file which the Go compiler will
// to set things like the file icon, version, etc. // automatically use when generating Windows binaries to set things like
// the file icon, version, etc.
if goos == "windows" { if goos == "windows" {
sysoPath, err := shouldBuildSyso(cwd) sysoPath, err := shouldBuildSyso(cwd)
if err != nil { if err != nil {
@ -454,6 +455,22 @@ func build(target target, tags []string) {
os.Setenv("GOOS", goos) os.Setenv("GOOS", goos)
os.Setenv("GOARCH", goarch) os.Setenv("GOARCH", goarch)
// On Windows generate a special file which the Go compiler will
// automatically use when generating Windows binaries to set things like
// the file icon, version, etc.
if goos == "windows" {
cwd, err := os.Getwd()
if err != nil {
log.Fatal(err)
}
sysoPath, err := shouldBuildSyso(cwd)
if err != nil {
log.Printf("Warning: Windows binaries will not have file information encoded: %v", err)
}
defer shouldCleanupSyso(sysoPath)
}
runPrint("go", args...) runPrint("go", args...)
} }