Lode Hoste
82e033942e
RLimit comment typo
...
Thanks @plouj
2016-01-17 12:54:44 +01:00
Jakob Borg
2919b76947
The "OK" log level is silly and should not exist
2016-01-16 23:04:41 +01:00
Jakob Borg
acaf134dfe
Don't crash on folder remove while pulling ( fixes #2705 )
2016-01-16 21:42:32 +01:00
Audrius Butkevicius
c4c6df179b
Handle race within the job queue ( fixes #1263 )
2016-01-16 17:20:21 +00:00
kluppy
7c42b5cb17
Update 'Edit' menu to 'Action' menu ( fixes #2662 )
2016-01-13 20:09:32 +10:00
Audrius Butkevicius
5fa8b42fac
Merge pull request #2690 from calmh/fix2665
...
Always run relaying when enabled (fixes #2665 )
2016-01-12 13:48:22 +00:00
Jakob Borg
8b3d75b339
Undo the hash algorithm additions; retain flag checks
2016-01-12 14:35:00 +01:00
Jakob Borg
357089a438
Mend protocol tests, for sure
2016-01-12 14:35:00 +01:00
Jakob Borg
f741066466
Always run relaying when enabled ( fixes #2665 )
2016-01-12 14:15:47 +01:00
Jakob Borg
9595687bce
Improve protocol tests, close handling
2016-01-12 09:30:02 +01:00
Jakob Borg
acdddc0b79
Don't leak sendIndexes on disconnect ( fixes #2589 )
...
Adds a Closed() method on protocol.Connection and clears up
wireformatConnection a little too.
2016-01-11 17:57:25 +01:00
Audrius Butkevicius
ff4bab4c07
Silence the linter
2016-01-10 18:00:52 +00:00
alessandro.g89
5c36029274
Add dark theme by alessandro.g89
...
Source: https://userstyles.org/styles/122502/syncthing-dark
2016-01-10 18:00:44 +00:00
Audrius Butkevicius
cd54186113
Add support for themes ( fixes #1925 )
2016-01-10 17:57:27 +00:00
Audrius Butkevicius
6c0a973ac3
Merge pull request #2480 from calmh/shortdblabels
...
Change database folder label format
2016-01-10 01:33:56 +00:00
Jakob Borg
837fde70ae
Add XUnit compatible test output
2016-01-10 00:50:43 +01:00
Jakob Borg
370b0fc5da
More fine grained locking in discovery cache ( fixes #2667 )
...
We only need to protect the integrity of the "finders" and "caches"
slices, and for that we only need an RLock except while actually
appending to them. The actual finders and caches are concurrency safe on
their own.
2016-01-09 00:56:03 +01:00
Jakob Borg
576c365753
Don't resolve destination address until we need to ( fixes #2671 )
2016-01-07 12:32:10 +01:00
Jakob Borg
a4385100c4
HTML attribute typo
2016-01-05 11:19:27 +01:00
Jakob Borg
1df924f4f8
Add relaying to main settings dialog ( fixes #2433 )
2016-01-05 10:08:56 +01:00
Jakob Borg
096b2d73cd
Don't conflict copy conflict copies ( fixes #2605 )
2016-01-03 21:16:31 +01:00
Jakob Borg
ac190b2e39
Change DB label format (index folders, devices)
2016-01-03 19:32:40 +01:00
Jakob Borg
4673862981
Update docs & translations
2016-01-03 09:56:33 +01:00
Jakob Borg
212d7257e9
Pretty print the new architectures
2016-01-01 21:19:15 +01:00
Jakob Borg
0db80710aa
Detect nonstandard hash algo and stop folder (ref #2314 )
2016-01-01 20:14:31 +01:00
Jakob Borg
7c47eff112
Update lang-en.json for translations
2016-01-01 20:13:44 +01:00
Jakob Borg
d81849ab3b
Merge pull request #2631 from AudriusButkevicius/igwarn
...
Don't warn about failed ignores if folder unhealthy (fixes #2630 )
2016-01-01 16:48:31 +01:00
Audrius Butkevicius
dbb3f80995
Merge pull request #2193 from AudriusButkevicius/lans
...
Remove windows specialisation from osutil.GetLans (fixes #2192 )
2016-01-01 15:01:23 +00:00
Audrius Butkevicius
80b9a3e00b
Don't warn about failed ignores if folder unhealthy ( fixes #2630 )
2016-01-01 12:59:13 +00:00
Kevin Allen
ffc4a60bc6
Show device ID QR code from edit dialog ( fixes #1494 )
2016-01-01 11:24:09 +01:00
Jakob Borg
18e70f4e79
Ensure loaded config is free of duplicate devices ( fixes #2627 )
2015-12-31 09:17:17 +01:00
Jakob Borg
62a81cfdd1
Update lang-en.json and assets
2015-12-30 08:54:09 +01:00
Jakob Borg
7b3fa8da60
Update translations & docs
2015-12-27 13:26:14 +01:00
Anderson Mesquita
219ece22fc
Remove fixed footer at first media break ( fixes #2454 )
...
After the first media break (under 1200px), the footer is too long to
fit in a single line, taking up too much space in small screen devices.
This makes it so that it will stop being fixed at the bottom, freeing up
valuable screen real estate.
2015-12-23 22:19:41 -05:00
Jakob Borg
4874301615
Merge pull request #2618 from AudriusButkevicius/svc
...
Svc -> Service
2015-12-23 21:33:42 +01:00
Audrius Butkevicius
1827dda0c6
Svc -> Service
2015-12-23 15:31:12 +00:00
Jakob Borg
d088b01f75
Rebuild assets
2015-12-23 16:09:42 +01:00
Jakob Borg
00c5062eab
Merge branch 'pr/2613'
...
* pr/2613:
Add an icon for Safari's pinned tabs
2015-12-23 16:09:31 +01:00
Anderson Mesquita
6d94a3be05
Refactor rwfolder tests
...
This creates a few utility functions to avoid repetition and removes
some redundant checks.
2015-12-22 23:43:07 -05:00
Jaakko Hannikainen
c300015ac2
Add an icon for Safari's pinned tabs
...
Safari has its own standard for handling icons for pinned tabs,
which requires a black-and-white .svg and a special tag.
Without using this, pinning a tab to localhost will show just
a blank square, instead of a pre-generated letter.
2015-12-22 12:29:59 +02:00
Jakob Borg
c7aec839ae
Merge pull request #2614 from andersonvom/issue-2598
...
WIP: Consider tempfile when checking for free space (fixes #2598 )
2015-12-22 09:42:34 +01:00
Anderson Mesquita
3f94e70488
WIP: Consider tempfile when checking for free space ( fixes #2598 )
...
Checks the existing blocks that can be reused when downloading a file so
that it only requires the space corresponding to the missing blocks.
This will prevent syncthing from claiming the folder doesn't have enough
space when resuming download of large files after they have been
partially downloaded.
2015-12-21 13:36:08 -05:00
Audrius Butkevicius
c9e67fb460
Log when we fail to connect to relay
2015-12-20 22:14:13 +00:00
Audrius Butkevicius
cec87be4e3
Remove windows specialisation from osutil.GetLans ( fixes #2192 )
2015-12-20 18:10:02 +00:00
Jakob Borg
eb1a234a77
Translation & docs update
2015-12-20 10:05:17 +01:00
Jakob Borg
394c2b67d6
Merge pull request #2595 from AudriusButkevicius/leaks
...
Always exit via error select, making sure reader routine is exits (fi…
2015-12-20 10:03:34 +01:00
Jakob Borg
e5cf99e31c
Move event timestamp to header for share folder prompt
2015-12-20 09:52:59 +01:00
Anderson Mesquita
8120535a35
Edit device after accepting new connection ( fixes #1929 )
...
This will open the "edit device" dialogue after accepting a new device
connection. This will allow the user to specify the name of the device
or leave it blank in case they want to accept whatever the device
advertises once it connects.
2015-12-19 09:48:27 -05:00
Audrius Butkevicius
e7b71f8743
Merge pull request #2601 from calmh/fix2600
...
Don't verify free space for files when folder MinDiskFreePct==0 (fixes #2600 )
2015-12-19 13:02:57 +00:00
Jakob Borg
03935b2d64
Don't verify free space for files when folder MinDiskFreePct==0 ( fixes #2600 )
2015-12-19 13:59:08 +01:00
Jakob Borg
9c82a4ca60
Merge pull request #2593 from AudriusButkevicius/httpfoo
...
Only override TLS settings if scheme is specified
2015-12-19 08:47:46 +01:00
Anderson Mesquita
69b35b2ede
Fix alignment of settings fields
...
When upgrade info is not available and the "Automatic Upgrades" options
is hidden, then "Global Discovery Server" wraps around and gets
misaligned. This fixes all that.
2015-12-18 22:40:56 -05:00
AudriusButkevicius
e8016abd97
Always exit via error select, making sure reader routine is exits ( fixes #2547 )
2015-12-18 22:29:04 +00:00
AudriusButkevicius
33a87f54bb
Only override TLS settings if scheme is specified
2015-12-18 19:42:39 +00:00
Audrius Butkevicius
f208e6f0b6
Fix typos
2015-12-15 20:11:07 +00:00
Jakob Borg
7c8c131e1a
Merge pull request #2582 from Zillode/debug-2580
...
Additional output on insufficient error (ref #2580 )
2015-12-15 10:19:59 +01:00
Jakob Borg
81e71d7275
Merge pull request #2576 from AudriusButkevicius/reconn
...
More debug to reconnect loop
2015-12-15 10:18:47 +01:00
Jakob Borg
2280566bca
Better error messages for globbing errors
2015-12-15 10:04:13 +01:00
Lode Hoste
cc0b9e5088
Additional output on insufficient error (ref #2580 )
2015-12-15 08:45:33 +01:00
Audrius Butkevicius
403583cfbb
More debug to reconnect loop
2015-12-13 12:20:25 +00:00
Jakob Borg
29bff06cd6
Translation update
2015-12-13 10:39:09 +01:00
Jakob Borg
2b80057ac9
Minimal error handling refactor
2015-12-13 10:38:21 +01:00
William A. Kennington III
5bdf4c6143
upnp: Use a separate error for the error unmarshalling
...
Previously, when unmarshing the SOAP error code data we would overwrite
the original err, typically with null since the parsing of the error
code information succeeds. If we don't have a upnp 725 error, we would fall
back to returning null or no error. This broke our upnp error handling
logic for AddPortMappings as it would think it succeeds if it gets a 718
permission error.
2015-12-12 09:58:23 -08:00
Jakob Borg
3025caf932
Also remove IP per disco server
2015-12-08 10:10:34 +01:00
Jakob Borg
95cfc50fbd
Remove Android hacks ( fixes #2505 )
...
Also fixes what I think migh thave been a bug where we did not use the
proxy for usage reports. And removes the BuildEnv field that we don't
need any more.
2015-12-08 10:10:06 +01:00
Jakob Borg
1b6e4645b1
Update docs & translations
2015-12-06 13:09:22 +01:00
Antony Male
345d727936
staticClient.connect(): don't handshake twice ( fixes #2547 , #2548 )
...
The first handshake occurred before setting the Deadline, which could
cause an unintended hang.
2015-12-04 12:01:01 +00:00
Nate Morrison
86e8e5199e
Filenames added to audit log in the LocalIndexUpdated event ( fixes #2549 )
2015-12-04 08:42:00 +01:00
Jakob Borg
739979a116
Add nrm21
2015-12-04 08:38:45 +01:00
Jakob Borg
ab1962934d
Docs & translations update
2015-12-01 11:24:30 +01:00
Jakob Borg
cb0d739daf
New key for discovery-*-3
2015-12-01 11:20:16 +01:00
Jakob Borg
a937fcc477
Lol shadowing :(
2015-12-01 11:20:16 +01:00
Jakob Borg
9f2dc4554d
Accept Retry-After header on discovery lookup failures
2015-12-01 11:10:03 +01:00
Jakob Borg
3008dc76d3
Add buinsky
2015-11-30 18:30:36 +01:00
buinsky
05a31c2686
Fix deleting folders on WinXP ( fixes #2522 )
2015-11-30 19:09:36 +03:00
Antony Male
4bd0dd2123
Allow #urPreview to scroll in the browser ( fixes #2537 )
...
This is the same issue as #2014/#2062. Bootstrap doesn't like having two dialogs
open at once: it marks the body has having no dialogs open when the first dialog
is closed, regardless of whether the second dialog is still open.
This means that scrolling doesn't happen properly, and the user cannot
scroll to the dialog's 'close' button.
Work around this by making sure the first dialog (the settings page) is fully closed
before the second dialog (usage preview) is opened.
2015-11-30 13:27:07 +00:00
Jakob Borg
9b2a643626
Update docs and translations
2015-11-29 08:55:38 +01:00
Jakob Borg
1ebc9a9a88
Merge pull request #2525 from kluppy/master
...
Don't chmod in Atomic on android (fixes #2472 )
2015-11-28 22:57:00 +01:00
Jakob Borg
f0c8b7ce40
Add kluppy
2015-11-28 22:17:05 +01:00
Audrius Butkevicius
4474d200b0
Fix symlinks ( fixes #2524 )
2015-11-28 20:23:08 +00:00
kluppy
f062e35641
Don't chmod in Atomic on android (fixes #2472 )
2015-11-28 02:46:06 +10:00
Jakob Borg
321ef9816c
Merge pull request #2521 from AudriusButkevicius/dialtimeout
...
Add dialer.DialTimeout, use that when connecting to relays
2015-11-27 10:01:21 +01:00
Jakob Borg
6d11006b54
Generate ECDSA keys instead of RSA
...
This replaces the current 3072 bit RSA certificates with 384 bit ECDSA
certificates. The advantage is these certificates are smaller and
essentially instantaneous to generate. According to RFC4492 (ECC Cipher
Suites for TLS), Table 1: Comparable Key Sizes, ECC has comparable
strength to 3072 bit RSA at 283 bits - so we exceed that.
There is no compatibility issue with existing Syncthing code - this is
verified by the integration test ("h2" instance has the new
certificate).
There are browsers out there that don't understand ECC certificates yet,
although I think they're dying out. In the meantime, I've retained the
RSA code for the HTTPS certificate, but pulled it down to 2048 bits. I
don't think a higher security level there is motivated, is this matches
current industry standard for HTTPS certificates.
2015-11-27 09:15:12 +01:00
Audrius Butkevicius
ed792b97c0
Take timeout into account when dialing
2015-11-26 23:41:11 +00:00
Audrius Butkevicius
a4b8c2298a
Add dialer.DialTimeout support
2015-11-26 23:31:37 +00:00
Jakob Borg
e5b33ce9f6
Regenerate XDR for empty struct types
2015-11-24 20:54:49 +01:00
Michael Ploujnikov
9edf8233f7
Improve upgrade error messages
2015-11-24 08:29:42 -05:00
Michael Ploujnikov
bd4a14519c
FetchLatestReleases: just log the error here
...
Since the return value is being ignored by the caller.
2015-11-24 08:29:42 -05:00
Michael Ploujnikov
f12bf8c09a
Rename LatestGithubReleases -> FetchLatestReleases
2015-11-24 08:29:42 -05:00
Jakob Borg
fa4b4dece1
Compact database on startup (ref #2400 )
2015-11-24 13:17:30 +01:00
Jakob Borg
02f044a2a1
Add plouj
2015-11-24 08:35:25 +01:00
Audrius Butkevicius
431d51f5c4
Add timeouts to relay methods
2015-11-23 21:14:46 +00:00
Jakob Borg
5136675fae
Docs & translation update
2015-11-22 16:05:20 +01:00
Audrius Butkevicius
6ff02761a9
Merge pull request #2500 from calmh/sparse
...
Handle sparse files (fixes #245 )
2015-11-21 17:21:11 +00:00
Jakob Borg
d46f267663
Handle sparse files ( fixes #245 )
2015-11-21 17:58:09 +01:00
Audrius Butkevicius
eeb5d99942
Sort relays in 50ms latency increments, shuffle relays within the same increment
2015-11-21 13:23:49 +00:00
Audrius Butkevicius
9047d56aa0
Add RelayFull message
2015-11-20 23:42:49 +00:00
Jakob Borg
bed6155c79
Refactor: multiple-if to switch
2015-11-20 11:24:50 +01:00
Jakob Borg
f2459e61dd
Refactor: break out walkRegular method
2015-11-20 10:32:16 +01:00
Jakob Borg
69dcdafb3d
Refactor: break out walkDir method
2015-11-20 09:54:12 +01:00
Jakob Borg
6dbb072d11
Refactor: break out walkSymlink method
2015-11-20 09:50:46 +01:00
Jakob Borg
dc96849718
Refactor: break out normalizePath method
2015-11-20 09:41:44 +01:00
Jakob Borg
d7a3cc505c
Refactor: rename p->absPath, rn->relPath
2015-11-20 09:38:45 +01:00
Jakob Borg
ba9448bdd7
Add remaining scanning time ( fixes #2484 )
2015-11-18 12:09:10 +01:00
Jakob Borg
aa853ac833
Fix tests
2015-11-17 21:23:17 +01:00
Jakob Borg
a8a2192cf9
Show scan rate in web GUI
2015-11-17 21:23:17 +01:00
Jakob Borg
37f866b47f
Use pause/resume device to ensure TestConflictsDefault can run
2015-11-17 13:32:57 +01:00
Jakob Borg
9cf653d673
Rename Model.clusterConfig to Model.generateClusterConfig
2015-11-17 12:10:08 +01:00
Jakob Borg
0167b4b4a3
Don't cause rare spurious event timeout
...
Correctly resetting timers is surprisingly tricky.
2015-11-17 12:05:22 +01:00
Jakob Borg
b1a86fbc98
Warn the user if they're running with an insecure looking setup ( fixes #2139 )
2015-11-16 21:58:08 +01:00
Jakob Borg
ad8c266f76
Update docs & translation
2015-11-15 18:15:10 +01:00
Audrius Butkevicius
62efbd17de
Revert "Don't show "Rescan" button for stopped folders"
2015-11-14 14:01:22 -05:00
Jakob Borg
40c70a9a2a
Don't show "Rescan" button for stopped folders
2015-11-14 12:14:09 +01:00
Audrius Butkevicius
8fb7f40a6a
Merge pull request #2468 from calmh/removefolder
...
Remove folder without restart (fixes #2262 )
2015-11-13 09:51:58 -05:00
Jakob Borg
2f12d41d9d
Don't dirty blockmap key between lookups ( fixes #2455 )
2015-11-13 15:44:30 +01:00
Jakob Borg
9fbdb6b305
Cancel a running scan
2015-11-13 15:30:21 +01:00
Jakob Borg
73285cadb6
Remove folder without restart ( fixes #2262 )
2015-11-13 13:32:52 +01:00
AudriusButkevicius
f7edd36931
Use virtualMtime when deciding if a file is up to date
2015-11-12 03:40:06 +00:00
Mike Boone
342036408e
Fix typos.
2015-11-11 21:20:34 -05:00
Jakob Borg
f4904fce17
Merge pull request #2449 from Stefan-Code/upgrade-system
...
made upgrade-system smarter (fixes #2446 )
2015-11-10 21:15:02 +01:00
Stefan Kuntz
2abb2de753
Made upgrade-system smarter ( fixes #2446 )
2015-11-10 17:41:50 +01:00
Jakob Borg
ef0a0db07e
More local discovery URL debugging (ref #2444 )
2015-11-10 10:16:55 +01:00
Jakob Borg
88ae353aef
Merge pull request #2443 from tylerbrazier/master
...
Audit logins with new Login event (fixes #2377 )
2015-11-10 08:19:03 +01:00
Tyler Brazier
97b9690711
Audit logins with new LoginAttempt event ( fixes #2377 )
2015-11-10 00:49:51 -05:00
Audrius Butkevicius
48ce356d5c
Merge pull request #2448 from calmh/connhandling
...
Refactor out methods resolveAddresses, connectDirect, connectViaRelay
2015-11-09 22:01:06 -05:00
Zillode
593632045d
Correct commentary for ConnectionStats
...
Related to https://github.com/syncthing/syncthing-android/issues/473 and 944d9c84a0
ConnectionStats returns connection information for all devices, even when disconnected.
2015-11-09 23:58:06 +01:00
Jakob Borg
e3c55ef307
Fix address list in DeviceDiscovered, add debug prints (ref #2444 )
2015-11-09 21:36:17 +01:00
Alexander Graf
34cd8e3f95
Add default-v4 and default-v6 as options for discovery
2015-11-09 15:56:46 +01:00
Jakob Borg
242cce022a
Refactor out methods resolveAddresses, connectDirect, connectViaRelay
2015-11-09 15:35:32 +01:00
Jakob Borg
74a2e80142
Update docs & translations
2015-11-09 14:00:10 +01:00
Jakob Borg
b9b630e3b6
Change certificate on discovery-2
2015-11-09 13:58:44 +01:00
Jakob Borg
59565fd1d1
Woops
2015-11-07 11:25:00 +01:00
Jakob Borg
55592137a2
Use constructor functions for FolderConfiguration and DeviceConfiguration
2015-11-07 09:50:04 +01:00
Jakob Borg
58523060f0
Actually do negative caching on failed discovery lookups ( fixes #2434 )
2015-11-06 17:14:20 +01:00
Jakob Borg
34aa41e17b
Cache the Path() call, as it's quite expensive and called a lot
2015-11-06 07:11:22 +00:00
Jakob Borg
36f6a9347c
Benchmark must use *db.Instance
2015-11-05 17:46:53 +00:00
Jakob Borg
d49d386ef2
Docs and translation update
2015-11-05 15:47:06 +00:00
Jakob Borg
00c363829c
Refactor: move folder prepare to it's own function
2015-11-05 08:01:47 +00:00
Jakob Borg
9df701906f
Run JSON decoding through the usual setting of defaults and fixing up
...
I see no reason not to do this, and it gives a unified place (the prepare()
call) to initialize cached attributes and so on.
2015-11-04 20:33:10 +00:00
Jakob Borg
283671fa9d
Remove old dead code
2015-11-04 20:15:36 +00:00
Jakob Borg
435c29755d
We haven't had cleartext passwords in the config for ages
2015-11-04 20:15:11 +00:00
Jakob Borg
686f91777c
Don't force rescan dirs and symlinks
...
We can't look for changed modtime on these as we don't track the modtime
to start with.
2015-11-04 19:53:07 +00:00
Audrius Butkevicius
2aa028facb
Add user-agent header, capitalize headers as others seems to do it ( fixes #2422 )
2015-10-31 15:36:08 +00:00
Jakob Borg
2a4fc28318
We should pass around db.Instance instead of leveldb.DB
...
We're going to need the db.Instance to keep some state, and for that to
work we need the same one passed around everywhere. Hence this moves the
leveldb-specific file opening stuff into the db package and exports the
dbInstance type.
2015-10-31 12:35:30 +01:00
Jakob Borg
313485e406
Remove file that snuck in by mistake
2015-10-31 11:38:59 +01:00
Jakob Borg
faf4267c73
Refactor: the various db key functions should be instance methods
2015-10-31 11:27:04 +01:00
Jakob Borg
cdbc8004fb
Comment pedantry
2015-10-31 11:16:07 +01:00
Jakob Borg
08c8d679ac
Create a correct URL is more difficult than just slapping on a scheme ( fixes #2316 )
2015-10-30 21:22:40 +01:00
Jakob Borg
48c34b7234
Translation update
2015-10-30 10:23:09 +01:00
Jakob Borg
e1a8ea7dec
Rescan changed files before pulling on top of them ( fixes #2416 )
2015-10-29 09:12:37 +01:00
Jakob Borg
c4ad97136f
Move leveldb instance and transactions into separate files
2015-10-29 08:07:51 +01:00
Jakob Borg
fd7b8ec77e
Neater transaction handling
2015-10-28 22:04:00 +01:00
Jakob Borg
e28c991331
Create an instance type to tie database methods to
2015-10-28 21:03:05 +01:00
Jakob Borg
9e210d705d
The PublicKey() method is an addition in Go 1.4
2015-10-27 16:03:14 +01:00
Jakob Borg
c42f1b53ab
pulorder.go -> pullorder.go
2015-10-27 12:14:14 +01:00
Jakob Borg
d171173e90
AlwaysLocalNets should not default to null
2015-10-27 12:04:51 +01:00
Jakob Borg
679f0f9363
Fix some config Copy() things we had forgotten
2015-10-27 11:53:42 +01:00
Jakob Borg
724c1e297f
Remove handling of config versions < 10 (v0.11.0)
2015-10-27 11:46:33 +01:00
Jakob Borg
83154569b1
Refactor config types into separate files
2015-10-27 11:37:03 +01:00
Jakob Borg
e3c0fba34b
Must not call hex.Dump in non-debug mode...
2015-10-27 10:27:18 +01:00
Jakob Borg
2b6a6b91f3
Remove unused struct field
2015-10-27 09:55:05 +01:00
Jakob Borg
dc32f7f0a3
Reduce allocations in HashFile
...
By using copyBuffer we avoid a buffer allocation for each block we hash,
and by allocating space for the hashes up front we get one large backing
array instead of a small one for each block. For a 17 MiB file this
makes quite a difference in the amount of memory allocated:
benchmark old ns/op new ns/op delta
BenchmarkHashFile-8 102045110 100459158 -1.55%
benchmark old allocs new allocs delta
BenchmarkHashFile-8 415 144 -65.30%
benchmark old bytes new bytes delta
BenchmarkHashFile-8 4504296 48104 -98.93%
2015-10-27 09:37:27 +01:00
Jakob Borg
1efd8d6c75
Add benchmark of HashFile
2015-10-27 09:30:34 +01:00
Jakob Borg
464e6bec95
Log lines in REST should have lower case keys
2015-10-27 08:22:35 +01:00
Audrius Butkevicius
5b03c2d949
Remove dead code
2015-10-25 20:46:09 +00:00
Audrius Butkevicius
f629a998a0
Change errNoDevice message to something more human
2015-10-25 13:27:26 +00:00
Audrius Butkevicius
73236e58c5
Close channel after the client is stopped
2015-10-22 23:09:02 +01:00
Jakob Borg
32414853c6
Fix Raleway font
2015-10-22 21:08:24 +02:00
Jakob Borg
f3dc78d457
Don't deadlock after checking relay client status ( fixes #2404 )
2015-10-22 20:32:15 +02:00
Jakob Borg
a32ac62208
Don't expect ending slash on Windows
2015-10-22 13:49:41 +02:00
Jakob Borg
d7a934cf0e
Paths must not end with slash on Windows
2015-10-22 11:39:34 +02:00
Jakob Borg
503491392d
Correct amount of stack unwinding for debug prints
2015-10-22 11:38:45 +02:00
Jakob Borg
c19eff4872
Revive remote client version in the GUI
2015-10-22 08:53:28 +02:00
Jakob Borg
2941a813c2
Fix upgrade tests
2015-10-22 08:35:48 +02:00
Jakob Borg
0a022d38fa
Upgrade lib should use same criteria for beta check as main
2015-10-22 08:28:35 +02:00
Jakob Borg
7ed3b3dd3a
Docs update
2015-10-22 08:14:43 +02:00
Jakob Borg
9a1922fdc6
Merge pull request #2385 from AudriusButkevicius/you-are-next
...
Add separate client for dynamic relays (fixes #2368 )
2015-10-22 08:01:22 +02:00
Jakob Borg
83131103cf
Don't load block list in ...Truncated methods
...
Speeds up and reduces allocations on those operations, at the price of
having a manually tweaked XDR decoder for FileInfoTruncated.
benchmark old ns/op new ns/op delta
BenchmarkReplaceAll-8 1868198122 1880206886 +0.64%
BenchmarkUpdateOneChanged-8 231852 172695 -25.51%
BenchmarkUpdateOneUnchanged-8 230624 179341 -22.24%
BenchmarkNeedHalf-8 104601744 109461427 +4.65%
BenchmarkHave-8 29102480 34105026 +17.19%
BenchmarkGlobal-8 150547687 172778045 +14.77%
BenchmarkNeedHalfTruncated-8 102471355 76564986 -25.28%
BenchmarkHaveTruncated-8 28758368 14277481 -50.35%
BenchmarkGlobalTruncated-8 151192913 106070136 -29.84%
benchmark old allocs new allocs delta
BenchmarkReplaceAll-8 555577 557554 +0.36%
BenchmarkUpdateOneChanged-8 1135 587 -48.28%
BenchmarkUpdateOneUnchanged-8 1135 587 -48.28%
BenchmarkNeedHalf-8 374780 374775 -0.00%
BenchmarkHave-8 151992 152085 +0.06%
BenchmarkGlobal-8 530033 530135 +0.02%
BenchmarkNeedHalfTruncated-8 374699 22160 -94.09%
BenchmarkHaveTruncated-8 151834 4904 -96.77%
BenchmarkGlobalTruncated-8 530037 30536 -94.24%
benchmark old bytes new bytes delta
BenchmarkReplaceAll-8 1765116216 1765305376 +0.01%
BenchmarkUpdateOneChanged-8 135085 93043 -31.12%
BenchmarkUpdateOneUnchanged-8 134976 92928 -31.15%
BenchmarkNeedHalf-8 44758752 44751791 -0.02%
BenchmarkHave-8 11845052 11967172 +1.03%
BenchmarkGlobal-8 80431136 80431065 -0.00%
BenchmarkNeedHalfTruncated-8 46526459 18243543 -60.79%
BenchmarkHaveTruncated-8 11348357 418998 -96.31%
BenchmarkGlobalTruncated-8 80977672 43116991 -46.75%
2015-10-21 23:49:10 +02:00
Jakob Borg
c1591a5efd
Only run benchmarks with -tags benchmark
...
Avoids creating temp database and stuff on a normal test run
2015-10-21 23:19:26 +02:00
Jakob Borg
918ef4dff8
Use batches in blockmap, speeds up and reduces memory usage on large Replace and Update ops
...
benchmark old ns/op new ns/op delta
BenchmarkReplaceAll-8 2880834572 1868198122 -35.15%
BenchmarkUpdateOneChanged-8 236596 231852 -2.01%
BenchmarkUpdateOneUnchanged-8 227326 230624 +1.45%
BenchmarkNeedHalf-8 105151538 104601744 -0.52%
BenchmarkHave-8 28827492 29102480 +0.95%
BenchmarkGlobal-8 150768724 150547687 -0.15%
BenchmarkNeedHalfTruncated-8 104434216 102471355 -1.88%
BenchmarkHaveTruncated-8 27860093 28758368 +3.22%
BenchmarkGlobalTruncated-8 149972888 151192913 +0.81%
benchmark old allocs new allocs delta
BenchmarkReplaceAll-8 555451 555577 +0.02%
BenchmarkUpdateOneChanged-8 1135 1135 +0.00%
BenchmarkUpdateOneUnchanged-8 1135 1135 +0.00%
BenchmarkNeedHalf-8 374779 374780 +0.00%
BenchmarkHave-8 151996 151992 -0.00%
BenchmarkGlobal-8 530066 530033 -0.01%
BenchmarkNeedHalfTruncated-8 374702 374699 -0.00%
BenchmarkHaveTruncated-8 151834 151834 +0.00%
BenchmarkGlobalTruncated-8 530049 530037 -0.00%
benchmark old bytes new bytes delta
BenchmarkReplaceAll-8 5018351912 1765116216 -64.83%
BenchmarkUpdateOneChanged-8 135085 135085 +0.00%
BenchmarkUpdateOneUnchanged-8 134976 134976 +0.00%
BenchmarkNeedHalf-8 44769400 44758752 -0.02%
BenchmarkHave-8 11930612 11845052 -0.72%
BenchmarkGlobal-8 81523668 80431136 -1.34%
BenchmarkNeedHalfTruncated-8 46692342 46526459 -0.36%
BenchmarkHaveTruncated-8 11348357 11348357 +0.00%
BenchmarkGlobalTruncated-8 81843956 80977672 -1.06%
2015-10-21 23:05:23 +02:00
Jakob Borg
0d9a04c713
Reuse blockkey, speeds up large Update and Replace calls
...
benchmark old ns/op new ns/op delta
BenchmarkReplaceAll-8 2866418930 2880834572 +0.50%
BenchmarkUpdateOneChanged-8 226635 236596 +4.40%
BenchmarkUpdateOneUnchanged-8 229090 227326 -0.77%
BenchmarkNeedHalf-8 104483393 105151538 +0.64%
BenchmarkHave-8 29288220 28827492 -1.57%
BenchmarkGlobal-8 159269126 150768724 -5.34%
BenchmarkNeedHalfTruncated-8 108235000 104434216 -3.51%
BenchmarkHaveTruncated-8 28945489 27860093 -3.75%
BenchmarkGlobalTruncated-8 149355833 149972888 +0.41%
benchmark old allocs new allocs delta
BenchmarkReplaceAll-8 1054944 555451 -47.35%
BenchmarkUpdateOneChanged-8 1135 1135 +0.00%
BenchmarkUpdateOneUnchanged-8 1135 1135 +0.00%
BenchmarkNeedHalf-8 374777 374779 +0.00%
BenchmarkHave-8 151995 151996 +0.00%
BenchmarkGlobal-8 530063 530066 +0.00%
BenchmarkNeedHalfTruncated-8 374699 374702 +0.00%
BenchmarkHaveTruncated-8 151834 151834 +0.00%
BenchmarkGlobalTruncated-8 530021 530049 +0.01%
benchmark old bytes new bytes delta
BenchmarkReplaceAll-8 5074297112 5018351912 -1.10%
BenchmarkUpdateOneChanged-8 135097 135085 -0.01%
BenchmarkUpdateOneUnchanged-8 134976 134976 +0.00%
BenchmarkNeedHalf-8 44759436 44769400 +0.02%
BenchmarkHave-8 11911138 11930612 +0.16%
BenchmarkGlobal-8 81609867 81523668 -0.11%
BenchmarkNeedHalfTruncated-8 46588024 46692342 +0.22%
BenchmarkHaveTruncated-8 11348354 11348357 +0.00%
BenchmarkGlobalTruncated-8 79485168 81843956 +2.97%
2015-10-21 23:05:23 +02:00
Jakob Borg
0c0c69f0cf
The GC runs are legacy and slows things down quite a bit
...
benchmark old ns/op new ns/op delta
BenchmarkReplaceAll-8 2942370526 2866418930 -2.58%
BenchmarkUpdateOneChanged-8 7402489 226635 -96.94%
BenchmarkUpdateOneUnchanged-8 7298777 229090 -96.86%
BenchmarkNeedHalf-8 113608416 104483393 -8.03%
BenchmarkHave-8 29834263 29288220 -1.83%
BenchmarkGlobal-8 162773699 159269126 -2.15%
BenchmarkNeedHalfTruncated-8 111943400 108235000 -3.31%
BenchmarkHaveTruncated-8 29490369 28945489 -1.85%
BenchmarkGlobalTruncated-8 165841081 149355833 -9.94%
benchmark old allocs new allocs delta
BenchmarkReplaceAll-8 1054942 1054944 +0.00%
BenchmarkUpdateOneChanged-8 1149 1135 -1.22%
BenchmarkUpdateOneUnchanged-8 1135 1135 +0.00%
BenchmarkNeedHalf-8 374774 374777 +0.00%
BenchmarkHave-8 151995 151995 +0.00%
BenchmarkGlobal-8 530042 530063 +0.00%
BenchmarkNeedHalfTruncated-8 374697 374699 +0.00%
BenchmarkHaveTruncated-8 151834 151834 +0.00%
BenchmarkGlobalTruncated-8 530050 530021 -0.01%
benchmark old bytes new bytes delta
BenchmarkReplaceAll-8 5074294728 5074297112 +0.00%
BenchmarkUpdateOneChanged-8 141048 135097 -4.22%
BenchmarkUpdateOneUnchanged-8 134976 134976 +0.00%
BenchmarkNeedHalf-8 44734813 44759436 +0.06%
BenchmarkHave-8 11911634 11911138 -0.00%
BenchmarkGlobal-8 80436854 81609867 +1.46%
BenchmarkNeedHalfTruncated-8 46514673 46588024 +0.16%
BenchmarkHaveTruncated-8 11348357 11348354 -0.00%
BenchmarkGlobalTruncated-8 81730740 79485168 -2.75%
2015-10-21 23:05:22 +02:00
Jakob Borg
943e80e26c
Make benchmarks more realistic
2015-10-21 23:04:29 +02:00
Jakob Borg
1eca4170f7
Add test for LocalSize/GlobalSize results
2015-10-21 21:58:48 +02:00
Jakob Borg
c268e4ad1b
Also keep GlobalSize in RAM
2015-10-21 21:58:48 +02:00
Jakob Borg
d4f81e8791
Keep LocalSize data in RAM
2015-10-21 21:58:48 +02:00
Audrius Butkevicius
4f0680c3c8
Add separate client for dynamic relays ( fixes #2368 )
...
Did some manual tests in the playground, such as kicking off two clients in parallel, first connecting,
second one getting a message about already being connected, falling back to the second address.
2015-10-21 20:08:14 +01:00
Jakob Borg
8c26fe44c3
Actually run protocol tests faster with -short (on Go 1.5...)
2015-10-21 14:45:18 +02:00
Jakob Borg
8c7d9f3dd2
Protocol tests should run faster with -short
2015-10-21 14:35:59 +02:00
Jakob Borg
f241b7e79a
Global discovery should time out ( fixes #2389 )
2015-10-21 14:24:55 +02:00
Matt Burke
c2a5e180b8
Emit warning when sync could overwrite configuration
...
Overwriting configuration files is likely to happen if a
user syncs their home directories across computers. In this
case, the biggest risk is that all nodes will end up with
the same certificate and thus Device ID.
When the model prepares a folder for syncing, it checks to
see if the configuration files this instance is using are
getting synced. If the are getting synced, and they aren't
getting ignored, a warning is emitted. The model is used
so that when a new folder is added dynamically, a warning
is also emitted.
This will not prevent a user from shooting themselves in
the foot, and will not cover all cases (e.g. symlinks).
It should provide _something_ for many users in this
situation to go on, though.
2015-10-20 12:22:27 -04:00
Jakob Borg
aa42aafe33
Don't panic on clean shutdown
2015-10-20 15:59:37 +02:00
Jakob Borg
32c1a9bc45
Docs & translation update
2015-10-20 09:59:50 +02:00
Jakob Borg
0f9fa9507e
Tests must use locking to avoid race ( fixes #2394 )
2015-10-20 08:51:31 +02:00
Jakob Borg
90e0141ac5
Request() should return protocol errors
2015-10-19 15:14:41 +02:00
Jakob Borg
8435a8678e
Don't validate requests against the database
2015-10-19 15:14:41 +02:00
Jakob Borg
6578ffe2c9
Merge pull request #2320 from AudriusButkevicius/proto
...
More proto changes
2015-10-18 08:47:30 +02:00
Jakob Borg
175340522f
Merge pull request #2375 from AudriusButkevicius/proxy
...
Add proxy support (fixes #271 )
2015-10-18 08:45:17 +02:00
Audrius Butkevicius
afc917b582
Fix tests
2015-10-17 09:48:41 +01:00
Audrius Butkevicius
9f4cd7716e
Add more information about the folders to ClusterConfig
2015-10-17 09:46:46 +01:00
Jakob Borg
29b0017445
Merge pull request #2386 from AudriusButkevicius/epoint
...
Change relaypoolsrv endpoint
2015-10-17 09:14:35 +09:00
Jakob Borg
910a7c619a
Merge pull request #2381 from AudriusButkevicius/maxcon
...
Allow limiting max conflicts (fixes #2282 )
2015-10-17 09:10:31 +09:00
Audrius Butkevicius
273fac2028
Change relaypoolsrv endpoint
...
Just incase we want to show some stats in the future, such as a Geo-IP based map of where relays are, their dot size being proportional to global rate limits,
together with potentially how much data in total has been transferred, and how many sessions there by crawling relay status pages etc ;)
2015-10-17 00:10:01 +01:00
Audrius Butkevicius
a323d85d32
Add more information about the device to ClusterConfig
2015-10-16 19:40:12 +01:00
Audrius Butkevicius
491a33de0b
Move device name into the protocol messages
2015-10-16 19:40:12 +01:00
Audrius Butkevicius
752533489a
Allow limiting max conflicts ( fixes #2282 )
2015-10-16 19:26:38 +01:00
Audrius Butkevicius
e4e3c19e96
Our dialer sets up TCP options
2015-10-16 19:18:22 +01:00
Jakob Borg
e15be5c2bf
Merge pull request #2354 from eipiminus1/issue1361
...
Add trailing folder seperator to allow symlinks as folder path (fixes #1361 )
2015-10-16 09:29:37 +09:00
Jakob Borg
cc436dc8cb
Merge pull request #2372 from calmh/fix2371
...
Option -gui-address should accept scheme prefixes
2015-10-16 09:25:41 +09:00
Audrius Butkevicius
abbcd1f436
Patch up HTTP clients
2015-10-15 21:02:17 +01:00
Audrius Butkevicius
985ea29940
Add proxy support ( fixes #271 )
2015-10-15 21:01:42 +01:00
Jakob Borg
368cd44558
Fix race conditions in model tests
2015-10-14 14:41:16 +09:00
Jakob Borg
ff9920cbdc
Add eipiminus1
2015-10-13 08:38:03 +09:00
Jakob Borg
953a67bc3a
Option -gui-address should accept scheme prefixes ( fixes #2371 )
2015-10-13 08:26:07 +09:00
Audrius Butkevicius
29343aec3a
Fix division by zero ( fixes #2373 )
2015-10-12 18:57:15 +01:00
Audrius Butkevicius
2972472179
Add missing close
2015-10-12 17:10:59 +01:00
Jakob Borg
240e7b0835
Log/error fields changed name
2015-10-12 14:18:53 +09:00
Jakob Borg
baf5191433
Add mateon1
2015-10-12 14:13:38 +09:00
Jakob Borg
ec8bc02d33
Silence spurious debug ( fixes #2369 )
2015-10-12 10:11:58 +09:00
Yannic A
054bc970e2
Add trailing folder seperator to allow symlinks as folder path ( fixes #1361 )
2015-10-10 19:38:59 +02:00
Audrius Butkevicius
d985ed553a
Make puller pause configurable
2015-10-10 11:36:09 +01:00
Jakob Borg
76af9ba53d
Implement facility based logger, debugging via REST API
...
This implements a new debug/trace infrastructure based on a slightly
hacked up logger. Instead of the traditional "if debug { ... }" I've
rewritten the logger to have no-op Debugln and Debugf, unless debugging
has been enabled for a given "facility". The "facility" is just a
string, typically a package name.
This will be slightly slower than before; but not that much as it's
mostly a function call that returns immediately. For the cases where it
matters (the Debugln takes a hex.Dump() of something for example, and
it's not in a very occasional "if err != nil" branch) there is an
l.ShouldDebug(facility) that is fast enough to be used like the old "if
debug".
The point of all this is that we can now toggle debugging for the
various packages on and off at runtime. There's a new method
/rest/system/debug that can be POSTed a set of facilities to enable and
disable debug for, or GET from to get a list of facilities with
descriptions and their current debug status.
Similarly a /rest/system/log?since=... can grab the latest log entries,
up to 250 of them (hardcoded constant in main.go) plus the initial few.
Not implemented in this commit (but planned) is a simple debug GUI
available on /debug that shows the current log in an easily pasteable
format and has checkboxes to enable the various debug facilities.
The debug instructions to a user then becomes "visit this URL, check
these boxes, reproduce your problem, copy and paste the log". The actual
log viewer on the hypothetical /debug URL can poll regularly for new log
entries and this bypass the 250 line limit.
The existing STTRACE=foo variable is still obeyed and just sets the
start state of the system.
2015-10-03 18:09:53 +02:00
Jakob Borg
2de364414f
Adopt calmh/logger into lib/logger
2015-10-03 18:09:53 +02:00
Jakob Borg
36c746bd9f
Create missing directories
2015-10-01 09:43:16 +02:00
Audrius Butkevicius
7476c583e7
Merge pull request #2343 from calmh/discoprio2
...
Add discovery source priorities (fixes #2339 )
2015-10-01 08:22:17 +01:00
Jakob Borg
89928ca8e4
Add discovery source priorities ( fixes #2339 )
...
Sources are given a priority, lower being better, when added to a
CachingMux.
2015-10-01 08:45:40 +02:00
Jakob Borg
38a3bf3ada
Merge pull request #2317 from simplypeachy/patch-1
...
Add missing parameter in disk space warning
2015-10-01 08:10:36 +02:00
Jakob Borg
362ae5c4bb
Add copyright
2015-09-30 21:40:27 +02:00
Jakob Borg
be2ca0ea22
Revert "Case insensitive renames, part 1"
2015-09-30 21:40:04 +02:00
Jakob Borg
ddfebb17cf
Case insensitive renames, part 1
2015-09-30 12:41:29 +02:00
Audrius Butkevicius
b614cfffcb
Merge pull request #2330 from calmh/eventids
...
Subscribing to events should not bump event ID (fixes #2329 )
2015-09-29 19:05:57 +01:00
Audrius Butkevicius
b58a52c7b4
Merge pull request #2332 from calmh/brokenignore
...
Correctly report errors encountered parsing ignores (fixes #2309 )
2015-09-29 17:15:07 +01:00
Jakob Borg
a80fc1b062
Correctly report errors encountered parsing ignores ( fixes #2309 , fixes #2296 )
...
An error on opening .stignore will satisfy os.IsNotExist() and not be
reported. Other errors will be reported and stop the folder, including
is-not-exist errors from #include as these are passed through fmt.Errorf.
Also fixes minor issue where we would not print cause of folder stopping
to the log.
Also fixes minor issue with capitalization of errors.
2015-09-29 18:04:18 +02:00
Jakob Borg
22a2e95126
CachingMux should return unique addresses only ( fixes #2321 )
2015-09-29 17:40:39 +02:00
Jakob Borg
11e1a99e14
Subscribing to events should not bump event ID ( fixes #2329 )
2015-09-29 17:17:09 +02:00
Jakob Borg
3c6bfb880d
Docs and translation update
2015-09-27 22:31:19 +02:00
Audrius Butkevicius
ad2c05c3f5
Merge pull request #2322 from calmh/colons
...
Don't naively join host and port using colon (fixes #2316 )
2015-09-27 20:52:29 +01:00
Jakob Borg
fa75f54a05
Don't naively join host and port using colon ( fixes #2316 )
2015-09-27 21:44:08 +02:00
simplypeachy
f42f20c70c
Update rwfolder.go
...
Revert copyright/grammar changes.
2015-09-27 09:50:54 +01:00
Jakob Borg
209bc59e8c
Don't check for free space on master folders ( fixes #2236 )
...
Also clean up the logic a little, I thought it was a bit muddled.
2015-09-27 09:33:11 +02:00
simplypeachy
ed7791d824
Add missing parameter in disk space warning
...
Plus copyright bump, minor grammatical fix.
2015-09-26 16:46:42 +01:00
Jakob Borg
47c7351b16
Clean up connection.Model interface a little
2015-09-26 13:19:22 +02:00
Jakob Borg
b158072a15
Merge pull request #2189 from burkemw3/lib-ify-connections
...
Decouple connections service from model
2015-09-26 13:18:23 +02:00
Matt Burke
2234c45c19
Decouple connections service from model
...
The connections service no longer depends directly on the
syncthing model object, but on an interface instead. This
makes it drastically easier to write clients that handle
the model differently, but still want to benefit from
existing and future connections changes in the core.
This was motivated by burkemw3's interest in creating a
FUSE client that can present a view of the global model,
but not have all of the file data locally.
The actual decoupling was done by adding a connections.Model
interface. This interface is effectively an extension of the
protocol.Model interface that also handles connections
alongside the modified service.
2015-09-25 12:19:30 -04:00
Jakob Borg
e0a16e08dd
Relax folder label restrictions
2015-09-25 13:45:58 +02:00
Jakob Borg
e522811a52
Encapsulate local discovery address in struct
...
The XDR encoder doesn't understart slices of strings very well. It can
encode and decode them, but there's no way to set limits on the length
of the strings themselves (only on the length of the slice), and the
generated diagrams are incorrect. This trivially works around this,
while also documenting what the string actually is (a URL).
2015-09-22 23:28:00 +02:00
Jakob Borg
6124bbb12a
There is no local discovery query packet
2015-09-22 23:10:05 +02:00
Jakob Borg
fbf911cf7e
Unbreak comments
2015-09-22 21:51:05 +02:00
Jakob Borg
7fdfa81fb8
Fix vet and lint complaints
2015-09-22 20:34:24 +02:00
Jakob Borg
4581c57478
Fix import paths
2015-09-22 19:38:46 +02:00