joomla
/
weblinks
mirror of https://github.com/joomla-extensions/weblinks.git
30
1
Fork 0
Code Issues Releases Activity

Introduce jquery formvalidator for com_weblinks 

#### Executive summary

This PR converts the form validation on com_weblinks to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!

#### Testing

1. Apply first PR #4888 (!important)
2. Apply this PR
3. In the admin area go to com_weblinks and try to submit any form.

If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here

Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.
This commit is contained in:
dgt41 2014-11-13 17:09:11 +02:00
parent e2c472aca8
commit ceed4b3be0
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/com_weblinks/admin/views/weblink/tmpl/edit.php
View File

@ -11,19 +11,20 @@ defined('_JEXEC') or die;
JHtml::addIncludePath(JPATH_COMPONENT . '/helpers/html'); JHtml::addIncludePath(JPATH_COMPONENT . '/helpers/html');
JHtml::_('behavior.formvalidation'); JHtml::_('behavior.formvalidator');
JHtml::_('formbehavior.chosen', 'select'); JHtml::_('formbehavior.chosen', 'select');
?> JFactory::getDocument()->addScriptDeclaration("
<script type="text/javascript"> jQuery(document).ready(function() {
Joomla.submitbutton = function(task) Joomla.submitbutton = function(task)
{ {
if (task == 'weblink.cancel' || document.formvalidator.isValid(document.id('weblink-form'))) { if (task == 'weblink.cancel' || document.formvalidator.isValid(document.getElementById('weblink-form'))) {
<?php echo $this->form->getField('description')->save(); ?> " . $this->form->getField('description')->save() . "
Joomla.submitform(task, document.getElementById('weblink-form')); Joomla.submitform(task, document.getElementById('weblink-form'));
} }
} }
</script> });");
?>
<form action="<?php echo JRoute::_('index.php?option=com_weblinks&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="weblink-form" class="form-validate"> <form action="<?php echo JRoute::_('index.php?option=com_weblinks&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="weblink-form" class="form-validate">

14
src/com_weblinks/admin/views/weblinks/tmpl/default.php
View File

@ -27,24 +27,26 @@ if ($saveOrder)
JHtml::_('sortablelist.sortable', 'weblinkList', 'adminForm', strtolower($listDirn), $saveOrderingUrl); JHtml::_('sortablelist.sortable', 'weblinkList', 'adminForm', strtolower($listDirn), $saveOrderingUrl);
} }
$sortFields = $this->getSortFields(); $sortFields = $this->getSortFields();
?>
<script type="text/javascript"> JFactory::getDocument()->addScriptDeclaration('
jQuery(document).ready(function() {
Joomla.orderTable = function() Joomla.orderTable = function()
{ {
table = document.getElementById("sortTable"); table = document.getElementById("sortTable");
direction = document.getElementById("directionTable"); direction = document.getElementById("directionTable");
order = table.options[table.selectedIndex].value; order = table.options[table.selectedIndex].value;
if (order != '<?php echo $listOrder; ?>') if (order != "' . $listOrder . '")
{ {
dirn = 'asc'; dirn = "asc";
} }
else else
{ {
dirn = direction.options[direction.selectedIndex].value; dirn = direction.options[direction.selectedIndex].value;
} }
Joomla.tableOrdering(order, dirn, ''); Joomla.tableOrdering(order, dirn, "");
} }
</script> });');
?>
<form action="<?php echo JRoute::_('index.php?option=com_weblinks&view=weblinks'); ?>" method="post" name="adminForm" id="adminForm"> <form action="<?php echo JRoute::_('index.php?option=com_weblinks&view=weblinks'); ?>" method="post" name="adminForm" id="adminForm">
<?php if (!empty( $this->sidebar)) : ?> <?php if (!empty( $this->sidebar)) : ?>
<div id="j-sidebar-container" class="span2"> <div id="j-sidebar-container" class="span2">