2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-12-23 18:48:55 +00:00
Commit Graph

17 Commits

Author SHA1 Message Date
Kenneth G. Franqueiro
a157f716a5 Implement multi-target options and refactor code
This adds support for --all, --platform=all, and --arch=all.

In order to accommodate outputting multiple directories for multiple
platforms and architectures, this also implements a new directory
structure under the output folder (distinguished by both platform and
arch).  This structure is applied even to OS X distributions, which
formerly were output directly to an .app folder.  This could be considered
a backwards-incompatible change.

One other backwards-incompatible change is the value that the packager
function passes to the callback, which is now always an array of paths,
rather than just a single path.

The behavior of the icon option has also been modified to use its
basename and apply .ico or .icns depending on platform, to make it
usable with --all and --platform=all.  This attempts to maximize
backwards compatibility, by allowing a full filename to be specified,
but replacing the filename's extension with what is appropriate for
each target platform.  Alternatively, the extension can now be omitted.

In the process of implementing this, it became evident that some things
were being done in 3 different places, and weren't always being done
consistently, so I've deduplicated everything I could.

This also includes a few other changes to improve stability for
multi-target runs, and other fixes:

* Avoid targeting darwin if the environment doesn't support symlinks,
  to avoid the process bailing out on Windows
* Implement --overwrite centrally in index.js such that it explicitly
  skips if an output directory already exists, for consistency with
  all target platforms and to avoid any possible errors that would halt
  operation during one target of a multi-target run
* Use ncp instead of mv to move to finalPath, which avoids flakiness
  I noticed when testing on Windows 8 especially with multi-target runs
* Simplify temp directory logic by using a nested structure, so there
  is only one top-level directory to clean up
* Reinstate fix from #55 which seems to have been clobbered by a later
  merge
* linux.createApp now resolves to the final output directory;
  it was formerly resolving to the executable path
* mac.createApp now replaces space with underscore in bundle IDs
* Only the platform modules that are needed are loaded
* The win32 module only loads rcedit if needed

This also fixes a couple of missing updates to docs (readme/usage).

This commit addresses the following issues:

* Resolves #40
* Resolves #38
* Resolves #70
* Works around #71
* Resolves #84 by reinstating #55
2015-06-28 16:57:56 -04:00
Max Ogden
86edff69d8 add basic tests, remove unused folder, make linux out dir behave like other OSes 2015-06-27 19:48:35 -05:00
=^._.^=
b80a060716 Merge pull request #76 from kfranqueiro/rename-helper
Fix #65: Rename Helper application on Mac OS X
2015-06-27 19:26:42 -05:00
Max Ogden
ec321d2593 merge 2015-06-27 19:25:56 -05:00
Yifei Teng
f39ba8c8f2 Support --overwrite 2015-06-23 10:54:45 -07:00
Mark Lee
e4ad46b2a8 Fix renaming folders across volumes on OS X
Fixes #60.
2015-06-21 14:44:58 -07:00
Kenneth G. Franqueiro
dd2a5d4b68 Fix #65: Rename Helper application on Mac OS X
This fixes the helper process showing up in Activity Monitor as
"Electron Helper"; it will now show up as "<appname> Helper".
2015-06-17 23:50:52 -04:00
Markus Mühlberger
c1269f62c8 Add quotes around signing identity to allow spaces 2015-06-16 18:49:44 +02:00
Mark Lee
bdc8c46362 Move prune to common module 2015-06-09 19:50:52 -07:00
Mark Lee
16b2feb39f Move user ignore filter to common module 2015-06-09 19:26:55 -07:00
Mark Lee
83dd1dcb34 Move asar code to a common location 2015-06-09 19:17:21 -07:00
jden
aa5c6187e3 always dereference symlinks - per #42 2015-05-20 19:05:47 -07:00
Jens Lind
d4f4c78769 Added codesign 2015-05-12 20:32:37 +02:00
Mark Lee
1e1a479b23 Ensure the out dir specified exists when building OSX app 2015-05-10 15:44:38 -07:00
Max Ogden
260a16509b breaking change. allow building apps for other platforms 2015-05-10 13:57:42 -07:00
Kyle Robinson Young
a2abf5ed6c Add asar support. Closes GH-2 2015-05-05 21:34:51 -07:00
Mark Lee
17803f01d1 Put Mac-specific code in its own file, raise error if platform unsupported 2015-05-05 07:43:09 -07:00