2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-05 04:47:54 +00:00
Commit Graph

967 Commits

Author SHA1 Message Date
davidfant
bd077756e8
Emit TS type declarations, and type NativefierOptions (#1016)
This PR adds better Typescript support when using the Node module directly:
1. Generate type declarations when running `tsc`
2. Created the `NativefierOptions` type for the `buildNativefierApp` function instead of using `any`
2020-08-05 20:26:41 -04:00
Joe Skeen
3e5f1fabad
[dev] Add unified {build,test} watch mode, using "concurrently" (#1011)
I noticed that the development README suggested using multiple console 
windows/tabs for a good development experience. Using the package `concurrently`,
we can streamline that and require only one window with output for both watch processes:

![image](https://user-images.githubusercontent.com/12286274/88694827-477d9e80-d0be-11ea-898c-ee9a509db4bb.png)


Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
2020-08-05 12:52:49 -04:00
Joe Skeen
8e8cd24e0d
Add --block-external-urls flag to forbid external navigation attempts (Fix #978 - PR#1012)
Fixes #978 

Adds a `--block-external-urls` option (default: `false`) that prevents opening external links (as classified by the `--internal-urls` option).

Documentation and tests updated.


Example:
```
nativefier --internal-urls "classroom\.google\.com" --block-external-urls
```
![image](https://user-images.githubusercontent.com/12286274/88739501-f12d5180-d0f7-11ea-9821-86f3e9bfa070.png)
![image](https://user-images.githubusercontent.com/12286274/88739512-fab6b980-d0f7-11ea-877c-7bd565352a93.png)
2020-08-02 14:31:47 -04:00
Ronan Jouchet
5d9a7ae4bc nit 2020-07-22 21:08:07 -04:00
Ronan Jouchet
6f50ac6f4f A little less aggressive 2020-07-22 21:07:22 -04:00
Ronan Jouchet
3bf3f2c0a8 One more 2020-07-22 21:04:58 -04:00
Ronan Jouchet
bed84e5735 One more nit 2020-07-22 20:57:48 -04:00
Ronan Jouchet
c87204cce7 Typo 2020-07-22 20:56:58 -04:00
Ronan Jouchet
7c84785e33 typo 2020-07-22 20:56:29 -04:00
Ronan Jouchet
f8e0e9d6cb Detail question.md 2020-07-22 20:56:14 -04:00
Ronan Jouchet
b631ee23d6 Nit 2020-07-22 20:54:27 -04:00
Ronan Jouchet
6b73b4e8f8 Improve issue templates 2020-07-22 20:53:46 -04:00
Ronan Jouchet
99ceec59c8 Forbid creating template-less issues 2020-07-22 20:37:04 -04:00
Ronan Jouchet
8684887fc6 Bump eslint to 7.x, fix new lint errors 2020-07-18 11:19:58 -04:00
Ronan Jouchet
30f7aff7a9 README: fix links to bugs & feature requests 2020-07-18 10:30:22 -04:00
Ronan Jouchet
1a36d24597 More README nits 2020-07-18 10:27:56 -04:00
Ronan Jouchet
cc8d65063a Simplify README, move unmaintained docker doc to Dockerfile 2020-07-18 10:19:58 -04:00
Ronan Jouchet
aa5a98b5e7 Update changelog for v9.1.0 2020-07-18 02:19:44 -04:00
Ronan Jouchet
53a2e9b4d3 Remove @types/electron-packager, they're built-in since 15.x 2020-07-18 02:18:33 -04:00
Ronan Jouchet
792156f376 Bump deps: electron-packager, ts-loader, types 2020-07-18 01:47:46 -04:00
Ronan Jouchet
c18fc1ef9a Bump default Electron to 9.1.0 2020-07-18 01:36:32 -04:00
Ronan Jouchet
f23447312d Fix 'Image could not be created' app error on run (fix #992)
Electron 9.x now crashes when passed a non-existent icon.
Also, it accepts both ico and png.
So, do our best to pass it a file that exists.
2020-07-18 01:26:23 -04:00
Pranav Shikarpur
e592c6bca6
Bumped up NODE docker image version from 8 to 12.18.1 (#996)
Updated Node version in the Dockerfile from 8-stretch to 12.18.1-stretch. 12.18.1 is currently the most recent LTS version of NodeJS.
2020-06-28 16:15:30 -04:00
Ronan Jouchet
9b0252d597 release.md: document creating & pushing npm-release-causing tag 2020-06-13 11:27:38 -04:00
Ronan Jouchet
ab852c3f6c Update changelog for v9.0.0 2020-06-13 11:03:58 -04:00
Ronan Jouchet
3b344306b0 README: mention Node 10 is required 2020-06-13 10:51:00 -04:00
Ronan Jouchet
8fa394a1c0 [BREAKING CHANGE] Require Node.js >= 10
- Several deps started requiring it
- CI started breaking on Node 8
- Node 8 is end-of-life, no longer maintained
- Even latest Debian stable and Ubuntu LTS ship Node 10:
    https://packages.debian.org/search?suite=stable&keywords=nodejs
    https://packages.ubuntu.com/search?searchon=names&suite=all&section=all&keywords=nodejs

So, requiring Node 10 and npm 6 going with it.
2020-06-13 10:46:27 -04:00
Ronan Jouchet
e5ba8c779f Bump default Electron to 9.0.4, bump deps (jest, electron-context-menu) 2020-06-13 10:23:15 -04:00
Luke Hamburg
6b81324531
--help: fix typo, clarify --icon helptext (PR #976)
- correct small typo (`he`→`the`)
- clarify that `--icon` accepts .icns on macOS
2020-06-13 10:05:43 -04:00
Alexander Weps
1d3bed5f09
Fix: notifications (fix #88, fix #956), processEnvs, using as git (#955)
1. Fix (broken since 2016): Notifications broken by lambda constructor
2. Fix: `--processEnvs` broken by additional processEnvs object, the result was:
`processEnvs: {processEnvs: {...}}` which caused the conversion of the inner object into string `[object Object]`, no nesting allowed there probably. Compatibility introduced.
3. Fix: package.json missing `prepare` (or even prepublish), which breaks using as git dependency.
2020-04-27 11:52:21 -04:00
Ronan Jouchet
9ccda87938 Update changelog for v8.0.7 2020-04-22 22:12:36 -04:00
Ronan Jouchet
eef320a150 Bump default Electron to 8.2.3, and bump app/electron-context-menu to 1.x 2020-04-22 22:09:13 -04:00
Ronan Jouchet
4fbc3f7503 Fix 'Unable to load preload script' (fix #934)
No reason to use loglevel in the *app*.
It makes sense in the CLI, but in the app console.{info,log,...} is totally fine.
2020-04-22 22:02:34 -04:00
Ronan Jouchet
fafaead442 Bump default Electron to 8.2.1 2020-04-06 22:01:32 -04:00
Ronan Jouchet
fd0395a860 Update changelog for v8.0.6 2020-03-27 09:11:58 -04:00
Ronan Jouchet
34e443c832 Update changelog for v8.0.5 2020-03-27 09:00:39 -04:00
Ronan Jouchet
139a5745c8 Fix unintentionally *global*/os-wide keyboard shortcuts (fix #930) 2020-03-27 08:47:44 -04:00
Ronan Jouchet
0c2510f31e Bump default Electron to 8.2.0 and Prettier 2020-03-24 20:27:25 -04:00
Ronan Jouchet
91426d2e3e Travis: fix warning 'deploy: key api_key is an alias for api_token, using api_token' 2020-03-20 22:46:56 -04:00
Ronan Jouchet
86cf42844f Log a helpful error when failing to parse JSON arg (fix #928) 2020-03-20 21:03:37 -04:00
Ronan Jouchet
9f11976b3c Bugreport issue template: add checkmark for latest version 2020-03-19 18:09:37 -04:00
Ronan Jouchet
3c4b743c67 Improve bugreport issue template 2020-03-19 12:30:08 -04:00
Ronan Jouchet
4068497120 App/menu: back & forward: expose standard shortcuts first & handle mac, keep old weird shortcuts for backward compat 2020-03-18 08:51:46 -04:00
Ronan Jouchet
f7215814d7 App/menu: cleanup, typing, properly hide devtools when asked (fix #842) 2020-03-18 00:21:17 -04:00
Ronan Jouchet
72a9eae6d6 Update changelog for v8.0.4 2020-03-16 21:34:20 -04:00
Ronan Jouchet
35eb72edfd Fix travis build
We no longer have a postinstall so we need to explicitly
'npm run dev-up' for cli+app deps, like we did before.
2020-03-16 21:20:38 -04:00
Ronan Jouchet
cde5c1e13b Fix failing to global-sudo-install due to postinstall script (fix #923)
As documented in https://github.com/jiahaog/nativefier/issues/923#issuecomment-599300317 ,

- #923 is caused by installing placeholder app deps at nativefier
  *install* time, with yarn (8.0.2) or npm (8.0.3). This is new in
  Nativefier 8.x, for the motivations behind it, see
  https://github.com/jiahaog/nativefier/pull/898#issuecomment-583865045

- During testing, I did test global installs, but never to a
  system / non-user-writable path (my `$npm_config_prefix` is set to
  `"$HOME/.node_modules"`)

- But without such a config and when installing globally to a
  non-user-writable/system path with `sudo npm i -g nativefier`,

    - Installation of nativefier core works...

    - ... but then `postinstall` tries to do its job of installing
    app deps, and fails in various OS-dependent ways, but all about
    access rights.
    I suspect that, although main nativefier install runs as `su` with
    access rights to system paths, `postinstall` scripts are run *out*
    of `su`.
    That would make sense for security reasons: out of hook scripts,
    npm knows exactly what will be touched in your filesystem: it's the
    static contents of the published tarball; a postinstall script with
    sudo rights could do nasty dynamic stuff. So, although I don't see
    any mention of that in
    [npm-scripts docs / hooks](https://docs.npmjs.com/misc/scripts#hook-scripts)
    and I haven't dug npm/cli's code, I can understand it.

So, reverting back to `webpack`ing the placeholder app, as done pre-8.0.
2020-03-16 21:06:03 -04:00
Ronan Jouchet
0a380bd0f4 Update changelog for v8.0.3 2020-03-15 20:57:48 -04:00
Ronan Jouchet
f1f6dda4d1 Fix failing to install due to app yarn install
Actually not sure this will work, but let's try.
If that works, that means we're back to pre-
https://github.com/jiahaog/nativefier/pull/898#issuecomment-583865045 ,
with a 60s timeout due to npm bug https://github.com/npm/cli/issues/757

Looking at a real fix, potentially coming back to `webpack` the app.
2020-03-15 20:54:21 -04:00
Ronan Jouchet
dbf12e4f78 README: fix path to images 2020-03-15 17:57:22 -04:00