2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-12-31 21:21:52 +00:00
nativefier/app
Ronan Jouchet c0a6604676
Fix considering "same domain-ish" URLs as internal (PR #1126)
In 6b266b7815, as I got rid of deprecated dep `wurl`, I wrote:

> This one may be problematic, as it used to do TLD stuff:
> https://github.com/websanova/node-url/blob/7982a613bc/wurl.js#L4
>
> So, the new WHATWG-URL-based implementation will consider
> `asana.com` to be "external" to `app.asana.com`, contrarily to before.
> Given the nature of Nativefier, I think it's actually what to expect,
> that in this case you're "out of the app", and in e.g. asana's landing
> page, which you'd expect to see in your browser.

Turns out it's even more problematic: @TheCleric notices in https://github.com/nativefier/nativefier/pull/1124#issuecomment-790279403
that this breaks app `https://evernote.com` doing its login in `www.evernote.com`

The present change fixes this, by behaving mostly similarly to before,
but without re-introducing `wurl` or another dep needing a TLD/SLD list.
2021-03-04 10:00:53 -05:00
..
inject Fix bug where css is always injected 2016-02-25 15:25:14 +08:00
src Fix considering "same domain-ish" URLs as internal (PR #1126) 2021-03-04 10:00:53 -05:00
.eslintrc.js Bump eslint to 7.x, fix new lint errors 2020-07-18 11:19:58 -04:00
.npmrc Upgrade dependencies and default to latest Electron 1.7.9 (PR #483) 2017-11-14 08:05:01 -05:00
nativefier.json Fix placeholder for electron app to google 2016-05-26 16:50:42 +08:00
package.json (Attempt to) get rid of deprecated app dep wurl 2021-02-25 18:55:28 -05:00
tsconfig.json TSConfig: bump to target/lib es2018, since we require node10 2021-02-26 22:50:59 -05:00
webpack.config.js Fix failing to global-sudo-install due to postinstall script (fix #923) 2020-03-16 21:06:03 -04:00