2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-15 17:27:08 +00:00
nativefier/app/src/helpers
Alexander Weps ca7d25f432
Fix notifications broken since Nativefier 43 / Electron 12 defaulting to contextIsolation:true (PR #1308)
Copy-pastaing details from [Electron 12 breaking changes](https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-120):

> ### Default Changed: `contextIsolation` defaults to `true`[​](https://www.electronjs.org/docs/latest/breaking-changes#default-changed-contextisolation-defaults-to-true "Direct link to heading")
> 
> In Electron 12, `contextIsolation` will be enabled by default. To restore the previous behavior, `contextIsolation: false` must be specified in WebPreferences.
> 
> We [recommend having contextIsolation enabled](https://www.electronjs.org/docs/latest/tutorial/security#3-enable-context-isolation-for-remote-content) for the security of your application.
> 
> Another implication is that `require()` cannot be used in the renderer process unless `nodeIntegration` is `true` and `contextIsolation` is `false`.
> 
> For more details see: [https://github.com/electron/electron/issues/23506](https://github.com/electron/electron/issues/23506)

I find the security drop acceptable, as reverting the new Electron 12 isolation brings us to the previous level of security, and I don't have the time/will to keep the isolation and migrate to the newer better safer thing that Electron >= 12 wants.

Co-authored-by: Radomír Polách <rp@t4d.cz>
2021-11-22 16:00:13 -05:00
..
helpers.test.ts Internal login pages: add (id|auth).atlassian.com (fix #1265) 2021-07-28 23:22:02 -04:00
helpers.ts Internal login pages: add (id|auth).atlassian.com (fix #1265) 2021-07-28 23:22:02 -04:00
inferFlash.ts Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
windowEvents.test.ts Make app strict TypeScript + linting (and add a shared project) (#1231) 2021-06-26 09:59:28 -04:00
windowEvents.ts Fix regressions in opening windows/tabs, update browser versions (#1284) 2021-09-24 22:03:03 -04:00
windowHelpers.test.ts Fix regressions in opening windows/tabs, update browser versions (#1284) 2021-09-24 22:03:03 -04:00
windowHelpers.ts Fix notifications broken since Nativefier 43 / Electron 12 defaulting to contextIsolation:true (PR #1308) 2021-11-22 16:00:13 -05:00