rector/rules/CodeQuality/Rector/ClassMethod/OptionalParametersAfterRequiredRector.php

159 lines
5.9 KiB
PHP
Raw Normal View History

<?php
declare (strict_types=1);
2022-06-06 16:43:29 +00:00
namespace RectorPrefix20220606\Rector\CodeQuality\Rector\ClassMethod;
2022-06-06 16:43:29 +00:00
use RectorPrefix20220606\PhpParser\Node;
use RectorPrefix20220606\PhpParser\Node\Expr\MethodCall;
use RectorPrefix20220606\PhpParser\Node\Expr\New_;
use RectorPrefix20220606\PhpParser\Node\Stmt\ClassMethod;
use RectorPrefix20220606\PHPStan\Reflection\MethodReflection;
use RectorPrefix20220606\PHPStan\Reflection\ParametersAcceptorSelector;
use RectorPrefix20220606\Rector\CodingStyle\Reflection\VendorLocationDetector;
use RectorPrefix20220606\Rector\Core\Rector\AbstractRector;
use RectorPrefix20220606\Rector\Core\Reflection\ReflectionResolver;
use RectorPrefix20220606\Rector\Php80\NodeResolver\ArgumentSorter;
use RectorPrefix20220606\Rector\Php80\NodeResolver\RequireOptionalParamResolver;
use RectorPrefix20220606\Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use RectorPrefix20220606\Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
2021-04-10 18:47:17 +00:00
* @changelog https://php.watch/versions/8.0#deprecate-required-param-after-optional
*
* @see \Rector\Tests\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector\OptionalParametersAfterRequiredRectorTest
*/
2022-06-06 16:43:29 +00:00
final class OptionalParametersAfterRequiredRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\Php80\NodeResolver\RequireOptionalParamResolver
*/
private $requireOptionalParamResolver;
/**
* @readonly
* @var \Rector\Php80\NodeResolver\ArgumentSorter
*/
private $argumentSorter;
/**
* @readonly
* @var \Rector\Core\Reflection\ReflectionResolver
*/
private $reflectionResolver;
/**
* @readonly
* @var \Rector\CodingStyle\Reflection\VendorLocationDetector
*/
private $vendorLocationDetector;
2022-06-06 16:43:29 +00:00
public function __construct(RequireOptionalParamResolver $requireOptionalParamResolver, ArgumentSorter $argumentSorter, ReflectionResolver $reflectionResolver, VendorLocationDetector $vendorLocationDetector)
{
$this->requireOptionalParamResolver = $requireOptionalParamResolver;
$this->argumentSorter = $argumentSorter;
$this->reflectionResolver = $reflectionResolver;
$this->vendorLocationDetector = $vendorLocationDetector;
}
2022-06-06 16:43:29 +00:00
public function getRuleDefinition() : RuleDefinition
{
2022-06-06 16:43:29 +00:00
return new RuleDefinition('Move required parameters after optional ones', [new CodeSample(<<<'CODE_SAMPLE'
class SomeObject
{
public function run($optional = 1, $required)
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeObject
{
public function run($required, $optional = 1)
{
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
2022-06-06 16:43:29 +00:00
return [ClassMethod::class, New_::class, MethodCall::class];
}
/**
* @param ClassMethod|New_|MethodCall $node
*/
2022-06-06 16:43:29 +00:00
public function refactor(Node $node) : ?Node
{
2022-06-06 16:43:29 +00:00
if ($node instanceof ClassMethod) {
return $this->refactorClassMethod($node);
}
2022-06-06 16:43:29 +00:00
if ($node instanceof New_) {
return $this->refactorNew($node);
}
return $this->refactorMethodCall($node);
}
2022-06-06 16:43:29 +00:00
private function refactorClassMethod(ClassMethod $classMethod) : ?ClassMethod
{
if ($classMethod->params === []) {
return null;
}
$classMethodReflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($classMethod);
2022-06-06 16:43:29 +00:00
if (!$classMethodReflection instanceof MethodReflection) {
return null;
}
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($classMethodReflection);
if ($expectedArgOrParamOrder === null) {
return null;
}
$newParams = $this->argumentSorter->sortArgsByExpectedParamOrder($classMethod->params, $expectedArgOrParamOrder);
$classMethod->params = $newParams;
return $classMethod;
}
2022-06-06 16:43:29 +00:00
private function refactorNew(New_ $new) : ?New_
{
if ($new->args === []) {
return null;
}
$methodReflection = $this->reflectionResolver->resolveMethodReflectionFromNew($new);
2022-06-06 16:43:29 +00:00
if (!$methodReflection instanceof MethodReflection) {
return null;
}
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection);
if ($expectedArgOrParamOrder === null) {
return null;
}
$new->args = $this->argumentSorter->sortArgsByExpectedParamOrder($new->getArgs(), $expectedArgOrParamOrder);
return $new;
}
2022-06-06 16:43:29 +00:00
private function refactorMethodCall(MethodCall $methodCall) : ?MethodCall
{
$methodReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($methodCall);
2022-06-06 16:43:29 +00:00
if (!$methodReflection instanceof MethodReflection) {
return null;
}
$expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection);
if ($expectedArgOrParamOrder === null) {
return null;
}
$newArgs = $this->argumentSorter->sortArgsByExpectedParamOrder($methodCall->getArgs(), $expectedArgOrParamOrder);
if ($methodCall->args === $newArgs) {
return null;
}
$methodCall->args = $newArgs;
return $methodCall;
}
/**
* @return int[]|null
*/
2022-06-06 16:43:29 +00:00
private function resolveExpectedArgParamOrderIfDifferent(MethodReflection $methodReflection) : ?array
{
if ($this->vendorLocationDetector->detectMethodReflection($methodReflection)) {
return null;
}
2022-06-06 16:43:29 +00:00
$parametersAcceptor = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
$expectedParameterReflections = $this->requireOptionalParamResolver->resolveFromReflection($methodReflection);
if ($expectedParameterReflections === $parametersAcceptor->getParameters()) {
return null;
}
return \array_keys($expectedParameterReflections);
}
}