* [CI] run rules dir by dir to identify static reflection weak sposts
* [ci-review] Rector Rectify
* consistency
* remove unused property
* add data provider test fixture
* add InvertedIfFactory to lower complexity
* [DeadCode] Skip unused public method if data provider
* misc
* [DeadCode] Do not remove class method if required by parent ocntract
* make use of ContextAnalyzer to find the loop
* narrow dirs one level
* narrow packages
* narrow
* use directly
* narrow
* correct constant name to keep BC
* bump deps
* add version_compare to removed extra params, just to be sure
* do not return function node on unchanged name
* narrow
* add support for multiple variants
* widen
* remove double check [skip ci]
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
* Improve GHA build process to provide scoped Docker images for PHP 7.3-8.0
* Push cached build layers to Docker Hub instead of ghcr.io
* Build "-secured" Docker image
* Run Docker publish workflow for the "experimental-scoped" branch
* Use "plain" progress output from buildx
* Build only one image named "secured", based on PHP 8.0
* break test without autoload
* PHPStanServiceFactory - add tests directory as analysed paths
* use ReflectionProvider instead of class_exists
* use native reflections for annotation reader
* use native class and method reflections
* add RectorBetterReflectionSourceLocatorFactory
* add DynamicSourceLocator that is shared by PHPStan and Rector
* use ReflectoinProvider instead of class_exists()
* resolve native ClassMethodReflection
* make AnonymousFunctionFactory use reflection
* [DowngradePHP74] Improve DowngradeCovariantReturnTypeRector
* phsptan: avoid ClassReflection
* ProcessCommand: add file infos to source locator
* [DeadCode] Skip RemoveUnusedPublicMethodRector for test
* remove autolaod from tests
* misc
* remove is_a()
* [CI] enable only few dirs to avoid fails
* misc
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
* Renamed option to --exclude-path
* Exclude /**/tests/ by default
* Inverted order of downgrade
* Fixed verb
* Use sed to replace string
* Simplified message
* Use PHP version with "."
* Completed PHP versions to downgrade
* Execute Rector with --target-php-version
* Added quotes to array keys
* Allow to print command to output
* Execute script within workflow
* If rector fails, already exit 1
* Ignore PHP constraint
* Removed --dry-run and errors for testing
* Don't print command
* Run downgraded for ALL sets
* Include downgrade sets for testing
* Run all sets in a command each
* Added the target PHP version in each downgrade set
* Use a rector config file to pass exclude paths
* Exclude everything under /tests/
* Removed --dry-run
* Set unneeded transformations in false
* Exclude /ci/
* Exclude /compiler/
* Exclude DoctrineProvider
* Exclude classes for dependency-injection
* Exclude classes for http-kernel
* Exclude classes for symfony string
* Use cut instead of aws
For if the path has a space
* Calculate package execution order
* Downgrade packages on required order
* Consider the set to check package dependents
* Store packages_to_downgrade_by_set
* Store package_dependents["$package|$set"]
* Fixed converting from string to array
* Fixed converting string to array
* Fixed char
* Simplified counter
* Fixed string to array
* Fixed var
* Fixed getting dependents
* Fixed checking if dependent packages downgraded
* rector/rector has no dependents
* Simplified downgraded_packages
* Ignore dependent package on itself
* If circular dependencies, make the process fail
* Uncommented executing rector
* Exclude /stubs
* Calculate circular reference packages
* Break circular references
* Uncommented rector call
* Do downgrade ContainerBuilder
* Added expression-language as dep for PROD
* [ci-review] Generate Rector & Nodes documentation
* [ci-review] Apply coding standards
* [ci-review] Rector Rectify
* Obtain "rector/rector" from composer
* Removed commented code
* Don't do platform check for Composer v2
* Moved comment up
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* Must dump autload to remove platform_check.php
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* Copied file from master
* Use new convention (70000) for PHP versions (7.0)
* Fixed cs
* Fixed PHPStan
* Added "create-config" command - Initial commit
* [ci-review] Rector Rectify
* Moved rector config under custom folder
* Use predefined rector configs instead of injecting --set
* Created rector config files
* Use array of rector configs, even if only 1 is used
* Require once config file
* Fixed exclude paths
* Execute only last rector config (containing many sets)
* Exclude file that makes process fail
* Removed --dry-run
* Use existing option name
* Handle GROUP_RECTOR_CONFIGS in circular packages
* Changing PHP_VERSION_ID does not work, so commented rule
* Bug fixed => uncommented using rector
* Renamed NoParticularNodeRule to ForbiddenNodeRule
* [ci-review] Rector Rectify
* Fixed PHP version constants
* Added (failing) test
* Fixed issue for nullable scalars
* Can't run Rector with --set through CLI, removed
* Added (failing) test
* Fixed issue for __construct
* Fixed constant name
* Added (failing) test for self
* Added another (failing) test
* Fixed not adding "\" before "static", "self", etc
* [ci-review] Rector Rectify
* Skip downgrading CouchbaseBucketAdapter
* Renamed var
* Added (failing) test
* Fixed interface and abstract class issue
* [ci-review] Rector Rectify
* Fixed PHPStan error
* Create artifact of downgraded code
* Added missing spaces for args
* Use 4 spaces for consistency
* Ignore build folder in rector-php71.zip
* Switch to setup-php@v2
* Added (failing) test
* Issue is on calling method, not on constructor
* Implemented fix
* Renamed test
* Added further tests
* [ci-review] Rector Rectify
* Fixed PHPStan
* Fixed PHPStan
* Added (failing) test
* Fixed issue on new Class('foo', )
* Execute tests
* No need for quotes
* Made the artifact contain the folder, not a .zip
* Removed /compiler folder (it's been deleted?)
* Do upload the artifact as a .zip (too slow otherwise)
* Remove all tests, also from under vendor/
* Upgraded zip action version
* Change Composer's PHP requirement to 7.1
* Try exclude tests under vendor/
* Renamed artifact
* Try exclude tests under vendor/
* Updated test (to fail)
* If the float has no ".", add ".0" at the end
* Must remove deps before "composer require php"
* Replaced call to phpstan
* Cannot run PHPStan on 7.1, just run Rector
* Change Composer's PHP requirement to 7.1
* Remove DEV dependencies
* Require Symfony Polyfill libraries
* Rector without DEV needs phpstan.neon removed
* Run PHPStan
* Added paths to analyze
* Access PHPStan config from file
* Fixed relative paths
* Override the artifact with downgraded Composer too
* Uncommented scanDirectories
* Include tests/ in artifact
* Exclude */tests/*
* Ignore utils/phpstan-extensions
* PHPUnit is installed in DEV, can't use it in PROD
* "nette/application" is on DEV, may not exist on PROD
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* Improved comment after rectify
* Fixed previous messed-up merge
* Removed 1st slash
* Downgrade all dependencies together
* Replace the composer.json file
* Can't have more than 1 path to downgrade
* No need to change PHP requirement to 7.1 anymore
* Remove DEV dependencies before replacing composer.json
* Changed order of commands
* No need for --ignore-platform-req=php
* Add all Symfony polyfill libraries
* Require Symfony polyfill libraries earlier on
* Test removing `ignoreErrors` from PHPStan
* Remove ignored errors which do not apply
* Fixed the list of `excludes_analyse`
* Removed commented code
* Fixed PHPStan config
* Only analyze the target PHP version if GROUP_RECTOR_CONFIGS
* Simplified script: just analyze target PHP version
* Renamed downgrade sets
* Removed unneeded create-config command
* Removed call to deleted class
* Dropped ChangePhpVersionInPlatformCheckRector
* Must remove phpstan-for-rector.neon from PROD
* Do not execute --dry-run, it returns error
* Publish downgraded code to remote repository
* Removed commented code
* Standardized script code
* Initialize variables in script
* No need to initialize vars
* Remove the zip, do not copy to target repo
* Remove .git before deploying to target repo
* Copy files to rector-downgrade/
* Use branch "main"
* Copy also hidden files
* Remove docker publish image workflow
* Trigger own tests workflow
* Include "lowest"
* Run PHPStan instead of PHPUnit
* Run PHPStan in new temp directory
* Execute in same item
* "../" for --config doesn't work for PHPStan
* Added bare run test
* Added tests for PHP 7.2
* Added test
* Run with php
* Replaced namespace
* Added PHPUnit test for PHP 7.1
* Use PHP 7.1-compatible version of "doctrine/orm"
* Can't skip downgrading doctrine-annotation-generated
* Removed commented items
* Renamed test workflow
* Added comments on code
* Run all tests, not just 1
* Downgrade package from v3.1 to v3.0.7
* Run existing tests
* Revert tests
* [ci-review] Rector Rectify
Co-authored-by: Leonardo Losoviz <leo@getpop.org>
Co-authored-by: rector-bot <tomas@getrector.org>
it got error:
```
The workflow is not valid. .github/workflows/weekly_code_coverage.yaml (Line: 34, Col: 51): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
```
The `secrets` seems only needed for automatic PR.
* [fixtures] Enable validate-fixture-skip-naming check
* full path vendor vendor/symplify/easy-testing/bin/easy-testing validate-fixture-skip-naming rules tests
* 21 files
* more fixture
* various fix
* various fix
* more fixtures
* apply to packages rules tests utils
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* fixture fix
* done
* fixture fix
* enable file lenght rule
* longer file, just to show ci worked
* [ci] add ValidateFileLengthCommand
* [phpstan] drop PathsAreNotTooLongRule
* [Downgrade] Shorten property promotion rector rule
* [Symfony] Shorten AutoWireWithClassNameSuffixForMethodWithRequiredAnnotationRector name
* shorten fixture name
* rename ChangeControlArrayAccessToAnnotatedControlVariableRector to AnnotateMagicalControlArrayAccessRector
* rename ReplaceMagicEventPropertySubscriberWithEventClassSubscriberRector to ReplaceMagicPropertyWithEventClassRector
* rename GetConfigWithDefaultsArgumentToArrayMergeInCompilerExtensionRector to MergeDefaultsInGetConfigCompilerExtensionRector
* rename ChangeCollectionTypeOptionTypeFromStringToClassReferenceRector to ChangeStringCollectionOptionToConstantRector
* decouple ProjectFilesFinder
* add phpstan-for-rector config path, to separate phpstan and extensions that help Rector with precise types
* move type value object to value object
* moving
* remove KernelGetContainerAfterBootReturnTypeExtension, use one from symplify
* remove ContainerGetDynamicMethodReturnTypeExtension to ContainerGetReturnTypeExtension
* remove nette extension
* add nette-extension
* removed delegated rule
* delegate implmenets + code sample PHPStan rule to symplify
* [DeadCode] Fix dead method in property promotion
* bump workflows PHP version to 7.2, to respect symplify bump
* allow non-existing attributes in tests
* [SymfonyPhpConfig] Use Symplify package instead
* [SymfonyPhpConfig] Drop forgotten custom-jobs Rectors
* [CI] simplify set validation
* from inline functions to Static class
* cleanup
* decouple rector.php to allow static analysis and coding standards
* [CI] enable automated changelog regenerate
* [CI] drop generate docs, already part of PRs
* [PHPUnit] Add ConstructClassMethodToSetUpTestCaseRector
* make use of SetUpClassMethodFactory
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node
* update DecoupleClassMethodToOwnClassRector
* [ci] add rebase jobp
* disable fail fast for unit tests
* misc
* embed skip fixture of same before/after
* [Testing] Add exception on identical second half of the fixture, that should not change
* [ci] use composer 2 for code_analysis
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
* Create test cases
* Create rector
* Add closure to possible parent scopes
* Register in SOLID set
* Document the feature
* fix adding variable in closure
* move MoveVariableDeclarationNearReferenceRector to Assign category, based on getNodeTypes()
* ci: drop phpunit matcher, not much helpful
* ignore for now, many cases to cover
* prepare release
Co-authored-by: Anna Filina <afilina@gmail.com>
* skip rename
* add method call and variable name for MoveOutMethodCallInsideIfConditionRector
* decouple MethodCallToVariableNameResolver
* use trick with Scope if variable is already defined
* fixup! use trick with Scope if variable is already defined
* cover case with variable name and method call
* add decopule note future
* [ci-review] Rector Rectify
* [ci] try re-trigger ci-review after push automatically
Co-authored-by: rector-bot <tomas@getrector.org>
* [set] decouple new code-quality-strict
* decopule early-return set [closes#4464]
* [docker] drop prestissimo, as composer v2 does not need it
* [ci] move coding standard to ci_review
* [ci] try to run rector-ci on contributors
* add monorepo split for symfony-php-config
* [SOLID] Prevent replacing referenced parametes with inlined constnat value
* make Symfon 5.0- compatible
* add support for reference skip in constructor
* [rector] add support for reference skip in constructor
* [cs] add support for reference skip in constructor
* improve misisng rule feedback
* underscore
* Fix ChangeReadOnlyVariableWithDefaultValueToConstantRector for new
* add clear-cache to all commands
* colors
* [rector] colors
* [cs] colors
Co-authored-by: rector-bot <tomas@getrector.org>
* Github Actions: add a job which tests the lowest supported versions
* Update tests.yaml
* run lowest only on php 7.2
to reduce the number of generated jobs
* faise min webmozart/assert version
we need at least https://github.com/webmozart/assert/pull/160
* use quotes
* [CI] Add type-declaration set
* [rector] [CI] Add type-declaration set
* [cs] [CI] Add type-declaration set
* skip nullable void
* add anonymous parent/interface support
* refactor MultiExceptionCatchRector to use Catch_ over integers
* type fixes
* fix unoin array type override
* remove unused test cases
* drop overcomplicated InlineValidationRulesToArrayDefinitionRector
* skip assign on var
* [rector] skip assign on var
* [cs] skip assign on var
* [rector] [cs] skip assign on var
* skip assign on var
* fixes
* [rector] fixes
* [cs] fixes
Co-authored-by: rector-bot <tomas@getrector.org>
* service entity repo combo
* apply cs, add tests, fixes
* update doc parser
* [Generic] Add RemoveAnnotationRector
* add nullsafe nodes to docs
* drop AddEmptyLineBetweenCallsInPhpConfigRector, not that useful
* namespace and phpstan fix
* [ci] merge PHPStan compat to one job, no gain split attention
* [rector] [ci] merge PHPStan compat to one job, no gain split attention
* [cs] [ci] merge PHPStan compat to one job, no gain split attention
Co-authored-by: Marek Šimeček <marek.simecek@footshop.cz>
Co-authored-by: rector-bot <tomas@getrector.org>
Tomas Votruba
dependabot[bot]
Abdul Malik Ikhsan
Matthias Pigulla
Jan Mikeš
Michal Lulco
Tomáš Fejfar
Markus Staab
Krystian Marcisz