2
2
mirror of https://github.com/Llewellynvdm/nativefier.git synced 2024-11-15 17:27:08 +00:00
Commit Graph

977 Commits

Author SHA1 Message Date
Kenneth G. Franqueiro
a360f6c2ee Add more comprehensive tests
This implements the following cases:

* Basic runs for a specific version/platform/arch with default options
  (testing for existence of expected output files/folders)
* Runs for each target platform with `out` set
* Runs for each target platform with `asar` set
* Runs for each target platform with `prune` set
* Runs for each target platform with `ignore` set
  * This includes testing `ignore` including a path separator
  * This also includes testing that `ignore` entries are applied
    with the app folder trimmed
* Runs for each target platform with `overwrite` set / not set
* Runs with `all` set, with `arch` or `platform` each set to `all`,
  and with `platform` set to multiple platforms (comma-delimited or
  array)
* Tests specifically for the darwin target platform, to test
  `icon` and `sign`

The test logic is organized such that the version of Electron being
tested can be configured once centrally (in config.json), and the tests
will not run until after downloading any necessary electron versions
(to avoid timing out due to long downloads).

Resolves #77.
2015-06-28 16:57:59 -04:00
Kenneth G. Franqueiro
a157f716a5 Implement multi-target options and refactor code
This adds support for --all, --platform=all, and --arch=all.

In order to accommodate outputting multiple directories for multiple
platforms and architectures, this also implements a new directory
structure under the output folder (distinguished by both platform and
arch).  This structure is applied even to OS X distributions, which
formerly were output directly to an .app folder.  This could be considered
a backwards-incompatible change.

One other backwards-incompatible change is the value that the packager
function passes to the callback, which is now always an array of paths,
rather than just a single path.

The behavior of the icon option has also been modified to use its
basename and apply .ico or .icns depending on platform, to make it
usable with --all and --platform=all.  This attempts to maximize
backwards compatibility, by allowing a full filename to be specified,
but replacing the filename's extension with what is appropriate for
each target platform.  Alternatively, the extension can now be omitted.

In the process of implementing this, it became evident that some things
were being done in 3 different places, and weren't always being done
consistently, so I've deduplicated everything I could.

This also includes a few other changes to improve stability for
multi-target runs, and other fixes:

* Avoid targeting darwin if the environment doesn't support symlinks,
  to avoid the process bailing out on Windows
* Implement --overwrite centrally in index.js such that it explicitly
  skips if an output directory already exists, for consistency with
  all target platforms and to avoid any possible errors that would halt
  operation during one target of a multi-target run
* Use ncp instead of mv to move to finalPath, which avoids flakiness
  I noticed when testing on Windows 8 especially with multi-target runs
* Simplify temp directory logic by using a nested structure, so there
  is only one top-level directory to clean up
* Reinstate fix from #55 which seems to have been clobbered by a later
  merge
* linux.createApp now resolves to the final output directory;
  it was formerly resolving to the executable path
* mac.createApp now replaces space with underscore in bundle IDs
* Only the platform modules that are needed are loaded
* The win32 module only loads rcedit if needed

This also fixes a couple of missing updates to docs (readme/usage).

This commit addresses the following issues:

* Resolves #40
* Resolves #38
* Resolves #70
* Works around #71
* Resolves #84 by reinstating #55
2015-06-28 16:57:56 -04:00
Max Ogden
cff6ab50ee update readme 2015-06-27 20:08:47 -05:00
Max Ogden
714c02cc00 4.2.0 2015-06-27 20:07:42 -05:00
Max Ogden
2d128d8e99 fix testapp 2015-06-27 20:07:33 -05:00
Max Ogden
86edff69d8 add basic tests, remove unused folder, make linux out dir behave like other OSes 2015-06-27 19:48:35 -05:00
=^._.^=
5cc8a4b688 Merge pull request #82 from kfranqueiro/win32-ignore
Fix path separator replacement for ignore on Windows
2015-06-27 19:27:07 -05:00
=^._.^=
b80a060716 Merge pull request #76 from kfranqueiro/rename-helper
Fix #65: Rename Helper application on Mac OS X
2015-06-27 19:26:42 -05:00
Max Ogden
e01849fbf3 Merge branch 'tengyifei-master' 2015-06-27 19:26:07 -05:00
Max Ogden
ec321d2593 merge 2015-06-27 19:25:56 -05:00
=^._.^=
5e0edab6fe Merge pull request #74 from malept/rename-across-volumes
Fix renaming folders across volumes (when packaging for OS X)
2015-06-27 19:24:30 -05:00
=^._.^=
59228f2214 Merge pull request #63 from Rameshv/versionedit
Version info added to the final executable using rcedit
2015-06-27 19:24:11 -05:00
Max Ogden
065114b785 Merge branch 'chentsulin-master' 2015-06-27 19:23:40 -05:00
Max Ogden
e81627f11e merge 2015-06-27 19:23:33 -05:00
Yifei Teng
f39ba8c8f2 Support --overwrite 2015-06-23 10:54:45 -07:00
Max Ogden
fc98b0c8cb license file 2015-06-23 10:15:19 -07:00
Max Ogden
9da60ff319 bsd-2-clause 2015-06-23 10:15:19 -07:00
Kenneth G. Franqueiro
63db115257 Fix path separator replacement for ignore on Windows
This needs to be done when Windows is the host OS regardless of
the target platform, not vice versa.

Fixes #79.
2015-06-22 21:32:15 -04:00
Mark Lee
178b3d4cd3 Fix regression with the asar code
OSX has a special cased resources path.

Fixes #81.
2015-06-22 07:52:44 -07:00
Mark Lee
e4ad46b2a8 Fix renaming folders across volumes on OS X
Fixes #60.
2015-06-21 14:44:58 -07:00
Kenneth G. Franqueiro
dd2a5d4b68 Fix #65: Rename Helper application on Mac OS X
This fixes the helper process showing up in Activity Monitor as
"Electron Helper"; it will now show up as "<appname> Helper".
2015-06-17 23:50:52 -04:00
rameshv
947c2084aa skipping the rcedit when both icon & version-string hash is not
available
2015-06-17 16:51:31 +05:30
jden
554f3b7354 4.1.3 2015-06-16 10:40:40 -07:00
jden
5b1c5477f6 Merge pull request #69 from mmuehlberger/master
Add quotes around signing identity to allow spaces
2015-06-16 10:37:24 -07:00
Markus Mühlberger
c1269f62c8 Add quotes around signing identity to allow spaces 2015-06-16 18:49:44 +02:00
rameshv
d2a2f05476 version-string hash added to update the windows executable resource
using rcedit
2015-06-12 21:02:47 +05:30
Mark Lee
81340093ee Merge pull request #61 from malept/deduplicate-code
Deduplicate code + cleanup
2015-06-11 08:29:10 -07:00
Mark Lee
9bcb1a81d9 Rename variable which mirrors the function name 2015-06-09 20:38:09 -07:00
Mark Lee
bdc8c46362 Move prune to common module 2015-06-09 19:50:52 -07:00
Mark Lee
16b2feb39f Move user ignore filter to common module 2015-06-09 19:26:55 -07:00
Mark Lee
f3d17bceb2 Fix comment 2015-06-09 19:17:57 -07:00
Mark Lee
83dd1dcb34 Move asar code to a common location 2015-06-09 19:17:21 -07:00
C.T. Lin
f8c64fe755 get rid of sourcedir in path for ignore filter matching 2015-06-03 17:02:33 +08:00
jden
5f3704cdf5 Merge pull request #50 from jasonhinkle/patch-1
update readme with example for ignoring multiple directories
2015-06-02 15:23:47 -07:00
jasonhinkle
df06c346e8 Add example to readme for ignoring multiple folders 2015-06-02 17:06:37 -05:00
jden
db9301a971 Merge pull request #56 from jden/contributing-platform
Update CONTRIBUTING.md 📖 😉
2015-06-02 12:49:56 -07:00
jden
f751c9a91d Update CONTRIBUTING.md 📖 😉
typo
2015-06-01 15:10:37 -07:00
Sindre Sorhus
ac8aea014e 4.1.2 2015-05-27 22:12:55 +02:00
Sindre Sorhus
f14911cb6b fix incorrect option name in readme 2015-05-27 19:12:22 +02:00
jden
dbe467ba78 Merge pull request #48 from jenslind/docs-improvements
Docs improvements
2015-05-27 10:01:15 -07:00
Jens Lind
aed7968aed Fixed typos 2015-05-27 18:50:47 +02:00
Jens Lind
199283f251 Added API section to readme 2015-05-27 18:46:42 +02:00
Jens Lind
eeb91ef31e Changed --ignore part in readme 2015-05-27 18:46:17 +02:00
Max Ogden
41dafb927a 4.1.1 2015-05-21 21:06:43 -07:00
=^._.^=
37e319281c Merge pull request #46 from zaggino/zaggino/fix-win
convert slashes on windows so unix-format ignores work
2015-05-21 21:06:19 -07:00
=^._.^=
9b6237afca Merge pull request #45 from zaggino/zaggino/fix
fix defaultIgnores to be proper reg-exps
2015-05-21 21:05:48 -07:00
=^._.^=
5ad54e7c5e Merge pull request #43 from jden/dereference-symlinks
always dereference symlinks - per #42
2015-05-21 21:05:43 -07:00
Martin Zagora
13897ff303 convert slashes on windows so unix-format ignores work 2015-05-22 11:25:41 +10:00
Martin Zagora
5c82a97f05 fix defaultIgnores to be proper reg-exps 2015-05-22 10:28:04 +10:00
jden
aa5c6187e3 always dereference symlinks - per #42 2015-05-20 19:05:47 -07:00